r41812 - in /trunk/liblatex-table-perl/debian: changelog patches/remove-ProhibitMagicNumbers-annotation.patch patches/series rules

carnil-guest at users.alioth.debian.org carnil-guest at users.alioth.debian.org
Fri Aug 14 08:11:04 UTC 2009


Author: carnil-guest
Date: Fri Aug 14 08:10:27 2009
New Revision: 41812

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=41812
Log:
TODO: Should we disable perlcritic test completely?
* Add patch for FTBFS removing an unused perlcritc annotation
in lib/LaTeX/Table/Types/TypeI.pm.

Added:
    trunk/liblatex-table-perl/debian/patches/remove-ProhibitMagicNumbers-annotation.patch
Modified:
    trunk/liblatex-table-perl/debian/changelog
    trunk/liblatex-table-perl/debian/patches/series
    trunk/liblatex-table-perl/debian/rules

Modified: trunk/liblatex-table-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/liblatex-table-perl/debian/changelog?rev=41812&op=diff
==============================================================================
--- trunk/liblatex-table-perl/debian/changelog (original)
+++ trunk/liblatex-table-perl/debian/changelog Fri Aug 14 08:10:27 2009
@@ -1,11 +1,15 @@
 liblatex-table-perl (0.9.17-2) UNRELEASED; urgency=low
+
+  TODO: Should we disable perlcritic test completely?
 
   * Add patch for FTBFS when a spell checker is installed and
     perlcritic test reports words in POD not in the spell checker
     lists.
+  * Add patch for FTBFS removing an unused perlcritc annotation
+    in lib/LaTeX/Table/Types/TypeI.pm.
   * debian/control: Add quilt to Build-Depends.
 
- -- Salvatore Bonaccorso <salvatore.bonaccorso at gmail.com>  Fri, 14 Aug 2009 05:58:02 +0200
+ -- Salvatore Bonaccorso <salvatore.bonaccorso at gmail.com>  Fri, 14 Aug 2009 10:09:29 +0200
 
 liblatex-table-perl (0.9.17-1) unstable; urgency=low
 

Added: trunk/liblatex-table-perl/debian/patches/remove-ProhibitMagicNumbers-annotation.patch
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/liblatex-table-perl/debian/patches/remove-ProhibitMagicNumbers-annotation.patch?rev=41812&op=file
==============================================================================
--- trunk/liblatex-table-perl/debian/patches/remove-ProhibitMagicNumbers-annotation.patch (added)
+++ trunk/liblatex-table-perl/debian/patches/remove-ProhibitMagicNumbers-annotation.patch Fri Aug 14 08:10:27 2009
@@ -1,0 +1,24 @@
+Description: Fix FTBFS due to a no critic annotation in
+ lib/LaTeX/Table/Types/TypeI.pm which wasn't needed anymore 
+ and caused the perlcritic test fail. 
+Origin: vendor
+Author: Salvatore Bonaccorso <salvatore.bonaccorso at gmail.com>
+Last-Update: 2009-08-14
+--- a/lib/LaTeX/Table/Types/TypeI.pm
++++ b/lib/LaTeX/Table/Types/TypeI.pm
+@@ -23,12 +23,10 @@
+ has '_tabular_environment' => ( is => 'ro', required => 1 );
+ has '_template'            => ( is => 'ro', required => 1 );
+ 
+-has '_RULE_TOP_ID'   => ( is => 'ro', default => 0 );
+-has '_RULE_MID_ID'   => ( is => 'ro', default => 1 );
+-has '_RULE_INNER_ID' => ( is => 'ro', default => 2 );
+-## no critic (ValuesAndExpressions::ProhibitMagicNumbers)
++has '_RULE_TOP_ID'    => ( is => 'ro', default => 0 );
++has '_RULE_MID_ID'    => ( is => 'ro', default => 1 );
++has '_RULE_INNER_ID'  => ( is => 'ro', default => 2 );
+ has '_RULE_BOTTOM_ID' => ( is => 'ro', default => 3 );
+-## use critic
+ 
+ ###########################################################################
+ # Usage      : $self->_header(\@header,\@data);

Modified: trunk/liblatex-table-perl/debian/patches/series
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/liblatex-table-perl/debian/patches/series?rev=41812&op=diff
==============================================================================
--- trunk/liblatex-table-perl/debian/patches/series (original)
+++ trunk/liblatex-table-perl/debian/patches/series Fri Aug 14 08:10:27 2009
@@ -1,1 +1,2 @@
 fix-ftbfs-with-spellchecker-installed.patch
+remove-ProhibitMagicNumbers-annotation.patch

Modified: trunk/liblatex-table-perl/debian/rules
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/liblatex-table-perl/debian/rules?rev=41812&op=diff
==============================================================================
--- trunk/liblatex-table-perl/debian/rules (original)
+++ trunk/liblatex-table-perl/debian/rules Fri Aug 14 08:10:27 2009
@@ -1,7 +1,7 @@
 #!/usr/bin/make -f
 
 %:
-	dh $@
+	dh --with quilt $@
 
 override_dh_auto_test:
 	TEST_AUTHOR=1 dh_auto_test




More information about the Pkg-perl-cvs-commits mailing list