r42605 - in /trunk/libmoosex-types-perl: Changes META.yml debian/changelog lib/MooseX/Types.pm t/21_coerce_parameterized_types.t

jawnsy-guest at users.alioth.debian.org jawnsy-guest at users.alioth.debian.org
Sun Aug 23 23:14:37 UTC 2009


Author: jawnsy-guest
Date: Sun Aug 23 23:14:31 2009
New Revision: 42605

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=42605
Log:
* New upstream release
  + Reverse changes in 0.18 as it broke lots of code

Modified:
    trunk/libmoosex-types-perl/Changes
    trunk/libmoosex-types-perl/META.yml
    trunk/libmoosex-types-perl/debian/changelog
    trunk/libmoosex-types-perl/lib/MooseX/Types.pm
    trunk/libmoosex-types-perl/t/21_coerce_parameterized_types.t

Modified: trunk/libmoosex-types-perl/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmoosex-types-perl/Changes?rev=42605&op=diff
==============================================================================
--- trunk/libmoosex-types-perl/Changes (original)
+++ trunk/libmoosex-types-perl/Changes Sun Aug 23 23:14:31 2009
@@ -1,4 +1,10 @@
 Revision history for MooseX-Types
+
+0.19    Sun Aug 23 15:03:02 EDT 2009
+        - un-fix coercions on parameterized types, since it broke
+          MooseX::Method::Signatures, as well as any other code that relied on
+          new type constraint objects being generated each time a type was
+          parameterized (hdp).
 
 0.18    Sat Aug 22 12:50:42 EDT 2009
         - fix coercions on parameterized types (Hans Dieter Pearcey).

Modified: trunk/libmoosex-types-perl/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmoosex-types-perl/META.yml?rev=42605&op=diff
==============================================================================
--- trunk/libmoosex-types-perl/META.yml (original)
+++ trunk/libmoosex-types-perl/META.yml Sun Aug 23 23:14:31 2009
@@ -24,7 +24,7 @@
 provides:
   MooseX::Types:
     file: lib/MooseX/Types.pm
-    version: 0.18
+    version: 0.19
   MooseX::Types::Base:
     file: lib/MooseX/Types/Base.pm
   MooseX::Types::CheckedUtilExports:
@@ -52,4 +52,4 @@
   perl: 5.8.0
 resources:
   license: http://dev.perl.org/licenses/
-version: 0.18
+version: 0.19

Modified: trunk/libmoosex-types-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmoosex-types-perl/debian/changelog?rev=42605&op=diff
==============================================================================
--- trunk/libmoosex-types-perl/debian/changelog (original)
+++ trunk/libmoosex-types-perl/debian/changelog Sun Aug 23 23:14:31 2009
@@ -1,3 +1,10 @@
+libmoosex-types-perl (0.19-1) UNRELEASED; urgency=low
+
+  * New upstream release
+    + Reverse changes in 0.18 as it broke lots of code
+
+ -- Jonathan Yu <frequency at cpan.org>  Sun, 23 Aug 2009 14:48:46 -0400
+
 libmoosex-types-perl (0.18-1) unstable; urgency=low
 
   [ Jonathan Yu ]

Modified: trunk/libmoosex-types-perl/lib/MooseX/Types.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmoosex-types-perl/lib/MooseX/Types.pm?rev=42605&op=diff
==============================================================================
--- trunk/libmoosex-types-perl/lib/MooseX/Types.pm (original)
+++ trunk/libmoosex-types-perl/lib/MooseX/Types.pm Sun Aug 23 23:14:31 2009
@@ -20,7 +20,7 @@
 use namespace::clean -except => [qw( meta )];
 
 use 5.008;
-our $VERSION = '0.18';
+our $VERSION = '0.19';
 my $UndefMsg = q{Action for type '%s' not yet defined in library '%s'};
 
 =head1 SYNOPSIS
@@ -431,11 +431,13 @@
     # It's obnoxious to have to parameterize before looking for the TC, but the
     # alternative is to hard-code the assumption that the name is
     # "$name[$args[0]]", which would be worse.
-    if (my $existing =
-        Moose::Util::TypeConstraints::find_type_constraint($parameterized->name)) {
-        return $existing;
-    }
-    Moose::Util::TypeConstraints::register_type_constraint($parameterized);
+    # This breaks MXMS, unfortunately, which relies on things like Tuple[...]
+    # creating new type objects each time.
+    # if (my $existing =
+    #     Moose::Util::TypeConstraints::find_type_constraint($parameterized->name)) {
+    #     return $existing;
+    # }
+    # Moose::Util::TypeConstraints::register_type_constraint($parameterized);
     return $parameterized;
 }
 

Modified: trunk/libmoosex-types-perl/t/21_coerce_parameterized_types.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmoosex-types-perl/t/21_coerce_parameterized_types.t?rev=42605&op=diff
==============================================================================
--- trunk/libmoosex-types-perl/t/21_coerce_parameterized_types.t (original)
+++ trunk/libmoosex-types-perl/t/21_coerce_parameterized_types.t Sun Aug 23 23:14:31 2009
@@ -45,8 +45,10 @@
 
 my $instance = AClass->new;
 
+{ local $TODO = "see comments in MooseX::Types->create_arged_...";
 lives_ok { $instance->parameterized('foo') }
     'coercion applied to parameterized type';
+}
 
 lives_ok { $instance->subtype_parameterized('foo') }
     'coercion applied to subtype';




More information about the Pkg-perl-cvs-commits mailing list