r30649 - in /branches/upstream/libipc-system-simple-perl/current: Changes META.yml lib/IPC/System/Simple.pm

[gregoa at users.alioth.debian.org]

Author: gregoa
Date: Fri Feb 13 13:33:45 2009
New Revision: 30649

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=30649
Log:
[svn-upgrade] Integrating new upstream version, libipc-system-simple-perl (1.18)

Modified:
    branches/upstream/libipc-system-simple-perl/current/Changes
    branches/upstream/libipc-system-simple-perl/current/META.yml
    branches/upstream/libipc-system-simple-perl/current/lib/IPC/System/Simple.pm

Modified: branches/upstream/libipc-system-simple-perl/current/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libipc-system-simple-perl/current/Changes?rev=30649&op=diff
==============================================================================
--- branches/upstream/libipc-system-simple-perl/current/Changes (original)
+++ branches/upstream/libipc-system-simple-perl/current/Changes Fri Feb 13 13:33:45 2009
@@ -1,4 +1,14 @@
 Revision history for Perl extension IPC::System::Simple.
+
+1.18  Sun Feb  8 19:09:15 AUSEDT 2009
+
+        * BUGFIX: IPC::System::Simple should now compile cleanly
+          under 5.6.0 and 5.6.1 (as well as 5.6.2+).  Many thanks
+          to David Golden for spotting this bug.  (RT #43098)
+
+        * DOCUMENTATION: "Advanced" is now spelt correctly under
+          in the section "Advanced Usage".  Many thanks to
+          Raymond Wan for spotting this typo.  (RT #42705)
 
 1.17  Fri Dec 19 00:45:16 AUSEDT 2008
         * TEST: Tests to ensure that passing undefined values to

Modified: branches/upstream/libipc-system-simple-perl/current/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libipc-system-simple-perl/current/META.yml?rev=30649&op=diff
==============================================================================
--- branches/upstream/libipc-system-simple-perl/current/META.yml (original)
+++ branches/upstream/libipc-system-simple-perl/current/META.yml Fri Feb 13 13:33:45 2009
@@ -29,4 +29,4 @@
   bugtracker: http://rt.cpan.org/NoAuth/Bugs.html?Dist=IPC-System-Simple
   license: http://dev.perl.org/licenses/
   repository: http://github.com/pfenwick/ipc-system-simple/tree/master
-version: 1.17
+version: 1.18

Modified: branches/upstream/libipc-system-simple-perl/current/lib/IPC/System/Simple.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libipc-system-simple-perl/current/lib/IPC/System/Simple.pm?rev=30649&op=diff
==============================================================================
--- branches/upstream/libipc-system-simple-perl/current/lib/IPC/System/Simple.pm (original)
+++ branches/upstream/libipc-system-simple-perl/current/lib/IPC/System/Simple.pm Fri Feb 13 13:33:45 2009
@@ -10,19 +10,40 @@
 use Config;
 use constant WINDOWS => ($^O eq 'MSWin32');
 use constant VMS     => ($^O eq 'VMS');
-use if WINDOWS, 'Win32::Process', qw(INFINITE NORMAL_PRIORITY_CLASS);
-use if WINDOWS, 'File::Spec';
-use if WINDOWS, 'Win32';
-
-# This uses the same rules as the core win32.c/get_shell() call.
-
-use if WINDOWS, 'constant', WINDOWS_SHELL => eval { Win32::IsWinNT() }
-	                                  ? [ qw(cmd.exe /x/d/c) ]
-                                          : [ qw(command.com /c) ];
-
-# These are used when invoking _win32_capture
-use if WINDOWS, 'constant', NO_SHELL  => 0;
-use if WINDOWS, 'constant', USE_SHELL => 1;
+
+BEGIN {
+
+    # It would be lovely to use the 'if' module here, but it didn't
+    # enter core until 5.6.2, and we want to keep 5.6.0 compatibility.
+
+
+    if (WINDOWS) {
+
+        ## no critic (ProhibitStringyEval)
+
+        eval q{
+            use Win32::Process qw(INFINITE NORMAL_PRIORITY_CLASS);
+            use File::Spec;
+            use Win32;
+
+            # This uses the same rules as the core win32.c/get_shell() call.
+
+            use constant WINDOWS_SHELL => eval { Win32::IsWinNT() }
+                                            ? [ qw(cmd.exe /x/d/c) ]
+                                            : [ qw(command.com /c) ];
+
+            # These are used when invoking _win32_capture
+            use constant NO_SHELL  => 0;
+            use constant USE_SHELL => 1;
+
+        };
+
+        ## use critic
+
+        # Die nosily if any of the above broke.
+        die $@ if $@;
+    }
+}
 
 # Note that we don't use WIFSTOPPED because perl never uses
 # the WUNTRACED flag, and hence will never return early from
@@ -63,7 +84,7 @@
     $EXITVAL EXIT_ANY
 );
 
-our $VERSION = '1.17';
+our $VERSION = '1.18';
 our $EXITVAL = -1;
 
 my @Signal_from_number = split(' ', $Config{sig_name});
@@ -673,7 +694,7 @@
 
   my @lines  = capturex([0..5], "some_command", @args);
 
-=head1 ADVNACED USAGE
+=head1 ADVANCED USAGE
 
 =head2 run() and system()