r31151 - in /trunk/libgstreamer-interfaces-perl/debian: changelog patches/skip_alsamixer_tests.patch

[antonio-guest at users.alioth.debian.org]

Author: antonio-guest
Date: Fri Feb 27 22:10:08 2009
New Revision: 31151

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=31151
Log:
lintian/cowbuilder clean, ready for review

Modified:
    trunk/libgstreamer-interfaces-perl/debian/changelog
    trunk/libgstreamer-interfaces-perl/debian/patches/skip_alsamixer_tests.patch

Modified: trunk/libgstreamer-interfaces-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libgstreamer-interfaces-perl/debian/changelog?rev=31151&op=diff
==============================================================================
--- trunk/libgstreamer-interfaces-perl/debian/changelog (original)
+++ trunk/libgstreamer-interfaces-perl/debian/changelog Fri Feb 27 22:10:08 2009
@@ -1,14 +1,4 @@
-libgstreamer-interfaces-perl (0.04-1) UNRELEASED; urgency=low
-
-  TODO:
-  As Antonio has already found it, the package doesn't build in a
-  {p,cow}builder chroot because /dev/mixer is not accessible:
-  crw-rw---- 2 root audio 14, 0 Feb  2  2007 /dev/mixer
-  so no read permission for user pbuilder/1234
-  
-  My fear is that the same will happen on the buildds, so we should find a
-  solution IMO ... Maybe a patch for the test to skip stuff if /dev/mixer is
-  not available or we don't have the permission to read from it?
+libgstreamer-interfaces-perl (0.04-1) unstable; urgency=low
 
   * Initial Release. (Closes: #516835)
 

Modified: trunk/libgstreamer-interfaces-perl/debian/patches/skip_alsamixer_tests.patch
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libgstreamer-interfaces-perl/debian/patches/skip_alsamixer_tests.patch?rev=31151&op=diff
==============================================================================
--- trunk/libgstreamer-interfaces-perl/debian/patches/skip_alsamixer_tests.patch (original)
+++ trunk/libgstreamer-interfaces-perl/debian/patches/skip_alsamixer_tests.patch Fri Feb 27 22:10:08 2009
@@ -2,24 +2,35 @@
 
 Index: libgstreamer-interfaces-perl/t/GstPropertyProbe.t
 ===================================================================
---- libgstreamer-interfaces-perl.orig/t/GstPropertyProbe.t	2009-02-27 21:51:44.000000000 +0000
-+++ libgstreamer-interfaces-perl/t/GstPropertyProbe.t	2009-02-27 21:53:43.000000000 +0000
-@@ -9,6 +9,14 @@
+--- libgstreamer-interfaces-perl.orig/t/GstPropertyProbe.t	2009-02-27 22:02:59.000000000 +0000
++++ libgstreamer-interfaces-perl/t/GstPropertyProbe.t	2009-02-27 22:04:13.000000000 +0000
+@@ -1,7 +1,7 @@
+ #!/usr/bin/perl
+ use strict;
+ use warnings;
+-use Test::More tests => 9;
++use Test::More qw(no_plan);
+ 
+ # $Id: GstPropertyProbe.t,v 1.3 2006/07/07 22:02:22 kaffeetisch Exp $
+ 
+@@ -9,6 +9,16 @@
  use GStreamer -init;
  use GStreamer::Interfaces;
  
 +# if there is no r/w access to /dev/alsamixer we need to skip some tests
 +my $alsamixer_rwaccess;
-+if ( open ("r+", "/dev/alsamixer") ) {
++if ( open (FD, '+<', "/dev/alsamixer") ) {
 +        $alsamixer_rwaccess = 1;
++        close (FD);
 +} else {
 +        $alsamixer_rwaccess = 0;
 +}
 +
++# the actual tests
  my $plugin = "alsamixer";
  my $property = "device";
  
-@@ -24,11 +32,15 @@
+@@ -24,11 +34,15 @@
  is($element -> needs_probe($pspec), TRUE);
  $element -> probe_property($pspec);