r29568 - in /trunk/libcrypt-openssl-dsa-perl/debian: changelog patches/check-do_verify-return-code

ryan52-guest at users.alioth.debian.org ryan52-guest at users.alioth.debian.org
Mon Jan 12 02:28:45 UTC 2009


Author: ryan52-guest
Date: Mon Jan 12 02:28:37 2009
New Revision: 29568

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=29568
Log:
Fix man page to specify that an error happened when the return value
for verify is -1 (Closes: #511519)

Modified:
    trunk/libcrypt-openssl-dsa-perl/debian/changelog
    trunk/libcrypt-openssl-dsa-perl/debian/patches/check-do_verify-return-code

Modified: trunk/libcrypt-openssl-dsa-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcrypt-openssl-dsa-perl/debian/changelog?rev=29568&op=diff
==============================================================================
--- trunk/libcrypt-openssl-dsa-perl/debian/changelog (original)
+++ trunk/libcrypt-openssl-dsa-perl/debian/changelog Mon Jan 12 02:28:37 2009
@@ -7,10 +7,10 @@
     (source stanza).
 
   [ Ryan Niebur ]
-  * check the return code of DSA_do_verify, and croak on error (Closes:
-    #511519)
+  * Fix man page to specify that an error happened when the return value
+    for verify is -1 (Closes: #511519)
 
- -- Ryan Niebur <ryanryan52 at gmail.com>  Sun, 11 Jan 2009 13:51:52 -0800
+ -- Ryan Niebur <ryanryan52 at gmail.com>  Sun, 11 Jan 2009 18:25:43 -0800
 
 libcrypt-openssl-dsa-perl (0.13-3) unstable; urgency=low
 

Modified: trunk/libcrypt-openssl-dsa-perl/debian/patches/check-do_verify-return-code
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcrypt-openssl-dsa-perl/debian/patches/check-do_verify-return-code?rev=29568&op=diff
==============================================================================
--- trunk/libcrypt-openssl-dsa-perl/debian/patches/check-do_verify-return-code (original)
+++ trunk/libcrypt-openssl-dsa-perl/debian/patches/check-do_verify-return-code Mon Jan 12 02:28:37 2009
@@ -1,11 +1,30 @@
---- a/DSA.xs
-+++ b/DSA.xs
-@@ -139,6 +139,8 @@
-     CODE:
-         dgst_pv = SvPV(dgst, dgst_len);
-         RETVAL = DSA_do_verify(dgst_pv, dgst_len, sig, dsa);
-+        if (RETVAL == -1)
-+          croak("Error in DSA_do_verify: %s",ERR_error_string(ERR_get_error(), NULL));
-     OUTPUT:
-         RETVAL
+--- a/lib/Crypt/OpenSSL/DSA.pm
++++ b/lib/Crypt/OpenSSL/DSA.pm
+@@ -43,12 +43,18 @@
+   my $sig      = $dsa_priv->sign($message);
+   my $dsa_pub  = Crypt::OpenSSL::DSA->read_pub_key( $filename );
+   my $valid    = $dsa_pub->verify($message, $sig);
++  if($valid == 1) {
++    print "Valid signature\n";
++  }
  
+   # using keys from PEM strings
+   my $dsa_priv = Crypt::OpenSSL::DSA->read_priv_key_str( $key_string );
+   my $sig      = $dsa_priv->sign($message);
+   my $dsa_pub  = Crypt::OpenSSL::DSA->read_pub_key_str( $key_string );
+   my $valid    = $dsa_pub->verify($message, $sig);
++  if($valid == 1) {
++    print "Valid signature\n";
++  }
+ 
+ =head1 DESCRIPTION
+ 
+@@ -128,6 +134,8 @@
+ 
+ Similar to C<verify>, but uses a L<Crypt::OpenSSL::DSA::Signature> object.
+ 
++verify and do_verify will return -1 on error, 0 on incorrect signature, and 1 on a correct signature.
++
+ =item $dsa->write_params( $filename );
+ 
+ Writes the parameters into a PEM file.




More information about the Pkg-perl-cvs-commits mailing list