r32159 - in /trunk/libauthen-sasl-cyrus-perl/debian: changelog patches/correct-write-return-value patches/series

rra at users.alioth.debian.org rra at users.alioth.debian.org
Tue Mar 17 21:29:21 UTC 2009


Author: rra
Date: Tue Mar 17 21:29:15 2009
New Revision: 32159

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=32159
Log:
* The tied file handle implementation in Authen::SASL::Cyrus::Security
  passed along the return value of print in its WRITE implementation.
  This is always 1, and WRITE is supposed to behave like syswrite and
  return the number of octets written.  Patch from Sergio Gelato.
  (Closes: #486698)

Added:
    trunk/libauthen-sasl-cyrus-perl/debian/patches/correct-write-return-value
Modified:
    trunk/libauthen-sasl-cyrus-perl/debian/changelog
    trunk/libauthen-sasl-cyrus-perl/debian/patches/series

Modified: trunk/libauthen-sasl-cyrus-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libauthen-sasl-cyrus-perl/debian/changelog?rev=32159&op=diff
==============================================================================
--- trunk/libauthen-sasl-cyrus-perl/debian/changelog (original)
+++ trunk/libauthen-sasl-cyrus-perl/debian/changelog Tue Mar 17 21:29:15 2009
@@ -1,10 +1,18 @@
 libauthen-sasl-cyrus-perl (0.13-server-4) UNRELEASED; urgency=low
 
+  [ gregor herrmann ]
   * Add debian/README.source to document quilt usage, as required by
     Debian Policy since 3.8.0.
   * debian/control: Changed: Switched Vcs-Browser field to ViewSVN
     (source stanza).
   * debian/control: Added: ${misc:Depends} to Depends: field.
+
+  [ Russ Allbery ]
+  * The tied file handle implementation in Authen::SASL::Cyrus::Security
+    passed along the return value of print in its WRITE implementation.
+    This is always 1, and WRITE is supposed to behave like syswrite and
+    return the number of octets written.  Patch from Sergio Gelato.
+    (Closes: #486698)
 
  -- gregor herrmann <gregoa at debian.org>  Wed, 06 Aug 2008 21:33:23 -0300
 

Added: trunk/libauthen-sasl-cyrus-perl/debian/patches/correct-write-return-value
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libauthen-sasl-cyrus-perl/debian/patches/correct-write-return-value?rev=32159&op=file
==============================================================================
--- trunk/libauthen-sasl-cyrus-perl/debian/patches/correct-write-return-value (added)
+++ trunk/libauthen-sasl-cyrus-perl/debian/patches/correct-write-return-value Tue Mar 17 21:29:15 2009
@@ -1,0 +1,28 @@
+Perl's print function returns true, not the number of octets printed,
+but when overloading WRITE in a tied file handle, we must return the
+number of octets written or -1 on error.  Adjust the return value of
+WRITE accordingly.
+
+Patch from Sergio Gelato <Sergio.Gelato at astro.su.se>
+
+Debian Bug#486698.
+
+--- libauthen-sasl-cyrus-perl.orig/lib/Authen/SASL/Cyrus/Security.pm
++++ libauthen-sasl-cyrus-perl/lib/Authen/SASL/Cyrus/Security.pm
+@@ -77,6 +77,7 @@
+ 
+   $fh = $ref->{fh};
+   $clearbuf = substr($string, 0, $len);
++  $len = length($clearbuf);
+   $maxbuf = $ref->{conn}->property("maxout");
+   if ($len < $maxbuf) {
+     $cryptbuf = $ref->{conn}->encode($clearbuf);
+@@ -94,7 +95,7 @@
+       $offset += $chunksize;
+     }
+   }
+-  print $fh $cryptbuf;
++  return (print $fh $cryptbuf) ? $len : -1;
+ }
+ 
+ # Given a GLOB ref, tie the filehandle of the GLOB to this class

Modified: trunk/libauthen-sasl-cyrus-perl/debian/patches/series
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libauthen-sasl-cyrus-perl/debian/patches/series?rev=32159&op=diff
==============================================================================
--- trunk/libauthen-sasl-cyrus-perl/debian/patches/series (original)
+++ trunk/libauthen-sasl-cyrus-perl/debian/patches/series Tue Mar 17 21:29:15 2009
@@ -1,1 +1,2 @@
 encode-no-more-than-MAX_OUTBUF.patch
+correct-write-return-value




More information about the Pkg-perl-cvs-commits mailing list