r34763 - in /trunk/libvideo-info-perl/debian/patches: mpeg-autovivify.patch mpeg-redefines.patch oqt-optional.patch pod-errors.patch test-m2v.patch

[jawnsy-guest at users.alioth.debian.org]

Author: jawnsy-guest
Date: Mon May  4 16:48:47 2009
New Revision: 34763

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=34763
Log:
Added descriptions for patches

Modified:
    trunk/libvideo-info-perl/debian/patches/mpeg-autovivify.patch
    trunk/libvideo-info-perl/debian/patches/mpeg-redefines.patch
    trunk/libvideo-info-perl/debian/patches/oqt-optional.patch
    trunk/libvideo-info-perl/debian/patches/pod-errors.patch
    trunk/libvideo-info-perl/debian/patches/test-m2v.patch

Modified: trunk/libvideo-info-perl/debian/patches/mpeg-autovivify.patch
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libvideo-info-perl/debian/patches/mpeg-autovivify.patch?rev=34763&op=diff
==============================================================================
--- trunk/libvideo-info-perl/debian/patches/mpeg-autovivify.patch (original)
+++ trunk/libvideo-info-perl/debian/patches/mpeg-autovivify.patch Mon May  4 16:48:47 2009
@@ -1,3 +1,9 @@
+Some strings are tested to see if they are the empty string - ie, $str eq ''
+without first checking that they are even defined. As a result, an undef
+value will cause warnings due to autovivification of those variables.
+
+This patch adds 'defined $str' && previous conditions, so that definedness
+is checked first.
 Index: Video-Info-0.993/Info/MPEG.pm
 ===================================================================
 --- Video-Info-0.993.orig/Info/MPEG.pm	2009-05-02 23:05:40.000000000 -0400

Modified: trunk/libvideo-info-perl/debian/patches/mpeg-redefines.patch
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libvideo-info-perl/debian/patches/mpeg-redefines.patch?rev=34763&op=diff
==============================================================================
--- trunk/libvideo-info-perl/debian/patches/mpeg-redefines.patch (original)
+++ trunk/libvideo-info-perl/debian/patches/mpeg-redefines.patch Mon May  4 16:48:47 2009
@@ -1,3 +1,7 @@
+This patch gets rid of warnings due to redefinition of 'minutes' and 'MMSS',
+which are defined by Class::MakeMethods::Emulator::MethodMaker. It looks
+like the preferred thing to do would be using the definition from the file
+itself, rather than the autogenerated one.
 Index: Video-Info-0.993/Info/MPEG.pm
 ===================================================================
 --- Video-Info-0.993.orig/Info/MPEG.pm	2009-05-02 23:01:56.000000000 -0400

Modified: trunk/libvideo-info-perl/debian/patches/oqt-optional.patch
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libvideo-info-perl/debian/patches/oqt-optional.patch?rev=34763&op=diff
==============================================================================
--- trunk/libvideo-info-perl/debian/patches/oqt-optional.patch (original)
+++ trunk/libvideo-info-perl/debian/patches/oqt-optional.patch Mon May  4 16:48:47 2009
@@ -1,3 +1,7 @@
+This is a patch to make Video::OpenQuicktime optional, since it seems to be
+a tricky library to package with potentially limited use to the community.
+If there is a need for Quicktime support, then OpenQuicktime and
+Video::OpenQuicktime will need to be packaged as well.
 Index: Video-Info-0.993/t/Quicktime.t
 ===================================================================
 --- Video-Info-0.993.orig/t/Quicktime.t	2009-05-02 23:21:32.000000000 -0400

Modified: trunk/libvideo-info-perl/debian/patches/pod-errors.patch
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libvideo-info-perl/debian/patches/pod-errors.patch?rev=34763&op=diff
==============================================================================
--- trunk/libvideo-info-perl/debian/patches/pod-errors.patch (original)
+++ trunk/libvideo-info-perl/debian/patches/pod-errors.patch Mon May  4 16:48:47 2009
@@ -1,3 +1,5 @@
+This patch fixes a few minor errors relating to POD. Mostly things like
+item lists which are not properly closed (over without back, etc)
 Index: Video-Info-0.993/Info.pm
 ===================================================================
 --- Video-Info-0.993.orig/Info.pm	2009-05-02 23:32:18.000000000 -0400

Modified: trunk/libvideo-info-perl/debian/patches/test-m2v.patch
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libvideo-info-perl/debian/patches/test-m2v.patch?rev=34763&op=diff
==============================================================================
--- trunk/libvideo-info-perl/debian/patches/test-m2v.patch (original)
+++ trunk/libvideo-info-perl/debian/patches/test-m2v.patch Mon May  4 16:48:47 2009
@@ -1,3 +1,5 @@
+$file->comments returns undef rather than the empty string, so test for it
+appropriately.
 Index: Video-Info-0.993/t/M2V.t
 ===================================================================
 --- Video-Info-0.993.orig/t/M2V.t	2009-05-02 23:09:48.000000000 -0400