r36398 - in /trunk/libnet-twitter-diff-perl/debian: changelog control patches/ patches/array-diff.patch patches/series rules

Mon May 25 16:05:04 UTC 2009

Author: jawnsy-guest
Date: Mon May 25 16:04:58 2009
New Revision: 36398

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=36398
Log:
Added a patch and some notes to changelog. Rewrote stuff for control :-). New d/rules format.

Added:
    trunk/libnet-twitter-diff-perl/debian/patches/
    trunk/libnet-twitter-diff-perl/debian/patches/array-diff.patch
    trunk/libnet-twitter-diff-perl/debian/patches/series
Modified:
    trunk/libnet-twitter-diff-perl/debian/changelog
    trunk/libnet-twitter-diff-perl/debian/control
    trunk/libnet-twitter-diff-perl/debian/rules

Modified: trunk/libnet-twitter-diff-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libnet-twitter-diff-perl/debian/changelog?rev=36398&op=diff
==============================================================================

--- trunk/libnet-twitter-diff-perl/debian/changelog (original)
+++ trunk/libnet-twitter-diff-perl/debian/changelog Mon May 25 16:04:58 2009
@@ -6,6 +6,11 @@
     follow the "is a" rule, which means you should be able to read the sentence
     as "libnet-twitter-diff-perl is a <Synopsis>". So something like "Perl module
     to compare Twitter relationships".
+  - Make sure to mention the module name somewhere in your long description,
+    because it is searched by `apt-cache search'. Usually something like:
+    Net::Twitter::Diff is ... as your first line is sufficient.
+  (I have written a description for you. Please review it.)
+
   - In d/copyright, you need to put the copyright and license info. In the case of
     this module, there is none in the upstream, so you need to contact the author
     and ask for clarification on that, and a new release.
@@ -13,6 +18,21 @@
     upstream authors asking for this type of info, and explaining the reasoning
     why we need it in the first place.) In the meantime, speak to Ryan52 on IRC
     and ask him if he can contact the author about it.
+  - Remove libnet-twitter-diff-perl.docs if the files it points to aren't useful
+    compared to the perldoc page, or aren't really useful to users. In this case,
+    the README included just has simple things like 'perl Makefile.PL' which our
+    users don't need to do anyway.
+  - I've upgraded your d/rules file to a new "shorter" version. dh-make-perl will
+    create these for you in a later version. It's just a bit easier to maintain.
+  - There is an upstream bug requiring a patch; see the Request Tracker:
+    http://rt.cpan.org/Public/Bug/Display.html?id=43699
+    You will need to apply this bug fix. There are many tools to do this; namely
+    quilt. Since this can be difficult for new packagers to learn, I've done this
+    for you. Importantly you need to add debhelper (>= 7.08) and quilt (>= 0.46-7)
+    to Build-Depends, and modify your rules file.
+    See: http://pkg-perl.alioth.debian.org/howto/quilt.html for how to use quilt.
+  - Usually e-mail addresses are formatted as: name <e-mail> - note the space.
+    This is nitpicky but could confuse parsers.
 
   * Initial Release. (Closes: #530453)
 

Modified: trunk/libnet-twitter-diff-perl/debian/control
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libnet-twitter-diff-perl/debian/control?rev=36398&op=diff
==============================================================================
--- trunk/libnet-twitter-diff-perl/debian/control (original)
+++ trunk/libnet-twitter-diff-perl/debian/control Mon May 25 16:04:58 2009
@@ -1,7 +1,7 @@
 Source: libnet-twitter-diff-perl
 Section: perl
 Priority: optional
-Build-Depends: debhelper (>= 7)
+Build-Depends: debhelper (>= 7.08), quilt (>= 0.46-7)
 Build-Depends-Indep: perl (>= 5.6.0-12)
 Maintainer: Debian Perl Group <pkg-perl-maintainers at lists.alioth.debian.org>
 Uploaders: Edi Stojicevic <estojicevic at debianworld.org>
@@ -13,8 +13,8 @@
 Package: libnet-twitter-diff-perl
 Architecture: all
 Depends: ${misc:Depends}, ${perl:Depends}
-Description: Twitter Diff
- .
- Handy when you want to know relationshop between your followers and
- follwoings and when you wnat to compare your following and somebody's.
- .
+Description: Perl module to compare Twitter relationships
+ Net::Twitter::Diff is a module to compare Twitter relationships, so that you
+ can easily determine which users you are following but are not following you,
+ which users are following you that you are not following, and where you are
+ both following each other's feeds.

Added: trunk/libnet-twitter-diff-perl/debian/patches/array-diff.patch
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libnet-twitter-diff-perl/debian/patches/array-diff.patch?rev=36398&op=file
==============================================================================
--- trunk/libnet-twitter-diff-perl/debian/patches/array-diff.patch (added)
+++ trunk/libnet-twitter-diff-perl/debian/patches/array-diff.patch Mon May 25 16:04:58 2009
@@ -1,0 +1,17 @@
+Author: Jonathan Yu <frequency at cpan.org>
+Debian-Specific: no
+Description: Sort the array references before taking a diff of them,
+ to ensure that transposed order (due to out-of-order replies from
+ Twitter) don't matter.
+Fixes: https://rt.cpan.org/Public/Bug/Display.html?id=43699
+--- a/lib/Net/Twitter/Diff.pm
++++ b/lib/Net/Twitter/Diff.pm
+@@ -78,7 +78,7 @@
+         push @{ $followers } , $item->{screen_name};
+     }
+ 
+-    my $diff = Array::Diff->diff( $followers , $followings );
++    my $diff = Array::Diff->diff([ sort @{$followers} ], [ sort @{$followings} ]);
+ 
+     $res->{not_following} = $diff->deleted; 
+     $res->{not_followed}  = $diff->added; 

Added: trunk/libnet-twitter-diff-perl/debian/patches/series
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libnet-twitter-diff-perl/debian/patches/series?rev=36398&op=file
==============================================================================
--- trunk/libnet-twitter-diff-perl/debian/patches/series (added)
+++ trunk/libnet-twitter-diff-perl/debian/patches/series Mon May 25 16:04:58 2009
@@ -1,0 +1,1 @@
+array-diff.patch

Modified: trunk/libnet-twitter-diff-perl/debian/rules
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libnet-twitter-diff-perl/debian/rules?rev=36398&op=diff
==============================================================================
--- trunk/libnet-twitter-diff-perl/debian/rules (original)
+++ trunk/libnet-twitter-diff-perl/debian/rules Mon May 25 16:04:58 2009
@@ -1,23 +1,4 @@
 #!/usr/bin/make -f
 
-build: build-stamp
-build-stamp:
-	dh build
-	touch $@
-
-clean:
-	dh $@
-
-install: install-stamp
-install-stamp: build-stamp
-	dh install
-	touch $@
-
-binary-arch:
-
-binary-indep: install
-	dh $@
-
-binary: binary-arch binary-indep
-
-.PHONY: binary binary-arch binary-indep install clean build
+%:
+	dh --with quilt $@


