r45656 - in /trunk/libxml-rss-perl: ./ debian/ examples/ examples/0.9/ examples/0.91/ examples/1.0/ lib/XML/ t/

jawnsy-guest at users.alioth.debian.org jawnsy-guest at users.alioth.debian.org
Mon Oct 12 17:57:32 UTC 2009


Author: jawnsy-guest
Date: Mon Oct 12 17:57:25 2009
New Revision: 45656

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=45656
Log:
New upstream release

Modified:
    trunk/libxml-rss-perl/Build.PL
    trunk/libxml-rss-perl/Changes
    trunk/libxml-rss-perl/META.yml
    trunk/libxml-rss-perl/debian/changelog
    trunk/libxml-rss-perl/debian/control
    trunk/libxml-rss-perl/examples/0.9/create_rss.pl
    trunk/libxml-rss-perl/examples/0.91/create_rss_0.91.pl
    trunk/libxml-rss-perl/examples/0.91/create_rss_0.91_full.pl
    trunk/libxml-rss-perl/examples/1.0/create_rss_1.0.pl
    trunk/libxml-rss-perl/examples/1.0/update_rss_1.0.pl
    trunk/libxml-rss-perl/examples/convert.pl
    trunk/libxml-rss-perl/examples/create_rss_multiple.pl
    trunk/libxml-rss-perl/examples/rss2html.pl
    trunk/libxml-rss-perl/examples/rss_info.pl
    trunk/libxml-rss-perl/examples/update_rss.pl
    trunk/libxml-rss-perl/lib/XML/RSS.pm
    trunk/libxml-rss-perl/t/1.0-parse-exotic.t
    trunk/libxml-rss-perl/t/2.0-permalink.t
    trunk/libxml-rss-perl/t/charset1.t
    trunk/libxml-rss-perl/t/encode-output.t
    trunk/libxml-rss-perl/t/test-generated-items.t
    trunk/libxml-rss-perl/t/xml-header.t

Modified: trunk/libxml-rss-perl/Build.PL
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/Build.PL?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/Build.PL (original)
+++ trunk/libxml-rss-perl/Build.PL Mon Oct 12 17:57:25 2009
@@ -14,7 +14,7 @@
         'DateTime::Format::Mail' => 0,
         'DateTime::Format::W3CDTF' => 0,
         'HTML::Entities' => 0,
-        'perl' => '5.006',
+        'perl' => '5.008',
         'XML::Parser' => '2.23',
     },
     build_requires =>

Modified: trunk/libxml-rss-perl/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/Changes?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/Changes (original)
+++ trunk/libxml-rss-perl/Changes Mon Oct 12 17:57:25 2009
@@ -1,4 +1,15 @@
 Revision history for Perl module XML::RSS
+
+1.46 - October 8, 2009
+    - Updated the E-mail address of Adam Trickett.
+    - Removed the perl-5.6.x-specific workarounds and made perl-5.8.x as
+    a requirement. This was done in order to:
+        - avoid a workaround that also caused an incomplete test coverage.
+        - avoid various test failures due to a problem with XML-Parser
+        on 5.6.x .
+        - encourage people using ancient versions of perl in production.
+    - Convert all occurences of "new XML::RSS" to "XML::RSS->new()" everywhere.
+        - a best practice.
 
 1.45 - August 5, 2009
     - Removed some unused module requirements statements from lib/**.pm.

Modified: trunk/libxml-rss-perl/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/META.yml?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/META.yml (original)
+++ trunk/libxml-rss-perl/META.yml Mon Oct 12 17:57:25 2009
@@ -1,6 +1,6 @@
 ---
 name: XML-RSS
-version: 1.45
+version: 1.46
 author:
   - 'Shlomi Fish <shlomif at cpan.org>'
 abstract: creates and updates RSS files
@@ -18,13 +18,13 @@
   DateTime::Format::W3CDTF: 0
   HTML::Entities: 0
   XML::Parser: 2.23
-  perl: 5.006
+  perl: 5.008
 configure_requires:
-  Module::Build: 0.34
+  Module::Build: 0.35
 provides:
   XML::RSS:
     file: lib/XML/RSS.pm
-    version: 1.45
+    version: 1.46
   XML::RSS::Private::Output::Base:
     file: lib/XML/RSS/Private/Output/Base.pm
   XML::RSS::Private::Output::Roles::ImageDims:
@@ -39,7 +39,7 @@
     file: lib/XML/RSS/Private/Output/V1_0.pm
   XML::RSS::Private::Output::V2_0:
     file: lib/XML/RSS/Private/Output/V2_0.pm
-generated_by: Module::Build version 0.34
+generated_by: Module::Build version 0.35
 meta-spec:
   url: http://module-build.sourceforge.net/META-spec-v1.4.html
   version: 1.4

Modified: trunk/libxml-rss-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/debian/changelog?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/debian/changelog (original)
+++ trunk/libxml-rss-perl/debian/changelog Mon Oct 12 17:57:25 2009
@@ -1,4 +1,8 @@
-libxml-rss-perl (1.45-2) UNRELEASED; urgency=low
+libxml-rss-perl (1.46-1) UNRELEASED; urgency=low
+
+  [ Jonathan Yu ]
+  * New upstream release
+  * Standards-Version 3.8.3 (no changes)
 
   [ Salvatore Bonaccorso ]
   * debian/control: Changed: Replace versioned (build-)dependency on
@@ -9,7 +13,7 @@
   * Update jawnsy's email address
   * Update ryan52's email address
 
- -- Ryan Niebur <ryan at debian.org>  Fri, 25 Sep 2009 00:27:06 -0700
+ -- Jonathan Yu <jawnsy at cpan.org>  Mon, 12 Oct 2009 10:00:47 -0400
 
 libxml-rss-perl (1.45-1) unstable; urgency=low
 

Modified: trunk/libxml-rss-perl/debian/control
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/debian/control?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/debian/control (original)
+++ trunk/libxml-rss-perl/debian/control Mon Oct 12 17:57:25 2009
@@ -2,7 +2,7 @@
 Section: perl
 Priority: optional
 Build-Depends: debhelper (>= 7)
-Build-Depends-Indep: perl, libtest-manifest-perl (>= 0.9),
+Build-Depends-Indep: perl, libtest-manifest-perl,
  libxml-parser-perl (>= 2.23), libdatetime-format-mail-perl, libtest-pod-perl,
  libdatetime-format-w3cdtf-perl, libtest-pod-coverage-perl,
  libtest-differences-perl
@@ -11,7 +11,7 @@
  Brian Cassidy <brian.cassidy at gmail.com>, Jay Bonci <jaybonci at debian.org>,
  Vincent Danjean <vdanjean at debian.org>, Damyan Ivanov <dmn at debian.org>,
  Ryan Niebur <ryan at debian.org>, Jonathan Yu <jawnsy at cpan.org>
-Standards-Version: 3.8.2
+Standards-Version: 3.8.3
 Homepage: http://search.cpan.org/dist/XML-RSS/
 Vcs-Svn: svn://svn.debian.org/pkg-perl/trunk/libxml-rss-perl/
 Vcs-Browser: http://svn.debian.org/viewsvn/pkg-perl/trunk/libxml-rss-perl/

Modified: trunk/libxml-rss-perl/examples/0.9/create_rss.pl
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/examples/0.9/create_rss.pl?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/examples/0.9/create_rss.pl (original)
+++ trunk/libxml-rss-perl/examples/0.9/create_rss.pl Mon Oct 12 17:57:25 2009
@@ -7,7 +7,7 @@
 
 use XML::RSS;
 
-my $rss = new XML::RSS(version => '0.9');
+my $rss = XML::RSS->new(version => '0.9');
 $rss->channel(title => "freshmeat.net",
 	      link  => "http://freshmeat.net",
 	      description => "the one-stop-shop for all your Linux software needs"

Modified: trunk/libxml-rss-perl/examples/0.91/create_rss_0.91.pl
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/examples/0.91/create_rss_0.91.pl?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/examples/0.91/create_rss_0.91.pl (original)
+++ trunk/libxml-rss-perl/examples/0.91/create_rss_0.91.pl Mon Oct 12 17:57:25 2009
@@ -6,7 +6,7 @@
 
 use XML::RSS;
 
-my $rss = new XML::RSS (version => "0.91") ;
+my $rss = XML::RSS->new (version => "0.91") ;
 $rss->channel(title       => "freshmeat.net",
 	      link        => "http://freshmeat.net",
 	      language    => "en", 

Modified: trunk/libxml-rss-perl/examples/0.91/create_rss_0.91_full.pl
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/examples/0.91/create_rss_0.91_full.pl?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/examples/0.91/create_rss_0.91_full.pl (original)
+++ trunk/libxml-rss-perl/examples/0.91/create_rss_0.91_full.pl Mon Oct 12 17:57:25 2009
@@ -10,7 +10,7 @@
 
 use XML::RSS;
 
-my $rss = new XML::RSS (version => '0.91',
+my $rss = XML::RSS->new (version => '0.91',
 			encoding => 'ISO-8859-1');
 
 $rss->strict("1");

Modified: trunk/libxml-rss-perl/examples/1.0/create_rss_1.0.pl
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/examples/1.0/create_rss_1.0.pl?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/examples/1.0/create_rss_1.0.pl (original)
+++ trunk/libxml-rss-perl/examples/1.0/create_rss_1.0.pl Mon Oct 12 17:57:25 2009
@@ -9,7 +9,7 @@
 use warnings;
 
 use XML::RSS;
-my $rss = new XML::RSS (version => '1.0');
+my $rss = XML::RSS->new (version => '1.0');
 
  $rss->channel(
    title        => "freshmeat.net",

Modified: trunk/libxml-rss-perl/examples/1.0/update_rss_1.0.pl
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/examples/1.0/update_rss_1.0.pl?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/examples/1.0/update_rss_1.0.pl (original)
+++ trunk/libxml-rss-perl/examples/1.0/update_rss_1.0.pl Mon Oct 12 17:57:25 2009
@@ -5,7 +5,7 @@
 use XML::RSS;
 
 # create a new instance of the XML::RSS
-my $rss = new XML::RSS;
+my $rss = XML::RSS->new;
 
 # parse the local file
 $rss->parsefile("rss1.0.rdf");

Modified: trunk/libxml-rss-perl/examples/convert.pl
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/examples/convert.pl?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/examples/convert.pl (original)
+++ trunk/libxml-rss-perl/examples/convert.pl Mon Oct 12 17:57:25 2009
@@ -13,7 +13,7 @@
 my ($file,$version) = @ARGV;
 
 # create new instance
-my $rss = new XML::RSS;
+my $rss = XML::RSS->new;
 
 # set output version
 $rss->{output} = $version unless $version eq 'default';

Modified: trunk/libxml-rss-perl/examples/create_rss_multiple.pl
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/examples/create_rss_multiple.pl?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/examples/create_rss_multiple.pl (original)
+++ trunk/libxml-rss-perl/examples/create_rss_multiple.pl Mon Oct 12 17:57:25 2009
@@ -7,7 +7,7 @@
 
 use XML::RSS;
 
-my $rss = new XML::RSS(version => '0.9');
+my $rss = XML::RSS->new(version => '0.9');
 $rss->channel(title => "freshmeat.net",
 	      link  => "http://freshmeat.net",
 	      description => "the one-stop-shop for all your Linux software needs"
@@ -34,7 +34,7 @@
 
 print $rss->as_string;
 
-my $rss = new XML::RSS(version => '0.9');
+my $rss = XML::RSS->new(version => '0.9');
 $rss->channel(title => "freshmeat.net",
 	      link  => "http://freshmeat.net",
 	      description => "the one-stop-shop for all your Linux software needs"
@@ -61,7 +61,7 @@
 
 print $rss->as_string;
 
-my $rss2 = new XML::RSS(version => '0.9');
+my $rss2 = XML::RSS->new(version => '0.9');
 $rss2->channel(title => "perlxml.com",
 	      link  => "http://perlxml.com"
 	      );

Modified: trunk/libxml-rss-perl/examples/rss2html.pl
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/examples/rss2html.pl?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/examples/rss2html.pl (original)
+++ trunk/libxml-rss-perl/examples/rss2html.pl Mon Oct 12 17:57:25 2009
@@ -24,7 +24,7 @@
 my $arg = shift;
 
 # create new instance of XML::RSS
-my $rss = new XML::RSS;
+my $rss = XML::RSS->new;
 
 # argument is a URL
 if ($arg=~ /http:/i) {

Modified: trunk/libxml-rss-perl/examples/rss_info.pl
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/examples/rss_info.pl?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/examples/rss_info.pl (original)
+++ trunk/libxml-rss-perl/examples/rss_info.pl Mon Oct 12 17:57:25 2009
@@ -10,7 +10,7 @@
 
 use XML::RSS;
 
-my $rss = new XML::RSS;
+my $rss = XML::RSS->new;
 $rss->parsefile(shift);
 
 print "XML encoding: ".$rss->encoding."\n";

Modified: trunk/libxml-rss-perl/examples/update_rss.pl
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/examples/update_rss.pl?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/examples/update_rss.pl (original)
+++ trunk/libxml-rss-perl/examples/update_rss.pl Mon Oct 12 17:57:25 2009
@@ -9,7 +9,7 @@
 die "Syntax: update_rss.pl source.rdf destination.rdf\n\n"
 	unless @ARGV == 2;
 
-my $rss = new XML::RSS;
+my $rss = XML::RSS->new;
 $rss->parsefile(shift);
 
 $rss->add_item(title => "MpegTV Player (mtv) 1.0.9.7",

Modified: trunk/libxml-rss-perl/lib/XML/RSS.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/lib/XML/RSS.pm?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/lib/XML/RSS.pm (original)
+++ trunk/libxml-rss-perl/lib/XML/RSS.pm Mon Oct 12 17:57:25 2009
@@ -14,7 +14,9 @@
 
 use vars qw($VERSION $AUTOLOAD @ISA $AUTO_ADD);
 
-$VERSION = '1.45';
+require 5.008;
+
+$VERSION = '1.46';
 
 $AUTO_ADD = 0;
 
@@ -1337,20 +1339,10 @@
     return $self->_generic_parse("parsefile", $file_to_parse, $options);
 }
 
-# Check if Perl supports the :encoding layer in File I/O.
-sub _perl_supports_encoding {
-    my $self = shift;
-
-    return $] > 5.007;
-}
-
 sub _get_save_output_mode {
     my $self = shift;
 
-    return $self->_perl_supports_encoding()
-        ? (">:encoding(" . $self->_encoding() . ")")
-        : ">"
-        ;
+    return (">:encoding(" . $self->_encoding() . ")");
 }
 
 sub save {
@@ -1496,7 +1488,7 @@
 
  # create an RSS 1.0 file (http://purl.org/rss/1.0/)
  use XML::RSS;
- my $rss = new XML::RSS (version => '1.0');
+ my $rss = XML::RSS->new(version => '1.0');
  $rss->channel(
    title        => "freshmeat.net",
    link         => "http://freshmeat.net",
@@ -1568,7 +1560,7 @@
 
  # create an RSS 2.0 file
  use XML::RSS;
- my $rss = new XML::RSS (version => '2.0');
+ my $rss = XML::RSS->new (version => '2.0');
  $rss->channel(title          => 'freshmeat.net',
                link           => 'http://freshmeat.net',
                language       => 'en',
@@ -1607,7 +1599,7 @@
 
  # create an RSS 0.9 file
  use XML::RSS;
- my $rss = new XML::RSS (version => '0.9');
+ my $rss = XML::RSS->new( version => '0.9' );
  $rss->channel(title => "freshmeat.net",
                link  => "http://freshmeat.net",
                description => "the one-stop-shop for all your Linux software needs",
@@ -1636,7 +1628,7 @@
 
  # insert an item into an RSS file and removes the oldest ones if
  # there are already 15 items or more
- my $rss = new XML::RSS;
+ my $rss = XML::RSS->new;
  $rss->parsefile("fm.rdf");
 
  while (@{$rss->{'items'}} >= 15)
@@ -1692,8 +1684,7 @@
 
 =over 4
 
-=item new XML::RSS (version=>$version, encoding=>$encoding,
-output=>$output, stylesheet=>$stylesheet_url, 'xml:base'=>$base)
+=item XML::RSS->new(version=>$version, encoding=>$encoding, output=>$output, stylesheet=>$stylesheet_url, 'xml:base'=>$base)
 
 Constructor for XML::RSS. It returns a reference to an XML::RSS object.
 You may also pass the RSS version and the XML encoding to use. The default
@@ -2055,7 +2046,7 @@
  rjp at browser.org
  Kellan Elliott-McCrea <kellan at protest.net>
  Rafe Colburn <rafe at rafe.us>
- Adam Trickett <adam.trickett at btinternet.com>
+ Adam Trickett <atrickett at cpan.org>
  Aaron Straup Cope <asc at vineyard.net>
  Ian Davis <iand at internetalchemy.org>
  rayg at varchars.com

Modified: trunk/libxml-rss-perl/t/1.0-parse-exotic.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/t/1.0-parse-exotic.t?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/t/1.0-parse-exotic.t (original)
+++ trunk/libxml-rss-perl/t/1.0-parse-exotic.t Mon Oct 12 17:57:25 2009
@@ -5,7 +5,7 @@
 $|++;
 
 my $file = File::Spec->catfile(File::Spec->curdir(), "t", "data", "1.0", "rss1.0.exotic.rdf");
-my $rss = new XML::RSS(encode_output => 1);
+my $rss = XML::RSS->new(encode_output => 1);
 
 eval {
 	$rss->parsefile( $file );

Modified: trunk/libxml-rss-perl/t/2.0-permalink.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/t/2.0-permalink.t?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/t/2.0-permalink.t (original)
+++ trunk/libxml-rss-perl/t/2.0-permalink.t Mon Oct 12 17:57:25 2009
@@ -8,7 +8,7 @@
 use File::Spec;
 use XML::RSS;
 
-my $rss = new XML::RSS;
+my $rss = XML::RSS->new;
 $rss->parsefile(File::Spec->catfile('t', 'data', 'rss-permalink.xml') );
 my $item_with_guid_true = $rss->{'items'}->[0];
 my $item_with_guid_missing = $rss->{'items'}->[1];

Modified: trunk/libxml-rss-perl/t/charset1.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/t/charset1.t?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/t/charset1.t (original)
+++ trunk/libxml-rss-perl/t/charset1.t Mon Oct 12 17:57:25 2009
@@ -79,7 +79,7 @@
     # And read it back in again.
     #
 
-    $rss = new XML::RSS;
+    $rss = XML::RSS->new;
     $rss->parsefile($rss_file);
 
     # Check that no exception was thrown along the way.

Modified: trunk/libxml-rss-perl/t/encode-output.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/t/encode-output.t?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/t/encode-output.t (original)
+++ trunk/libxml-rss-perl/t/encode-output.t Mon Oct 12 17:57:25 2009
@@ -7,7 +7,7 @@
 $|++;
 
 my $file = File::Spec->catfile(File::Spec->curdir(), "t", "data", "1.0", "rss1.0.exotic.rdf");
-my $rss = new XML::RSS(encode_output => 1);
+my $rss = XML::RSS->new(encode_output => 1);
 
 eval {
 	$rss->parsefile( $file );
@@ -18,7 +18,7 @@
 # Encode illegal characters (e.g. &) when outputting RSS
 #
 my $rss_str = $rss->as_string();
-my $rss2 = new XML::RSS();
+my $rss2 = XML::RSS->new();
 eval {
 	$rss2->parse( $rss_str );
 };

Modified: trunk/libxml-rss-perl/t/test-generated-items.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/t/test-generated-items.t?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/t/test-generated-items.t (original)
+++ trunk/libxml-rss-perl/t/test-generated-items.t Mon Oct 12 17:57:25 2009
@@ -46,8 +46,7 @@
     my $args = shift;
 
     my $extra_rss_args = $args->{rss_args} || [];
-    # my $rss = new XML::RSS (version => '0.9');
-    my $rss = new XML::RSS (version => $args->{version}, @$extra_rss_args);
+    my $rss = XML::RSS->new (version => $args->{version}, @$extra_rss_args);
     my $image_link = exists($args->{image_link}) ? $args->{image_link} : 
         "http://freshmeat.net/";
 
@@ -78,8 +77,7 @@
 sub create_no_image_rss
 {
     my $args = shift;
-    # my $rss = new XML::RSS (version => '0.9');
-    my $rss = new XML::RSS (version => $args->{version});
+    my $rss = XML::RSS->new (version => $args->{version});
 
     $rss->channel(
         title => "freshmeat.net",
@@ -98,8 +96,7 @@
 sub create_item_with_0_rss
 {
     my $args = shift;
-    # my $rss = new XML::RSS (version => '0.9');
-    my $rss = new XML::RSS (version => $args->{version});
+    my $rss = XML::RSS->new (version => $args->{version});
     my $image_link = exists($args->{image_link}) ? $args->{image_link} : 
         "http://freshmeat.net/";
 
@@ -131,8 +128,7 @@
 sub create_textinput_with_0_rss
 {
     my $args = shift;
-    # my $rss = new XML::RSS (version => '0.9');
-    my $rss = new XML::RSS (version => $args->{version});
+    my $rss = XML::RSS->new (version => $args->{version});
     my $image_link = exists($args->{image_link}) ? $args->{image_link} : 
         "http://freshmeat.net/";
 
@@ -170,8 +166,7 @@
 sub create_channel_rss
 {
     my $args = shift;
-    # my $rss = new XML::RSS (version => '0.9');
-    my $rss = new XML::RSS (version => $args->{version});
+    my $rss = XML::RSS->new (version => $args->{version});
 
     my $extra_channel_params = $args->{channel_params} || [];
     my @build_date =
@@ -198,8 +193,7 @@
 sub create_skipHours_rss
 {
     my $args = shift;
-    # my $rss = new XML::RSS (version => '0.9');
-    my $rss = new XML::RSS (version => $args->{version});
+    my $rss = XML::RSS->new (version => $args->{version});
 
     my $extra_channel_params = $args->{channel_params} || [];
     my $extra_skipHours_params = $args->{skipHours_params} || [];
@@ -229,8 +223,7 @@
 sub create_skipDays_rss
 {
     my $args = shift;
-    # my $rss = new XML::RSS (version => '0.9');
-    my $rss = new XML::RSS (version => $args->{version});
+    my $rss = XML::RSS->new (version => $args->{version});
 
     my $extra_channel_params = $args->{channel_params} || [];
     my $extra_skipDays_params = $args->{skipDays_params} || [];
@@ -260,8 +253,7 @@
 sub create_rss_with_image_w_undef_link
 {
     my $args = shift;
-    # my $rss = new XML::RSS (version => '0.9');
-    my $rss = new XML::RSS (version => $args->{version});
+    my $rss = XML::RSS->new (version => $args->{version});
 
     my $extra_image_params = $args->{image_params} || [];
 
@@ -288,8 +280,7 @@
 sub create_item_rss
 {
     my $args = shift;
-    # my $rss = new XML::RSS (version => '0.9');
-    my $rss = new XML::RSS (version => $args->{version});
+    my $rss = XML::RSS->new (version => $args->{version});
 
     my $extra_item_params = $args->{item_params} || [];
 
@@ -311,8 +302,7 @@
 sub create_rss_without_item
 {
     my $args = shift;
-    # my $rss = new XML::RSS (version => '0.9');
-    my $rss = new XML::RSS (version => $args->{version});
+    my $rss = XML::RSS->new (version => $args->{version});
 
     $rss->channel(
         title => "freshmeat.net",

Modified: trunk/libxml-rss-perl/t/xml-header.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libxml-rss-perl/t/xml-header.t?rev=45656&op=diff
==============================================================================
--- trunk/libxml-rss-perl/t/xml-header.t (original)
+++ trunk/libxml-rss-perl/t/xml-header.t Mon Oct 12 17:57:25 2009
@@ -23,7 +23,6 @@
 sub create_rss_1
 {
     my $args = shift;
-    # my $rss = new XML::RSS (version => '0.9');
     my @style =
         exists($args->{stylesheet}) ? 
             (stylesheet => $args->{stylesheet}) :




More information about the Pkg-perl-cvs-commits mailing list