r45031 - in /trunk/dh-make-perl: debian/changelog lib/DhMakePerl.pm

gregoa at users.alioth.debian.org gregoa at users.alioth.debian.org
Tue Sep 29 20:16:38 UTC 2009


Author: gregoa
Date: Tue Sep 29 20:16:33 2009
New Revision: 45031

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=45031
Log:
Rewrite comment about YAML::LoadFile in lib/DhMakePerl.pm; thanks to
Slaven Rezic for the bug report (closes: #548935).

Modified:
    trunk/dh-make-perl/debian/changelog
    trunk/dh-make-perl/lib/DhMakePerl.pm

Modified: trunk/dh-make-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/dh-make-perl/debian/changelog?rev=45031&op=diff
==============================================================================
--- trunk/dh-make-perl/debian/changelog (original)
+++ trunk/dh-make-perl/debian/changelog Tue Sep 29 20:16:33 2009
@@ -20,6 +20,8 @@
   * Check if the possible examples directory is actually a directory before
     adding "$directory/*" to <pkg>.examples; thanks to Slaven Rezic for the
     bug report (closes: #548950).
+  * Rewrite comment about YAML::LoadFile in lib/DhMakePerl.pm; thanks to
+    Slaven Rezic for the bug report (closes: #548935).
 
   [ Damyan Ivanov ]
   * Drop support for debhelper compatibility levels other than 7

Modified: trunk/dh-make-perl/lib/DhMakePerl.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/dh-make-perl/lib/DhMakePerl.pm?rev=45031&op=diff
==============================================================================
--- trunk/dh-make-perl/lib/DhMakePerl.pm (original)
+++ trunk/dh-make-perl/lib/DhMakePerl.pm Tue Sep 29 20:16:33 2009
@@ -608,10 +608,8 @@
 
     my $yaml;
 
-    # YAML::LoadFile has the bad habit of dying when it cannot properly parse
-    # a file - Catch it in an eval, and if it dies, return -again- just an
-    # empty hashref. Oh, were it not enough: It dies, but $! is not set, so we
-    # check against $@. Crap, crap, crap :-/
+    # YAML::LoadFile dies when it cannot properly parse a file - catch it in
+    # an eval, and if it dies, return -again- just an empty hashref.
     eval { $yaml = YAML::LoadFile($file); };
     if ($@) {
         print "Error parsing $file - Ignoring it.\n";




More information about the Pkg-perl-cvs-commits mailing list