r52690 - in /trunk/libpoe-component-client-mpd-perl: ./ debian/ examples/ lib/POE/Component/Client/ lib/POE/Component/Client/MPD/ t/

jawnsy-guest at users.alioth.debian.org jawnsy-guest at users.alioth.debian.org
Sat Feb 13 23:45:02 UTC 2010 

Author: jawnsy-guest
Date: Sat Feb 13 23:44:47 2010
New Revision: 52690

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=52690
Log:
integrate another upstream version

Removed:
    trunk/libpoe-component-client-mpd-perl/Makefile.PL
Modified:
    trunk/libpoe-component-client-mpd-perl/Build.PL
    trunk/libpoe-component-client-mpd-perl/Changes
    trunk/libpoe-component-client-mpd-perl/MANIFEST
    trunk/libpoe-component-client-mpd-perl/META.yml
    trunk/libpoe-component-client-mpd-perl/README
    trunk/libpoe-component-client-mpd-perl/debian/changelog
    trunk/libpoe-component-client-mpd-perl/debian/control
    trunk/libpoe-component-client-mpd-perl/dist.ini
    trunk/libpoe-component-client-mpd-perl/examples/client.pl
    trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD.pm
    trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Collection.pm
    trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Commands.pm
    trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Connection.pm
    trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Message.pm
    trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Playlist.pm
    trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Test.pm
    trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Types.pm
    trunk/libpoe-component-client-mpd-perl/t/00-compile.t
    trunk/libpoe-component-client-mpd-perl/t/20-conn-failed.t
    trunk/libpoe-component-client-mpd-perl/t/21-conn-non_mpd.t
    trunk/libpoe-component-client-mpd-perl/t/23-conn-dialog.t
    trunk/libpoe-component-client-mpd-perl/t/40-cmds-general.t
    trunk/libpoe-component-client-mpd-perl/t/40-cmds-kill.t
    trunk/libpoe-component-client-mpd-perl/t/41-cmds-output.t
    trunk/libpoe-component-client-mpd-perl/t/42-cmds-info.t
    trunk/libpoe-component-client-mpd-perl/t/43-cmds-settings.t
    trunk/libpoe-component-client-mpd-perl/t/44-cmds-playback.t
    trunk/libpoe-component-client-mpd-perl/t/50-pl-info.t
    trunk/libpoe-component-client-mpd-perl/t/51-pl-add_rm.t
    trunk/libpoe-component-client-mpd-perl/t/52-pl-change.t
    trunk/libpoe-component-client-mpd-perl/t/53-pl-manage.t
    trunk/libpoe-component-client-mpd-perl/t/60-coll-retrieve.t
    trunk/libpoe-component-client-mpd-perl/t/61-coll-whole.t
    trunk/libpoe-component-client-mpd-perl/t/62-coll-pick.t
    trunk/libpoe-component-client-mpd-perl/t/63-coll-relations.t
    trunk/libpoe-component-client-mpd-perl/t/author-critic.t

Modified: trunk/libpoe-component-client-mpd-perl/Build.PL
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/Build.PL?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/Build.PL (original)
+++ trunk/libpoe-component-client-mpd-perl/Build.PL Sat Feb 13 23:44:47 2010
@@ -2,40 +2,43 @@
 use strict;
 use warnings;
 
-use Module::Build;
+use Module::Build 0.3601;
 
-my $build = Module::Build->new(
-  module_name   => 'POE::Component::Client::MPD',
-  license       => 'perl',
-  dist_abstract => "full\-blown\ poe\-aware\ mpd\ client\ library",
-  dist_name     => "POE\-Component\-Client\-MPD",
-  dist_author   => [
-"Jerome\ Quelin",
-  ],
-  requires      => {
-    "MooseX::Types::Moose" => '0',
-    "MooseX::Has::Sugar" => '0',
-    "FindBin" => '0',
-    "Sub::Exporter" => '0',
-    "Moose::Util::TypeConstraints" => '0',
-    "POE::Component::Client::TCP" => '0',
-    "Audio::MPD::Common::Item" => '0',
-    "File::Find" => '0',
-    "Audio::MPD::Common::Status" => '0',
-    "Audio::MPD::Common::Stats" => '0',
-    "MooseX::SemiAffordanceAccessor" => '0',
-    "Moose" => '0.92',
-    "MooseX::POE" => '0',
-    "English" => '0',
-    "ExtUtils::MakeMaker" => '0',
-    "Readonly" => '0',
-    "Carp" => '0',
-    "Test::More" => '0',
-    "perl" => '5.010',
-    "Test::Corpus::Audio::MPD" => '1.092920',
-    "POE" => '0',
-  },
-  script_files => [ qw() ],
-);
+my %module_build_args = (
+                       'dist_abstract' => 'full-blown poe-aware mpd client library',
+                       'dist_author' => [
+                                          'Jerome Quelin'
+                                        ],
+                       'dist_name' => 'POE-Component-Client-MPD',
+                       'script_files' => [],
+                       'module_name' => 'POE::Component::Client::MPD',
+                       'requires' => {
+                                       'MooseX::Has::Sugar' => 0,
+                                       'MooseX::Types::Moose' => 0,
+                                       'FindBin' => 0,
+                                       'Sub::Exporter' => 0,
+                                       'Moose::Util::TypeConstraints' => 0,
+                                       'POE::Component::Client::TCP' => 0,
+                                       'Audio::MPD::Common::Item' => 0,
+                                       'Audio::MPD::Common::Stats' => 0,
+                                       'Audio::MPD::Common::Status' => 0,
+                                       'File::Find' => 0,
+                                       'Moose' => '0.92',
+                                       'MooseX::SemiAffordanceAccessor' => 0,
+                                       'MooseX::POE' => 0,
+                                       'English' => 0,
+                                       'Readonly' => 0,
+                                       'Carp' => 0,
+                                       'perl' => '5.010',
+                                       'Test::More' => 0,
+                                       'Test::Corpus::Audio::MPD' => '1.092920',
+                                       'File::Temp' => 0,
+                                       'POE' => 0
+                                     },
+                       'license' => 'perl'
+                     );
+
+
+my $build = Module::Build->new(%module_build_args);
 
 $build->create_build_script;

Modified: trunk/libpoe-component-client-mpd-perl/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/Changes?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/Changes (original)
+++ trunk/libpoe-component-client-mpd-perl/Changes Sat Feb 13 23:44:47 2010
@@ -1,4 +1,11 @@
 Revision history for POE-Component-Client-MPD
+
+1.100430  2010-02-12 11:04:43 Europe/Paris
+ - WARNING: no more makefile.pl supplied, only a build.pl
+ - support for mpd password (alex bramley)
+ - make pococm:conn:send() retry if not connected (alex bramley)
+ - auto-generated event mpd_connect_error_fatal renamed to mpd_connect_error
+ - doc update
 
 1.093390  2009-12-05 20:21:01 Europe/Paris
  - fix #52457 - missing test dependency (test::corpus::audio::mpd)

Modified: trunk/libpoe-component-client-mpd-perl/MANIFEST
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/MANIFEST?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/MANIFEST (original)
+++ trunk/libpoe-component-client-mpd-perl/MANIFEST Sat Feb 13 23:44:47 2010
@@ -3,7 +3,6 @@
 LICENSE
 MANIFEST
 META.yml
-Makefile.PL
 README
 TODO
 dist.ini

Modified: trunk/libpoe-component-client-mpd-perl/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/META.yml?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/META.yml (original)
+++ trunk/libpoe-component-client-mpd-perl/META.yml Sat Feb 13 23:44:47 2010
@@ -3,10 +3,10 @@
 author:
   - 'Jerome Quelin'
 build_requires:
-  Module::Build: 0.35
+  Module::Build: 0.3601
 configure_requires:
-  Module::Build: 0.35
-generated_by: 'Dist::Zilla version 1.093371'
+  Module::Build: 0.3601
+generated_by: 'Dist::Zilla version 1.100160'
 license: perl
 meta-spec:
   url: http://module-build.sourceforge.net/META-spec-v1.4.html
@@ -15,41 +15,41 @@
 provides:
   POE::Component::Client::MPD:
     file: lib/POE/Component/Client/MPD.pm
-    version: 1.093390
+    version: 1.100430
   POE::Component::Client::MPD::Collection:
     file: lib/POE/Component/Client/MPD/Collection.pm
-    version: 1.093390
+    version: 1.100430
   POE::Component::Client::MPD::Commands:
     file: lib/POE/Component/Client/MPD/Commands.pm
-    version: 1.093390
+    version: 1.100430
   POE::Component::Client::MPD::Connection:
     file: lib/POE/Component/Client/MPD/Connection.pm
-    version: 1.093390
+    version: 1.100430
   POE::Component::Client::MPD::Message:
     file: lib/POE/Component/Client/MPD/Message.pm
-    version: 1.093390
+    version: 1.100430
   POE::Component::Client::MPD::Playlist:
     file: lib/POE/Component/Client/MPD/Playlist.pm
-    version: 1.093390
+    version: 1.100430
   POE::Component::Client::MPD::Test:
     file: lib/POE/Component/Client/MPD/Test.pm
-    version: 1.093390
+    version: 1.100430
   POE::Component::Client::MPD::Types:
     file: lib/POE/Component/Client/MPD/Types.pm
-    version: 1.093390
+    version: 1.100430
 requires:
   Audio::MPD::Common::Item: 0
   Audio::MPD::Common::Stats: 0
   Audio::MPD::Common::Status: 0
   Carp: 0
   English: 0
-  ExtUtils::MakeMaker: 0
+  ExtUtils::MakeMaker: 6.11
   File::Find: 0
+  File::Temp: 0
   FindBin: 0
-  Module::Build: 0
+  Module::Build: 0.3601
   Moose: 0.92
   Moose::Util::TypeConstraints: 0
-  MooseX::Aliases: 0
   MooseX::Has::Sugar: 0
   MooseX::POE: 0
   MooseX::SemiAffordanceAccessor: 0
@@ -65,4 +65,4 @@
   MailingList: http://groups.google.com/group/audio-mpd
   homepage: http://search.cpan.org/dist/POE-Component-Client-MPD
   repository: http://github.com/jquelin/poe-component-client-mpd
-version: 1.093390
+version: 1.100430

Modified: trunk/libpoe-component-client-mpd-perl/README
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/README?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/README (original)
+++ trunk/libpoe-component-client-mpd-perl/README Sat Feb 13 23:44:47 2010
@@ -1,7 +1,7 @@
 
 
 This archive contains the distribution POE-Component-Client-MPD, version
-1.093390:
+1.100430:
 
   full-blown poe-aware mpd client library
 

Modified: trunk/libpoe-component-client-mpd-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/debian/changelog?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/debian/changelog (original)
+++ trunk/libpoe-component-client-mpd-perl/debian/changelog Sat Feb 13 23:44:47 2010
@@ -1,4 +1,4 @@
-libpoe-component-client-mpd-perl (1.093390-1) UNRELEASED; urgency=low
+libpoe-component-client-mpd-perl (1.100430-1) UNRELEASED; urgency=low
 
   WAITS-FOR libmoosex-poe-perl
   This module is FTBFS without it
@@ -8,8 +8,9 @@
   * Update dependencies per upstream
   * Rewrite control description
   * Use an override to enable RELEASE_TESTING
+  * Standards-Version 3.8.4 (no changes)
 
- -- Jonathan Yu <jawnsy at cpan.org>  Sat, 05 Dec 2009 17:07:48 -0500
+ -- Jonathan Yu <jawnsy at cpan.org>  Sat, 13 Feb 2010 19:02:34 -0500
 
 libpoe-component-client-mpd-perl (0.9.6-1) unstable; urgency=low
 

Modified: trunk/libpoe-component-client-mpd-perl/debian/control
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/debian/control?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/debian/control (original)
+++ trunk/libpoe-component-client-mpd-perl/debian/control Sat Feb 13 23:44:47 2010
@@ -10,7 +10,7 @@
 Maintainer: Debian Perl Group <pkg-perl-maintainers at lists.alioth.debian.org>
 Uploaders: Ryan Niebur <ryan at debian.org>, Jonathan Yu <jawnsy at cpan.org>,
  gregor herrmann <gregoa at debian.org>, Iulian Udrea <iulian at ubuntu.com>
-Standards-Version: 3.8.3
+Standards-Version: 3.8.4
 Homepage: http://search.cpan.org/dist/POE-Component-Client-MPD/
 Vcs-Svn: svn://svn.debian.org/pkg-perl/trunk/libpoe-component-client-mpd-perl/
 Vcs-Browser: http://svn.debian.org/viewsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/

Modified: trunk/libpoe-component-client-mpd-perl/dist.ini
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/dist.ini?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/dist.ini (original)
+++ trunk/libpoe-component-client-mpd-perl/dist.ini Sat Feb 13 23:44:47 2010
@@ -5,49 +5,12 @@
 copyright_year   = 2007
 
 ; -- static meta-information
-[AutoVersion]
 [MetaResources]
 homepage    = http://search.cpan.org/dist/POE-Component-Client-MPD
 repository  = http://github.com/jquelin/poe-component-client-mpd
 MailingList = http://groups.google.com/group/audio-mpd
 
-; -- fetch & generate files
-[AllFiles]
-[CompileTests]
-[CriticTests]
-[MetaTests]
-[PodTests]
-
-; -- remove files
-[PruneCruft]
-[ManifestSkip]
-
-; -- get prereqs
-[AutoPrereq]
 [Prereq]
 Test::Corpus::Audio::MPD = 1.092920   ; used for tests, conditional compilation
 
-; -- munge files
-[ExtraTests]
-[NextRelease]
-[PkgVersion]
-[PodWeaver]
-[Prepender]
-copyright = 1
-
-; -- dynamic meta-information
-[InstallDirs]
-[MetaProvides::Package]
-
-; -- generate meta files
-[License]
-[MakeMaker]
-[ModuleBuild]
-[MetaYAML]
-[Readme]
-[Manifest] ; should come last
-
-; -- release
-[CheckChangeLog]
-[@Git]
-[UploadToCPAN]
+[@JQUELIN]

Modified: trunk/libpoe-component-client-mpd-perl/examples/client.pl
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/examples/client.pl?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/examples/client.pl (original)
+++ trunk/libpoe-component-client-mpd-perl/examples/client.pl Sat Feb 13 23:44:47 2010
@@ -39,4 +39,5 @@
 
 sub result {
     print "yeah!\n";
-}
+}
+

Modified: trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD.pm?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD.pm (original)
+++ trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD.pm Sat Feb 13 23:44:47 2010
@@ -11,7 +11,7 @@
 use warnings;
 
 package POE::Component::Client::MPD;
-our $VERSION = '1.093390';
+our $VERSION = '1.100430';
 # ABSTRACT: full-blown poe-aware mpd client library
 
 use Audio::MPD::Common::Stats;
@@ -140,7 +140,7 @@
 
     # check if event is handled.
     my @events_commands = qw{
-        version kill updatedb urlhandlers
+        password version kill updatedb urlhandlers
         volume output_enable output_disable
         stats status current song songid
         repeat fade random
@@ -193,18 +193,18 @@
 #
 # event: mpd_connect_error_retriable( $reason )
 # event: mpd_connect_error_fatal( $reason )
-event mpd_connect_error_retriable => \&_onprot_mpd_connect_error;
-event mpd_connect_error_fatal     => \&_onprot_mpd_connect_error;
+event mpd_connect_error_retriable => \&_mpd_connect_error;
+event mpd_connect_error_fatal     => \&_mpd_connect_error;
 
 # Called when pococm-conn could not connect to a mpd server. It can be
 # either retriable, or fatal. In bth case, we just need to forward the
 # error to our peer session.
 #
-sub _onprot_mpd_connect_error {
+sub _mpd_connect_error {
     my ($self, $reason) = @_[OBJECT, ARG0];
 
     return unless $self->has_peer;
-    $K->post($self->status_msgs_to, 'mpd_connect_error_fatal', $reason);
+    $K->post($self->status_msgs_to, 'mpd_connect_error', $reason);
 }
 
 
@@ -219,7 +219,7 @@
 
     return unless $self->has_peer;
     $K->post($self->status_msgs_to, 'mpd_connected');
-    # FIXME: send password information to mpd
+    $K->yield(password => $self->password) if $self->password;
     # FIXME: send status information to peer
 };
 
@@ -329,7 +329,7 @@
 
 =head1 VERSION
 
-version 1.093390
+version 1.100430
 
 =head1 SYNOPSIS
 
@@ -491,7 +491,7 @@
 
 =over 4
 
-=item * mpd_connect_error_fatal( $reason )
+=item * mpd_connect_error( $reason )
 
 Called when pococm-conn could not connect to a mpd server. It can be
 either retriable, or fatal. Check C<$reason> for more information.
@@ -557,4 +557,5 @@
 =cut
 
 
-__END__
+__END__
+

Modified: trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Collection.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Collection.pm?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Collection.pm (original)
+++ trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Collection.pm Sat Feb 13 23:44:47 2010
@@ -11,7 +11,7 @@
 use warnings;
 
 package POE::Component::Client::MPD::Collection;
-our $VERSION = '1.093390';
+our $VERSION = '1.100430';
 # ABSTRACT: module handling collection commands
 
 use Moose;
@@ -221,7 +221,7 @@
 
 =head1 VERSION
 
-version 1.093390
+version 1.100430
 
 =head1 DESCRIPTION
 
@@ -348,4 +348,5 @@
 =cut
 
 
-__END__
+__END__
+

Modified: trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Commands.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Commands.pm?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Commands.pm (original)
+++ trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Commands.pm Sat Feb 13 23:44:47 2010
@@ -11,7 +11,7 @@
 use warnings;
 
 package POE::Component::Client::MPD::Commands;
-our $VERSION = '1.093390';
+our $VERSION = '1.100430';
 # ABSTRACT: module handling basic mpd commands
 
 use Moose;
@@ -36,6 +36,16 @@
     my ($self, $msg) = @_;
     $msg->set_status(1);
     $K->post( $msg->_from, 'mpd_result', $msg, $self->mpd->version );
+}
+
+
+
+sub _do_password {
+    my ($self, $msg) = @_;
+    my $pw = $msg->params->[0];
+    $msg->_set_commands( [ qq{password $pw} ] );
+    $msg->_set_cooking ( 'raw' );
+    $self->mpd->_send_to_mpd( $msg );
 }
 
 
@@ -368,7 +378,7 @@
 
 =head1 VERSION
 
-version 1.093390
+version 1.100430
 
 =head1 DESCRIPTION
 
@@ -394,6 +404,11 @@
 differ from the real mpd version. eg, mpd version 0.13.2 is "speaking"
 and thus advertising version 0.13.0.
 
+=head2 password( $password )
+
+Sends a connection password to mpd. Used internally on connect, but can
+be called whenever if you're feeling like it.
+
 =head2 kill( )
 
 Kill the mpd server, and request the pococm to be shutdown.
@@ -527,4 +542,5 @@
 =cut
 
 
-__END__
+__END__
+

Modified: trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Connection.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Connection.pm?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Connection.pm (original)
+++ trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Connection.pm Sat Feb 13 23:44:47 2010
@@ -11,7 +11,7 @@
 use warnings;
 
 package POE::Component::Client::MPD::Connection;
-our $VERSION = '1.093390';
+our $VERSION = '1.100430';
 # ABSTRACT: module handling the tcp connection with mpd
 
 use Audio::MPD::Common::Item;
@@ -69,14 +69,16 @@
 
 
 sub send {
-    my ($h, $msg) = @_[HEAP, ARG0];
-    # $_[HEAP]->{server} is a reserved slot of pococ-tcp.
-    # note: calls to $h->{server}->put can fail with "no such method
-    #       put". this happens when trying to send data over wires
-    #       before having received the Connected event
-    # FIXME: really implement some offline mode
-    $h->{server}->put( @{ $msg->_commands } );
-    push @{ $h->{fifo} }, $msg;
+    my ($k, $h, $msg) = @_[KERNEL, HEAP, ARG0];
+    # Test to see if we're currently connected to MPD...
+    if ($h->{connected}) {
+        # ... if we are, it's all good, so send messages ...
+        $h->{server}->put( @{ $msg->_commands } );
+        push @{ $h->{fifo} }, $msg;
+    } elsif ($h->{auto_reconnect} == 1) {
+        # ... and if not, retry the send in 2 seconds.
+        $k->delay_set(send => 2, $msg);
+    }
 }
 
 
@@ -312,7 +314,7 @@
 
 =head1 VERSION
 
-version 1.093390
+version 1.100430
 
 =head1 DESCRIPTION
 
@@ -427,4 +429,6 @@
 =cut
 
 
-__END__
+__END__
+
+

Modified: trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Message.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Message.pm?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Message.pm (original)
+++ trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Message.pm Sat Feb 13 23:44:47 2010
@@ -11,7 +11,7 @@
 use warnings;
 
 package POE::Component::Client::MPD::Message;
-our $VERSION = '1.093390';
+our $VERSION = '1.100430';
 # ABSTRACT: a message from POCOCM
 
 use Moose;
@@ -45,7 +45,7 @@
 
 =head1 VERSION
 
-version 1.093390
+version 1.100430
 
 =head1 SYNOPSIS
 
@@ -93,4 +93,5 @@
 =cut
 
 
-__END__
+__END__
+

Modified: trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Playlist.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Playlist.pm?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Playlist.pm (original)
+++ trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Playlist.pm Sat Feb 13 23:44:47 2010
@@ -11,7 +11,7 @@
 use warnings;
 
 package POE::Component::Client::MPD::Playlist;
-our $VERSION = '1.093390';
+our $VERSION = '1.100430';
 # ABSTRACT: module handling playlist commands
 
 use Moose;
@@ -246,7 +246,7 @@
 
 =head1 VERSION
 
-version 1.093390
+version 1.100430
 
 =head1 DESCRIPTION
 
@@ -292,11 +292,11 @@
 Remove the specified C<$songid> (as assigned by mpd when inserted in
 playlist) from the current playlist.
 
-=head2 clear( )
+=head2 pl.clear( )
 
 Remove all the songs from the current playlist.
 
-=head2 crop( )
+=head2 pl.crop( )
 
 Remove all of the songs from the current playlist *except* the current one.
 
@@ -353,4 +353,5 @@
 =cut
 
 
-__END__
+__END__
+

Modified: trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Test.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Test.pm?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Test.pm (original)
+++ trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Test.pm Sat Feb 13 23:44:47 2010
@@ -11,7 +11,7 @@
 use warnings;
 
 package POE::Component::Client::MPD::Test;
-our $VERSION = '1.093390';
+our $VERSION = '1.100430';
 # ABSTRACT: automate pococ-mpd testing
 
 use Moose 0.92;
@@ -95,7 +95,7 @@
 
 =head1 VERSION
 
-version 1.093390
+version 1.100430
 
 =head1 SYNOPSIS
 
@@ -176,4 +176,5 @@
 =cut
 
 
-__END__
+__END__
+

Modified: trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Types.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Types.pm?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Types.pm (original)
+++ trunk/libpoe-component-client-mpd-perl/lib/POE/Component/Client/MPD/Types.pm Sat Feb 13 23:44:47 2010
@@ -11,7 +11,7 @@
 use strict;
 
 package POE::Component::Client::MPD::Types;
-our $VERSION = '1.093390';
+our $VERSION = '1.100430';
 # ABSTRACT: types used in the distribution
 
 use Moose::Util::TypeConstraints;
@@ -33,7 +33,7 @@
 
 =head1 VERSION
 
-version 1.093390
+version 1.100430
 
 =head1 DESCRIPTION
 
@@ -90,4 +90,5 @@
 =cut
 
 
-__END__
+__END__
+

Modified: trunk/libpoe-component-client-mpd-perl/t/00-compile.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/00-compile.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/00-compile.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/00-compile.t Sat Feb 13 23:44:47 2010
@@ -13,6 +13,7 @@
 
 use Test::More;
 use File::Find;
+use File::Temp qw{ tempdir };
 
 my @modules;
 find(
@@ -31,16 +32,21 @@
 my @scripts = glob "bin/*";
 
 plan tests => scalar(@modules) + scalar(@scripts);
-    
-is( qx{ $^X -Ilib -M$_ -e "print '$_ ok'" }, "$_ ok", "$_ loaded ok" )
-    for sort @modules;
-    
-SKIP: {
-    eval "use Test::Script; 1;";
-    skip "Test::Script needed to test script compilation", scalar(@scripts) if $@;
-    foreach my $file ( @scripts ) {
-        my $script = $file;
-        $script =~ s!.*/!!;
-        script_compiles_ok( $file, "$script script compiles" );
+
+{
+    # fake home for cpan-testers
+    # no fake requested ## local $ENV{HOME} = tempdir( CLEANUP => 1 );
+
+    is( qx{ $^X -Ilib -M$_ -e "print '$_ ok'" }, "$_ ok", "$_ loaded ok" )
+        for sort @modules;
+
+    SKIP: {
+        eval "use Test::Script; 1;";
+        skip "Test::Script needed to test script compilation", scalar(@scripts) if $@;
+        foreach my $file ( @scripts ) {
+            my $script = $file;
+            $script =~ s!.*/!!;
+            script_compiles_ok( $file, "$script script compiles" );
+        }
     }
-}
+}

Modified: trunk/libpoe-component-client-mpd-perl/t/20-conn-failed.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/20-conn-failed.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/20-conn-failed.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/20-conn-failed.t Sat Feb 13 23:44:47 2010
@@ -67,4 +67,4 @@
     max_retries => $max_retries,
 } );
 POE::Kernel->run;
-exit;
+exit;

Modified: trunk/libpoe-component-client-mpd-perl/t/21-conn-non_mpd.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/21-conn-non_mpd.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/21-conn-non_mpd.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/21-conn-non_mpd.t Sat Feb 13 23:44:47 2010
@@ -52,4 +52,4 @@
     id   => 'tester',
 } );
 POE::Kernel->run;
-exit;
+exit;

Modified: trunk/libpoe-component-client-mpd-perl/t/23-conn-dialog.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/23-conn-dialog.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/23-conn-dialog.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/23-conn-dialog.t Sat Feb 13 23:44:47 2010
@@ -98,11 +98,13 @@
 # are we able to test module?
 eval 'use Test::Corpus::Audio::MPD';
 plan skip_all => $@ if $@ =~ s/\n+BEGIN failed--compilation aborted.*//s;
-plan tests => 29;
+plan tests => 33;
 
 # tests to be run
 My::Session->new( { tests => [
     [ 'bad command', 'raw',         'mpd_error', \&_check_bad_command      ],
+    [ 'password fail', 'raw',       'mpd_error', \&_check_bad_password     ],
+    [ 'password foobar', 'raw',     'mpd_data',  \&_check_good_password    ],
     [ 'status',      'raw',         'mpd_data',  \&_check_data_raw         ],
     [ 'lsinfo',      'as_items',    'mpd_data',  \&_check_data_as_items    ],
     [ 'stats',       'strip_first', 'mpd_data',  \&_check_data_strip_first ],
@@ -120,6 +122,12 @@
 # private subs
 sub _check_bad_command {
     like($_[1], qr/unknown command "bad"/, 'unknown command');
+}
+sub _check_bad_password {
+    like($_[1], qr/incorrect password/, 'bad password');
+}
+sub _check_good_password {
+    is($_[1], undef, 'no error message');
 }
 sub _check_data_as_items {
     is($_[1], undef, 'no error message');
@@ -140,4 +148,4 @@
     is($_[1], undef, 'no error message');
     unlike( $_, qr/\D/, '$STRIP_FIRST return only 2nd field' ) for @{ $_[0]->_data };
     # stats return numerical data as second field.
-}
+}

Modified: trunk/libpoe-component-client-mpd-perl/t/40-cmds-general.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/40-cmds-general.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/40-cmds-general.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/40-cmds-general.t Sat Feb 13 23:44:47 2010
@@ -73,4 +73,5 @@
         check_success($msg);
         is($vers, $1, 'mpd version grabbed during connection is correct');
     }
-}
+}
+

Modified: trunk/libpoe-component-client-mpd-perl/t/40-cmds-kill.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/40-cmds-kill.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/40-cmds-kill.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/40-cmds-kill.t Sat Feb 13 23:44:47 2010
@@ -47,4 +47,4 @@
 POE::Component::Client::MPD->spawn;
 My::Session->new;
 POE::Kernel->run;
-exit;
+exit;

Modified: trunk/libpoe-component-client-mpd-perl/t/41-cmds-output.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/41-cmds-output.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/41-cmds-output.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/41-cmds-output.t Sat Feb 13 23:44:47 2010
@@ -94,4 +94,4 @@
     my ($msg, $status) = @_;
     check_success($msg);
     is($status->error, undef, 'enabling output' );
-}
+}

Modified: trunk/libpoe-component-client-mpd-perl/t/42-cmds-info.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/42-cmds-info.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/42-cmds-info.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/42-cmds-info.t Sat Feb 13 23:44:47 2010
@@ -99,4 +99,4 @@
     check_success($msg);
     isa_ok($song,   'Audio::MPD::Common::Item::Song', 'song(id) return' );
     is($song->file, 'title.ogg',                      'song(id) defaults to current song' );
-}
+}

Modified: trunk/libpoe-component-client-mpd-perl/t/43-cmds-settings.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/43-cmds-settings.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/43-cmds-settings.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/43-cmds-settings.t Sat Feb 13 23:44:47 2010
@@ -72,4 +72,5 @@
 sub check_random_is_off { check_success($_[0]); is($_[1]->random, 0, 'random is off'); }
 
 sub check_fade_is_on    { check_success($_[0]); is($_[1]->xfade, 15, 'enabling fading'); }
-sub check_fade_is_off   { check_success($_[0]); is($_[1]->xfade, 0,  'disabling fading by default'); }
+sub check_fade_is_off   { check_success($_[0]); is($_[1]->xfade, 0,  'disabling fading by default'); }
+

Modified: trunk/libpoe-component-client-mpd-perl/t/44-cmds-playback.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/44-cmds-playback.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/44-cmds-playback.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/44-cmds-playback.t Sat Feb 13 23:44:47 2010
@@ -219,4 +219,4 @@
         skip "detection method doesn't always work - depends on timing", 1;
         is($_[1]->time->sofar_secs, 1, 'seekid() defaults to current song');
     }
-}
+}

Modified: trunk/libpoe-component-client-mpd-perl/t/50-pl-info.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/50-pl-info.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/50-pl-info.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/50-pl-info.t Sat Feb 13 23:44:47 2010
@@ -65,4 +65,4 @@
     check_success($msg);
     isa_ok($_, 'Audio::MPD::Common::Item::Song', 'items_changed_since() return') for @$items;
     is($items->[0]->title, 'ok-title', 'first song reported first');
-}
+}

Modified: trunk/libpoe-component-client-mpd-perl/t/51-pl-add_rm.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/51-pl-add_rm.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/51-pl-add_rm.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/51-pl-add_rm.t Sat Feb 13 23:44:47 2010
@@ -80,4 +80,4 @@
 sub check_del   { check_success($_[0]); is($_[1]->playlistlength, $nb-2, 'delete() songs'); }
 sub check_delid { check_success($_[0]); is($_[1]->playlistlength, $nb-1, 'deleteid() songs'); }
 sub check_clear { check_success($_[0]); is($_[1]->playlistlength, 0, 'clear() leaves 0 song'); }
-sub check_crop  { check_success($_[0]); is($_[1]->playlistlength, 1, 'crop() leaves only 1 song'); }
+sub check_crop  { check_success($_[0]); is($_[1]->playlistlength, 1, 'crop() leaves only 1 song'); }

Modified: trunk/libpoe-component-client-mpd-perl/t/52-pl-change.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/52-pl-change.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/52-pl-change.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/52-pl-change.t Sat Feb 13 23:44:47 2010
@@ -86,4 +86,4 @@
     my ($msg, $items) = @_;
     check_success($msg);
     is($items->[2]->title, 'ok-title', 'swap[id()] / swap[id()] changes songs');
-}
+}

Modified: trunk/libpoe-component-client-mpd-perl/t/53-pl-manage.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/53-pl-manage.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/53-pl-manage.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/53-pl-manage.t Sat Feb 13 23:44:47 2010
@@ -72,4 +72,4 @@
     check_success($msg);
     my $pdir = playlist_dir();
     ok(! -f "$pdir/test-jq.m3u", 'rm() removes a playlist');
-}
+}

Modified: trunk/libpoe-component-client-mpd-perl/t/60-coll-retrieve.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/60-coll-retrieve.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/60-coll-retrieve.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/60-coll-retrieve.t Sat Feb 13 23:44:47 2010
@@ -92,4 +92,4 @@
     my ($msg, $items) = @_;
     check_success($msg);
     is(scalar @$items, 2, 'items_in_dir() can take a param');
-}
+}

Modified: trunk/libpoe-component-client-mpd-perl/t/61-coll-whole.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/61-coll-whole.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/61-coll-whole.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/61-coll-whole.t Sat Feb 13 23:44:47 2010
@@ -81,4 +81,4 @@
     check_success($msg);
     is(scalar @$items, 4, 'all_files() return the pathes');
     like($items->[0], qr/\.ogg$/, 'all_files() return strings');
-}
+}

Modified: trunk/libpoe-component-client-mpd-perl/t/62-coll-pick.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/62-coll-pick.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/62-coll-pick.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/62-coll-pick.t Sat Feb 13 23:44:47 2010
@@ -59,4 +59,6 @@
     check_success($msg);
     isa_ok($_, 'Audio::MPD::Common::Item::Song', 'songs_with_filename_partial() return') for @$items;
     like($items->[0]->file, qr/album/, 'songs_with_filename_partial() return the correct song');
-}
+}
+
+

Modified: trunk/libpoe-component-client-mpd-perl/t/63-coll-relations.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/63-coll-relations.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/63-coll-relations.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/63-coll-relations.t Sat Feb 13 23:44:47 2010
@@ -115,4 +115,5 @@
     is(scalar @$items, 3, 'songs_with_title_partial() return all the songs found');
     isa_ok($_, 'Audio::MPD::Common::Item::Song', 'songs_with_title_partial() return') for @$items;
     like($items->[0]->title, qr/title/, 'songs_with_title_partial() return correct objects');
-}
+}
+

Modified: trunk/libpoe-component-client-mpd-perl/t/author-critic.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-mpd-perl/t/author-critic.t?rev=52690&op=diff
==============================================================================
--- trunk/libpoe-component-client-mpd-perl/t/author-critic.t (original)
+++ trunk/libpoe-component-client-mpd-perl/t/author-critic.t Sat Feb 13 23:44:47 2010
@@ -16,6 +16,9 @@
 }
 
 
+use strict;
+use warnings;
+
 use Test::More;
 use English qw(-no_match_vars);

More information about the Pkg-perl-cvs-commits mailing list