r55214 - in /trunk/libipc-run-perl: ./ debian/ lib/IPC/ lib/IPC/Run/ t/

carnil-guest at users.alioth.debian.org carnil-guest at users.alioth.debian.org
Wed Mar 31 06:29:14 UTC 2010


Author: carnil-guest
Date: Wed Mar 31 06:28:00 2010
New Revision: 55214

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=55214
Log:
* New upstream release
* Readd versioned dependencies on libio-pty-perl with epoch in the version
  string to be correct now. 

Added:
    trunk/libipc-run-perl/t/98_pod_coverage.t
      - copied unchanged from r55213, branches/upstream/libipc-run-perl/current/t/98_pod_coverage.t
    trunk/libipc-run-perl/t/99_perl_minimum_version.t
      - copied unchanged from r55213, branches/upstream/libipc-run-perl/current/t/99_perl_minimum_version.t
Removed:
    trunk/libipc-run-perl/t/99_pmv.t
Modified:
    trunk/libipc-run-perl/Changes
    trunk/libipc-run-perl/MANIFEST
    trunk/libipc-run-perl/META.yml
    trunk/libipc-run-perl/Makefile.PL
    trunk/libipc-run-perl/debian/changelog
    trunk/libipc-run-perl/debian/control
    trunk/libipc-run-perl/lib/IPC/Run.pm
    trunk/libipc-run-perl/lib/IPC/Run/Debug.pm
    trunk/libipc-run-perl/lib/IPC/Run/IO.pm
    trunk/libipc-run-perl/lib/IPC/Run/Timer.pm
    trunk/libipc-run-perl/lib/IPC/Run/Win32Helper.pm
    trunk/libipc-run-perl/lib/IPC/Run/Win32IO.pm
    trunk/libipc-run-perl/lib/IPC/Run/Win32Pump.pm
    trunk/libipc-run-perl/t/98_pod.t

Modified: trunk/libipc-run-perl/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-run-perl/Changes?rev=55214&op=diff
==============================================================================
--- trunk/libipc-run-perl/Changes (original)
+++ trunk/libipc-run-perl/Changes Wed Mar 31 06:28:00 2010
@@ -1,4 +1,19 @@
 Revision history for Perl extension IPC::Run
+
+0.88 Tue 30 Mar 2010
+  - Missed dangling isa in IPC::Run::Debug
+  - Fix retry for read of fh when I get "Resource temporarily unavailable."
+    It was previously pounding on the file handle with no rest 200 times then giving up.
+    On fast systems this wasn't long enough. I'm implementing select(undef, undef, 0.01)
+    to provide a more consistent retry among hardware and os.
+  - Fix POD indentation in IO.pm
+
+0.87 Mon 29 Mar 2010
+  - Add doc type fixes - RT 56030 from carnil (Debian)
+  - Remove reccommends for AUTHOR only modules
+  - add pod_coverage and simplify pod test.
+  - document undocumented public subs with TODO and best guess as to what they do.
+  - Explicity recommend IO::Pty version number 1.08
 
 0.86 Wed 24 Mar 2010
   - Add all files to subversion for easier releases

Modified: trunk/libipc-run-perl/MANIFEST
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-run-perl/MANIFEST?rev=55214&op=diff
==============================================================================
--- trunk/libipc-run-perl/MANIFEST (original)
+++ trunk/libipc-run-perl/MANIFEST Wed Mar 31 06:28:00 2010
@@ -23,7 +23,8 @@
 README
 t/97_meta.t
 t/98_pod.t
-t/99_pmv.t
+t/98_pod_coverage.t
+t/99_perl_minimum_version.t
 t/adopt.t
 t/binmode.t
 t/bogus.t

Modified: trunk/libipc-run-perl/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-run-perl/META.yml?rev=55214&op=diff
==============================================================================
--- trunk/libipc-run-perl/META.yml (original)
+++ trunk/libipc-run-perl/META.yml Wed Mar 31 06:28:00 2010
@@ -1,9 +1,10 @@
 --- #YAML:1.0
 name:               IPC-Run
-version:            0.86
+version:            0.88
 abstract:           system() and background procs w/ piping, redirs, ptys (Unix, Win32)
-author:  []
-license:            unknown
+author:
+    - Barrie Slaymaker <barries at slaysys.com>
+license:            perl
 distribution_type:  module
 configure_requires:
     ExtUtils::MakeMaker:  0
@@ -25,9 +26,4 @@
     url:      http://module-build.sourceforge.net/META-spec-v1.4.html
     version:  1.4
 recommends:
-    IO::Pty:              0
-    Perl::MinimumVersion:  0
-    Pod::Simple:          0
-    Test::CPAN::Meta:     0
-    Test::MinimumVersion:  0
-    Test::Pod:            0
+    IO::Pty:  1.08

Modified: trunk/libipc-run-perl/Makefile.PL
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-run-perl/Makefile.PL?rev=55214&op=diff
==============================================================================
--- trunk/libipc-run-perl/Makefile.PL (original)
+++ trunk/libipc-run-perl/Makefile.PL Wed Mar 31 06:28:00 2010
@@ -41,20 +41,17 @@
 
 WriteMakefile(
 	NAME         => 'IPC::Run',
-	ABSTRACT     => 'system() and background procs w/ piping, redirs, ptys (Unix, Win32)',
+	ABSTRACT     => 'system() and background procs w/ piping, redirs, ptys (Unix, Win32)',	
+	AUTHOR       => 'Barrie Slaymaker <barries at slaysys.com>',
 	VERSION_FROM => 'lib/IPC/Run.pm',
+	($ExtUtils::MakeMaker::VERSION >= 6.3002 ? ('LICENSE'        => 'perl', ) : ()),
 	PREREQ_PM    => {
 		Test::More => '0.47',
 		%PREREQ_PM,
 	},
 	META_MERGE  => {
 	    recommends => {
-		'Test::CPAN::Meta' => 0,
-		'Pod::Simple' =>  0,
-		'Test::Pod' => 0,
-		'Perl::MinimumVersion' => 0,
-		'Test::MinimumVersion' => 0,
-		'IO::Pty' => 0,
+		'IO::Pty' => '1.08',
 	    },
 	    build_requires => {
 		'Test::More' => 0,  # For testing

Modified: trunk/libipc-run-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-run-perl/debian/changelog?rev=55214&op=diff
==============================================================================
--- trunk/libipc-run-perl/debian/changelog (original)
+++ trunk/libipc-run-perl/debian/changelog Wed Mar 31 06:28:00 2010
@@ -1,3 +1,11 @@
+libipc-run-perl (0.88-1) UNRELEASED; urgency=low
+
+  * New upstream release
+  * Readd versioned dependencies on libio-pty-perl with epoch in the version
+    string to be correct now. 
+
+ -- Salvatore Bonaccorso <salvatore.bonaccorso at gmail.com>  Wed, 31 Mar 2010 08:26:40 +0200
+
 libipc-run-perl (0.86-1) unstable; urgency=low
 
   [ gregor herrmann ]

Modified: trunk/libipc-run-perl/debian/control
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-run-perl/debian/control?rev=55214&op=diff
==============================================================================
--- trunk/libipc-run-perl/debian/control (original)
+++ trunk/libipc-run-perl/debian/control Wed Mar 31 06:28:00 2010
@@ -11,11 +11,11 @@
 Vcs-Svn: svn://svn.debian.org/pkg-perl/trunk/libipc-run-perl/
 Vcs-Browser: http://svn.debian.org/viewsvn/pkg-perl/trunk/libipc-run-perl/
 Build-Depends: debhelper (>= 7.0.50)
-Build-Depends-Indep: libio-pty-perl, netbase, perl
+Build-Depends-Indep: libio-pty-perl (>= 1:1.08), netbase, perl
 
 Package: libipc-run-perl
 Architecture: all
-Depends: ${misc:Depends}, ${perl:Depends}, libio-pty-perl
+Depends: ${misc:Depends}, ${perl:Depends}, libio-pty-perl (> 1:1.08)
 Description: Perl module for running processes
  IPC::Run allows you to run and interact with child processes using
  files, pipes, and pseudo-ttys.  Both system()-style and scripted

Modified: trunk/libipc-run-perl/lib/IPC/Run.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-run-perl/lib/IPC/Run.pm?rev=55214&op=diff
==============================================================================
--- trunk/libipc-run-perl/lib/IPC/Run.pm (original)
+++ trunk/libipc-run-perl/lib/IPC/Run.pm Wed Mar 31 06:28:00 2010
@@ -112,7 +112,7 @@
 
 =head1 DESCRIPTION
 
-IPC::Run allows you run and interact with child processes using files, pipes,
+IPC::Run allows you to run and interact with child processes using files, pipes,
 and pseudo-ttys.  Both system()-style and scripted usages are supported and
 may be mixed.  Likewise, functional and OO API styles are both supported and
 may be mixed.
@@ -1005,13 +1005,15 @@
 
 =head1 ROUTINES
 
+=over
+
 =cut
 
 use strict;
 use Exporter ();
 use vars qw{$VERSION @ISA @FILTER_IMP @FILTERS @API @EXPORT_OK %EXPORT_TAGS};
 BEGIN {
-	$VERSION = '0.86';
+	$VERSION = '0.88';
 	@ISA     = qw{ Exporter };
 
 	## We use @EXPORT for the end user's convenience: there's only one function
@@ -1531,10 +1533,10 @@
 Sends a C<TERM>, waits for all children to exit for up to 30 seconds, then
 sends a C<KILL> to any that survived the C<TERM>.
 
-Will wait for up to 30 more seconds for the OS to sucessfully C<KILL> the
+Will wait for up to 30 more seconds for the OS to successfully C<KILL> the
 processes.
 
-The 30 seconds may be overriden by setting the C<grace> option, this
+The 30 seconds may be overridden by setting the C<grace> option, this
 overrides both timers.
 
 The harness is then cleaned up.
@@ -2862,10 +2864,13 @@
    return $self;
 }
 
+=item adopt
+
+Experimental feature. NOT FUNCTIONAL YET, NEED TO CLOSE FDS BETTER IN CHILDREN.  SEE t/adopt.t for a test suite.
+
+=cut
 
 sub adopt {
-   ## NOT FUNCTIONAL YET, NEED TO CLOSE FDS BETTER IN CHILDREN.  SEE
-   ## t/adopt.t for a test suite.
    my IPC::Run $self = shift;
 
    for my $adoptee ( @_ ) {
@@ -3609,6 +3614,8 @@
 
 =back
 
+=back
+
 =head1 FILTERS
 
 These filters are used to modify input our output between a child
@@ -3751,6 +3758,16 @@
    };
 }
 
+=item new_string_source
+
+TODO: Needs confirmation. Was previously undocumented. in this module.
+
+This is a filter which is exportable. Returns a sub which appends the data passed in to the output buffer and returns 1 if data was appended. 0 if it was an empty string and undef if no data was passed. 
+
+NOTE: Any additional variables passed to new_string_source will be passed to the sub every time it's called and appended to the output. 
+
+=cut
+
 
 sub new_string_source {
    my $ref;
@@ -3787,6 +3804,13 @@
       }
 }
 
+=item new_string_sink
+
+TODO: Needs confirmation. Was previously undocumented.
+
+This is a filter which is exportable. Returns a sub which pops the data out of the input stream and pushes it onto the string.
+
+=cut
 
 sub new_string_sink {
    my ( $string_ref ) = @_;
@@ -4094,7 +4118,7 @@
 gets replaced with /dev/fd or the name of a temporary file containing foo's
 output.  This is like <(sub_cmd ...) found in bash and csh (IIRC).
 
-Allow multiple harnesses to be combined as independant sets of processes
+Allow multiple harnesses to be combined as independent sets of processes
 in to one 'meta-harness'.
 
 Allow a harness to be passed in place of an \@cmd.  This would allow

Modified: trunk/libipc-run-perl/lib/IPC/Run/Debug.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-run-perl/lib/IPC/Run/Debug.pm?rev=55214&op=diff
==============================================================================
--- trunk/libipc-run-perl/lib/IPC/Run/Debug.pm (original)
+++ trunk/libipc-run-perl/lib/IPC/Run/Debug.pm Wed Mar 31 06:28:00 2010
@@ -25,7 +25,7 @@
 =head1 DESCRIPTION
 
 Controls IPC::Run debugging.  Debugging levels are now set by using words,
-but the numbers shown are still supported for backwards compatability:
+but the numbers shown are still supported for backwards compatibility:
 
    0  none         disabled (special, see below)
    1  basic        what's running
@@ -70,7 +70,7 @@
 use Exporter;
 use vars qw{$VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS};
 BEGIN {
-	$VERSION = '0.86';
+	$VERSION = '0.88';
 	@ISA     = qw( Exporter );
 	@EXPORT  = qw(
 		_debug
@@ -268,7 +268,7 @@
    my $op = pop;
    my $kid = $_[0];
 
-Carp::carp join " ", caller(0), $text, $op  if defined $op  && isa( $op, "IO::Pty" );
+Carp::carp join " ", caller(0), $text, $op  if defined $op  && UNIVERSAL::isa( $op, "IO::Pty" );
 
    _debug(
       $text,

Modified: trunk/libipc-run-perl/lib/IPC/Run/IO.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-run-perl/lib/IPC/Run/IO.pm?rev=55214&op=diff
==============================================================================
--- trunk/libipc-run-perl/lib/IPC/Run/IO.pm (original)
+++ trunk/libipc-run-perl/lib/IPC/Run/IO.pm Wed Mar 31 06:28:00 2010
@@ -1,6 +1,4 @@
 package IPC::Run::IO;
-
-=pod
 
 =head1 NAME
 
@@ -48,7 +46,7 @@
 =head1 DESCRIPTION
 
 This class and module allows filehandles and filenames to be harnessed for
-I/O when used IPC::Run, independant of anything else IPC::Run is doing
+I/O when used IPC::Run, independent of anything else IPC::Run is doing
 (except that errors & exceptions can affect all things that IPC::Run is
 doing).
 
@@ -56,14 +54,6 @@
 
 INCOMPATIBLE CHANGE: due to the awkwardness introduced in ripping pseudohashes
 out of Perl, this class I<no longer> uses the fields pragma.
-
-=head1 TODO
-
-Implement bidirectionality.
-
-=head1 AUTHOR
-
-Barrie Slaymaker <barries at slaysys.com>
 
 =cut
 
@@ -82,7 +72,7 @@
 
 use vars qw{$VERSION};
 BEGIN {
-	$VERSION = '0.86';
+	$VERSION = '0.88';
 	if ( Win32_MODE ) {
 		eval "use IPC::Run::Win32Helper; require IPC::Run::Win32IO; 1"
 		or ( $@ && die ) or die "$!";
@@ -91,6 +81,18 @@
 
 sub _empty($);
 *_empty = \&IPC::Run::_empty;
+
+=head1 SUBROUTINES
+
+=over 4
+
+=item new
+
+I think it takes >> or << along with some other data.
+
+TODO: Needs more thorough documentation. Patches welcome.
+
+=cut
 
 sub new {
    my $class = shift;
@@ -219,10 +221,6 @@
    return $self;
 }
 
-=pod
-
-=over
-
 =item filename
 
 Gets/sets the filename.  Returns the value after the name change, if
@@ -235,8 +233,6 @@
    $self->{FILENAME} = shift if @_;
    return $self->{FILENAME};
 }
-
-=pod
 
 =item init
 
@@ -311,7 +307,7 @@
 =item open_pipe
 
 If this is a redirection IO object, this opens the pipe in a platform
-independant manner.
+independent manner.
 
 =cut
 
@@ -407,8 +403,6 @@
    return $fd;
 }
 
-=pod
-
 =item mode
 
 Returns the operator in terms of 'r', 'w', and 'a'.  There is a state
@@ -516,6 +510,13 @@
    push @{$self->{FBUFS}}, $self->{SOURCE};
 }
 
+=item poll
+
+TODO: Needs confirmation that this is correct. Was previously undocumented.
+
+I believe this is polling the IO for new input and then returns undef if there will never be any more input, 0 if there is none now, but there might be in the future, and TRUE if more input was gotten.
+
+=cut
 
 sub poll {
    my IPC::Run::IO $self = shift;
@@ -550,14 +551,17 @@
    my ( $saved_op, $saved_num ) =($IPC::Run::filter_op,$IPC::Run::filter_num);
    $IPC::Run::filter_op = $self;
    $IPC::Run::filter_num = -1;
-   my $c = 0;
+   my $redos = 0;
    my $r;
    {
 	   $@ = '';
 	   $r = eval { IPC::Run::get_more_input(); };
-	   $c++;
-	   ##$@ and warn "redo ", substr($@, 0, 20) , " ";
-	   (($c < 200) and ($@||'')=~ m/^Resource temporarily/) and redo;
+
+	   # Detect Resource temporarily unavailable and re-try to a point (200 or 2 seconds),  assuming select behaves (which it doesn't always? need ref)
+	   if($@ && $@ =~ m/^Resource temporarily/ && $redos++ < 200) {
+	       select(undef, undef, undef, 0.01);
+	       redo;
+	   }
    }
    ( $IPC::Run::filter_op, $IPC::Run::filter_num ) = ( $saved_op, $saved_num );
    $self->{HARNESS} = undef;
@@ -565,4 +569,16 @@
    return $r;
 }
 
+=back
+
+=head1 AUTHOR
+
+Barrie Slaymaker <barries at slaysys.com>
+
+=head1 TODO
+
+Implement bidirectionality.
+
+=cut
+
 1;

Modified: trunk/libipc-run-perl/lib/IPC/Run/Timer.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-run-perl/lib/IPC/Run/Timer.pm?rev=55214&op=diff
==============================================================================
--- trunk/libipc-run-perl/lib/IPC/Run/Timer.pm (original)
+++ trunk/libipc-run-perl/lib/IPC/Run/Timer.pm Wed Mar 31 06:28:00 2010
@@ -163,7 +163,7 @@
 use Exporter;
 use vars qw( $VERSION @ISA @EXPORT_OK %EXPORT_TAGS );
 BEGIN {
-	$VERSION   = '0.86';
+	$VERSION   = '0.88';
 	@ISA       = qw( Exporter );
 	@EXPORT_OK = qw(
 		check
@@ -658,6 +658,8 @@
 Note:  Setting the state to 'undef' to expire a timer will not throw an
 exception.
 
+=back
+
 =cut
 
 sub state {
@@ -675,8 +677,6 @@
 
 =pod
 
-=back
-
 =head1 TODO
 
 use Time::HiRes; if it's present.

Modified: trunk/libipc-run-perl/lib/IPC/Run/Win32Helper.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-run-perl/lib/IPC/Run/Win32Helper.pm?rev=55214&op=diff
==============================================================================
--- trunk/libipc-run-perl/lib/IPC/Run/Win32Helper.pm (original)
+++ trunk/libipc-run-perl/lib/IPC/Run/Win32Helper.pm Wed Mar 31 06:28:00 2010
@@ -24,7 +24,7 @@
 use IO::Handle;
 use vars qw{ $VERSION @ISA @EXPORT };
 BEGIN {
-	$VERSION = '0.86';
+	$VERSION = '0.88';
 	@ISA = qw( Exporter );
 	@EXPORT = qw(
 		win32_spawn

Modified: trunk/libipc-run-perl/lib/IPC/Run/Win32IO.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-run-perl/lib/IPC/Run/Win32IO.pm?rev=55214&op=diff
==============================================================================
--- trunk/libipc-run-perl/lib/IPC/Run/Win32IO.pm (original)
+++ trunk/libipc-run-perl/lib/IPC/Run/Win32IO.pm Wed Mar 31 06:28:00 2010
@@ -31,7 +31,7 @@
 
 use vars qw{$VERSION};
 BEGIN {
-	$VERSION = '0.86';
+	$VERSION = '0.88';
 }
 
 use Socket qw( IPPROTO_TCP TCP_NODELAY );

Modified: trunk/libipc-run-perl/lib/IPC/Run/Win32Pump.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-run-perl/lib/IPC/Run/Win32Pump.pm?rev=55214&op=diff
==============================================================================
--- trunk/libipc-run-perl/lib/IPC/Run/Win32Pump.pm (original)
+++ trunk/libipc-run-perl/lib/IPC/Run/Win32Pump.pm Wed Mar 31 06:28:00 2010
@@ -29,7 +29,7 @@
 use strict;
 use vars qw{$VERSION};
 BEGIN {
-	$VERSION = '0.86';
+	$VERSION = '0.88';
 }
 
 use Win32API::File qw(

Modified: trunk/libipc-run-perl/t/98_pod.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libipc-run-perl/t/98_pod.t?rev=55214&op=diff
==============================================================================
--- trunk/libipc-run-perl/t/98_pod.t (original)
+++ trunk/libipc-run-perl/t/98_pod.t Wed Mar 31 06:28:00 2010
@@ -1,32 +1,6 @@
-#!/usr/bin/perl
+#!perl -T
 
-# Test that the syntax of our POD documentation is valid
-
-use strict;
-BEGIN {
-	$|  = 1;
-	$^W = 1;
-}
-
-my @MODULES = (
-	'Pod::Simple 3.07',
-	'Test::Pod 1.26',
-);
-
-# Don't run tests for installs
 use Test::More;
-unless ( $ENV{AUTOMATED_TESTING} or $ENV{RELEASE_TESTING} ) {
-	plan( skip_all => "Author tests not required for installation" );
-}
-
-# Load the testing modules
-foreach my $MODULE ( @MODULES ) {
-	eval "use $MODULE";
-	if ( $@ ) {
-		$ENV{RELEASE_TESTING}
-		? die( "Failed to load required release-testing module $MODULE" )
-		: plan( skip_all => "$MODULE not available for testing" );
-	}
-}
-
+eval "use Test::Pod 1.14";
+plan skip_all => "Test::Pod 1.14 required for testing POD" if $@;
 all_pod_files_ok();




More information about the Pkg-perl-cvs-commits mailing list