Bug#245606: marked as done (FTBFS: Duplicate case values)
Debian Bug Tracking System
owner@bugs.debian.org
Sat, 24 Apr 2004 02:48:04 -0700
Your message dated Sat, 24 Apr 2004 05:32:04 -0400
with message-id <E1BHJW0-0006kq-00@newraff.debian.org>
and subject line Bug#245606: fixed in libwww-curl-perl 2.0-7
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 24 Apr 2004 00:14:56 +0000
>From kraai@lafn.org Fri Apr 23 17:14:56 2004
Return-path: <kraai@lafn.org>
Received: from zoot.lafn.org [206.117.18.6]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1BHAoq-0004Ap-00; Fri, 23 Apr 2004 17:14:56 -0700
Received: from catalunya (host-66-81-193-134.rev.o1.com [66.81.193.134])
by zoot.lafn.org (8.12.3p3/8.12.3) with ESMTP id i3O0Eo3V081363
(version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NO)
for <submit@bugs.debian.org>; Fri, 23 Apr 2004 17:14:52 -0700 (PDT)
(envelope-from kraai@lafn.org)
Received: from kraai by catalunya with local (Exim 4.30)
id 1BH3K8-0001Fm-OZ
for submit@bugs.debian.org; Fri, 23 Apr 2004 09:14:44 -0700
Date: Fri, 23 Apr 2004 09:14:44 -0700
From: Matt Kraai <kraai@ftbfs.org>
To: submit@bugs.debian.org
Subject: FTBFS: Duplicate case values
Message-ID: <20040423161444.GE4660@catalunya>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="4bRzO86E/ozDv8r1"
Content-Disposition: inline
User-Agent: Mutt/1.5.5.1+cvs20040105i
Sender: Matt Kraai <kraai@lafn.org>
X-Virus-Scanned: ClamAV version 'clamd / ClamAV version devel-20040209', clamav-milter version '0.66m'
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-2.2 required=4.0 tests=BAYES_00,DATE_IN_PAST_06_12,
HAS_PACKAGE,OPT_IN_CAPS,UPPERCASE_25_50 autolearn=no
version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
X-CrossAssassin-Score: 1
--4bRzO86E/ozDv8r1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Package: libwww-curl-perl
Version: 2.0-6
Severity: serious
Tags: patch
This package fails to build from source:
...
cc -c -I/usr/include -D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -DDEBIAN -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -g -O2 -DVERSION=\"2.0\" -DXS_VERSION=\"2.0\" -fPIC "-I/usr/lib/perl/5.8/CORE" -DHAVE_INTERNAL_VARS Curl.c
Curl.xs: In function `callback_index':
Curl.xs:105: error: duplicate case value
Curl.xs:104: error: previously used here
Curl.xs: In function `perl_curl_form_delete':
Curl.xs:199: warning: passing arg 1 of `curl_formfree' from incompatible pointer type
Curl.xs: In function `fwrite_wrapper':
Curl.xs:218: warning: unused variable `sv'
Curl.c: In function `XS_WWW__Curl__easy_init':
Curl.c:533: warning: unused variable `ix'
Curl.c: In function `XS_WWW__Curl__easy_version':
Curl.c:646: warning: unused variable `items'
Curl.xs: In function `XS_WWW__Curl__easy_setopt':
Curl.xs:629: error: duplicate case value
Curl.xs:620: error: previously used here
Curl.c: In function `XS_WWW__Curl__easy_internal_setopt':
Curl.c:783: warning: unused variable `option'
Curl.c:784: warning: unused variable `value'
Curl.c: In function `XS_WWW__Curl__form_add':
Curl.c:1070: warning: unused variable `name'
Curl.c:1071: warning: unused variable `value'
Curl.c: In function `XS_WWW__Curl__form_addfile':
Curl.c:1101: warning: unused variable `filename'
Curl.c:1102: warning: unused variable `description'
Curl.c:1103: warning: unused variable `type'
make[1]: *** [Curl.o] Error 1
make[1]: Leaving directory `/tmp/buildd/libwww-curl-perl-2.0'
make: *** [build-stamp] Error 2
pbuilder: Failed autobuilding of package
...
The duplicate values are CURLOPT_PASSWDDATA and
CURLOPT_PASSWDFUNCTION, which are both defined as 0 in recent
versions of curl because they are obsolete. The attached patch
removes them.
--
Matt Kraai kraai@ftbfs.org http://ftbfs.org/
--4bRzO86E/ozDv8r1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=patch
diff -ru libwww-curl-perl-2.0-old/Curl.xs libwww-curl-perl-2.0/Curl.xs
--- libwww-curl-perl-2.0-old/Curl.xs 2003-04-22 05:18:45.000000000 -0700
+++ libwww-curl-perl-2.0/Curl.xs 2004-04-23 08:33:45.000000000 -0700
@@ -100,11 +100,6 @@
case CURLOPT_PROGRESSDATA:
return CALLBACK_PROGRESS;
break;
-
- case CURLOPT_PASSWDFUNCTION:
- case CURLOPT_PASSWDDATA:
- return CALLBACK_PASSWD;
- break;
}
croak("Bad callback index requested\n");
return CALLBACK_LAST;
@@ -386,52 +381,6 @@
}
-/* Password callback for calling a perl callback */
-
-static int passwd_callback_func(void *clientp, char *prompt, char *buffer, int buflen)
-{
- dSP;
- char *data;
- SV *sv;
- STRLEN len;
- int count;
-
- perl_curl_easy *self;
- self=(perl_curl_easy *)clientp;
-
- ENTER;
- SAVETMPS;
- PUSHMARK(sp);
- if (self->callback_ctx[CALLBACK_PASSWD]) {
- XPUSHs(sv_2mortal(newSVsv(self->callback_ctx[CALLBACK_PASSWD])));
- } else {
- XPUSHs(&PL_sv_undef);
- }
- XPUSHs(sv_2mortal(newSVpv(prompt, 0)));
- XPUSHs(sv_2mortal(newSViv(buflen)));
- PUTBACK;
- count = perl_call_sv(self->callback[CALLBACK_PASSWD], G_ARRAY);
- SPAGAIN;
- if (count != 2)
- croak("callback for CURLOPT_PASSWDFUNCTION didn't return status + data\n");
-
- sv = POPs;
- count = POPi;
-
- data = SvPV(sv,len);
-
- /* only allowed to return the number of bytes asked for */
- len = (len<(buflen-1) ? len : (buflen-1));
- memcpy(buffer,data,len);
- buffer[buflen]=0; /* ensure C string terminates */
-
- PUTBACK;
- FREETMPS;
- LEAVE;
- return count;
-}
-
-
#if 0
/* awaiting closepolicy prototype */
int
@@ -536,14 +485,12 @@
curl_easy_setopt(self->curl, CURLOPT_READFUNCTION, read_callback_func);
curl_easy_setopt(self->curl, CURLOPT_HEADERFUNCTION, header_callback_func);
curl_easy_setopt(self->curl, CURLOPT_PROGRESSFUNCTION, progress_callback_func);
- curl_easy_setopt(self->curl, CURLOPT_PASSWDFUNCTION, passwd_callback_func);
/* set our own object as the context for all curl callbacks */
curl_easy_setopt(self->curl, CURLOPT_FILE, self);
curl_easy_setopt(self->curl, CURLOPT_INFILE, self);
curl_easy_setopt(self->curl, CURLOPT_WRITEHEADER, self);
curl_easy_setopt(self->curl, CURLOPT_PROGRESSDATA, self);
- curl_easy_setopt(self->curl, CURLOPT_PASSWDDATA, self);
/* we always collect this, in case it's wanted */
curl_easy_setopt(self->curl, CURLOPT_ERRORBUFFER, self->errbuf);
@@ -572,7 +519,6 @@
curl_easy_setopt(clone->curl, CURLOPT_READFUNCTION, read_callback_func);
curl_easy_setopt(clone->curl, CURLOPT_HEADERFUNCTION, header_callback_func);
curl_easy_setopt(clone->curl, CURLOPT_PROGRESSFUNCTION, progress_callback_func);
- curl_easy_setopt(clone->curl, CURLOPT_PASSWDFUNCTION, passwd_callback_func);
*/
/* set our own object as the context for all curl callbacks */
@@ -580,7 +526,6 @@
curl_easy_setopt(clone->curl, CURLOPT_INFILE, clone);
curl_easy_setopt(clone->curl, CURLOPT_WRITEHEADER, clone);
curl_easy_setopt(clone->curl, CURLOPT_PROGRESSDATA, clone);
- curl_easy_setopt(clone->curl, CURLOPT_PASSWDDATA, clone);
/* we always collect this, in case it's wanted */
curl_easy_setopt(clone->curl, CURLOPT_ERRORBUFFER, clone->errbuf);
@@ -617,7 +562,6 @@
case CURLOPT_INFILE:
case CURLOPT_WRITEHEADER:
case CURLOPT_PROGRESSDATA:
- case CURLOPT_PASSWDDATA:
perl_curl_easy_register_callback(self,&(self->callback_ctx[callback_index(option)]),value);
break;
@@ -626,7 +570,6 @@
case CURLOPT_READFUNCTION:
case CURLOPT_HEADERFUNCTION:
case CURLOPT_PROGRESSFUNCTION:
- case CURLOPT_PASSWDFUNCTION:
perl_curl_easy_register_callback(self,&(self->callback[callback_index(option)]),value);
break;
--4bRzO86E/ozDv8r1--
---------------------------------------
Received: (at 245606-close) by bugs.debian.org; 24 Apr 2004 09:38:01 +0000
>From katie@ftp-master.debian.org Sat Apr 24 02:38:01 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1BHJbl-0001KC-00; Sat, 24 Apr 2004 02:38:01 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1BHJW0-0006kq-00; Sat, 24 Apr 2004 05:32:04 -0400
From: Joachim Breitner <nomeata@debian.org>
To: 245606-close@bugs.debian.org
X-Katie: $Revision: 1.49 $
Subject: Bug#245606: fixed in libwww-curl-perl 2.0-7
Message-Id: <E1BHJW0-0006kq-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Sat, 24 Apr 2004 05:32:04 -0400
Delivered-To: 245606-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
X-CrossAssassin-Score: 1
Source: libwww-curl-perl
Source-Version: 2.0-7
We believe that the bug you reported is fixed in the latest version of
libwww-curl-perl, which is due to be installed in the Debian FTP archive:
libwww-curl-perl_2.0-7.diff.gz
to pool/main/libw/libwww-curl-perl/libwww-curl-perl_2.0-7.diff.gz
libwww-curl-perl_2.0-7.dsc
to pool/main/libw/libwww-curl-perl/libwww-curl-perl_2.0-7.dsc
libwww-curl-perl_2.0-7_i386.deb
to pool/main/libw/libwww-curl-perl/libwww-curl-perl_2.0-7_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 245606@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Joachim Breitner <nomeata@debian.org> (supplier of updated libwww-curl-perl package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 24 Apr 2004 11:06:04 +0200
Source: libwww-curl-perl
Binary: libwww-curl-perl
Architecture: source i386
Version: 2.0-7
Distribution: unstable
Urgency: low
Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>
Changed-By: Joachim Breitner <nomeata@debian.org>
Description:
libwww-curl-perl - Perl bindings to libcurl
Closes: 245606
Changes:
libwww-curl-perl (2.0-7) unstable; urgency=low
.
* Closes: #245606: FTBFS: Duplicate case values
thanks to Matt Kraai for the patch!
Files:
73dd5c67fbf0b504c71635ba90354b3d 754 perl optional libwww-curl-perl_2.0-7.dsc
0e0c15a327e6e01544e90f7aab0d4186 16203 perl optional libwww-curl-perl_2.0-7.diff.gz
5ce575847f36b7d787275bc327762439 53980 perl optional libwww-curl-perl_2.0-7_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFAii/39ijrk0dDIGwRAjyiAJkB2HNMKnO6BDYLFZf+jVy8HuAv4wCdEfZn
VkutvVNcJgJN0c6L0T4knbE=
=bA03
-----END PGP SIGNATURE-----