Bug#437474: libnet-irc-perl patches

[David Sobon]

Hello Niko,
    Thank you for your reply. I accept my patches are ill-thought out
- they indirectly solved the issues I observed with my
not-so-simple-but-for-fun application.

The first patch ('fix_ev_has_null_type.patch')... I did come across a
few presumably non-standard IRC servers that sent unknown numeric
codes. Your second reason seems more plausible. I think the best
approach would be to print debugging info when $ev is undefined... to
find out how it happened. Or example IRC servers? Any pointers?

Third patch... I agree with your solution.

I'll try my project again to see if the issues in question can be
reproduced again, and if at all, reproduced consistently.

-David.

On 13/08/07, Niko Tyni <ntyni at iki.fi> wrote:
> Package: libnet-irc-perl
> Version: 0.75-6
> Severity: normal
>
> Hi David,
>
> thanks for your patches. I'm forwarding them to the Debian bug tracking
> system, so we can better keep track of them. Please keep the bug
> address (xxxxxx at bugs.debian.org, I don't know the number yet) Cc'd.
>
> When is the first patch ('fix_ev_has_null_type.patch') needed?  Is it
> when the server sends an unknown numeric response, or is some part of
> the code calling handler() with an empty string?
>
> The second patch ('fix_next_outside_loop_with_return.patch')
> looks good to me.
>
> I'm not sure of the third one ('fix_send_on_unexpected_close.patch').
> If the server has closed the connection, shouldn't we trigger a
> 'sockerror' event before failing?