Bug#493652: dh-make-perl: Fails to detect name

[Chris West (Faux)]

Package: dh-make-perl
Version: 0.48
Severity: normal
Tags: patch


For (at least) the CPAN package Catalyst::Plugin::Session::State::Cookie, 
 dh-make-perl fails to detect any name at all, and hence uses the empty
 string, printing plenty of uninitialised value warnings in the process.

This results in packages named, for example, lib-perl_0.09-1_all.deb.

ie. (while the package in question is still at version 0.09):

  dh-make-perl --build --cpan Catalyst::Plugin::Session::State::Cookie


During the build process this package's Makefile.PL contains the line:

  name 'Catalyst-Plugin-Session-State-Cookie';

dh-make-perl can be adjusted to pick this up by removing it's
 requirements for brackets:

--- dh-make-perl.orig       2008-08-04 00:37:54.000000000 +0100
+++ dh-make-perl            2008-08-04 00:38:36.000000000 +0100
@@ -548,11 +548,11 @@
            $name = $4;
        } elsif ($file =~ /name
                 \s*
-                \(
+                \(?
                     ([\'\"]?)
                         (\S+)
                     \1
-                \);/xs) {
+                \)?;/xs) {
            # Module::Install syntax
            $name = $2;
        }


-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (700, 'stable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-6-xen-amd64
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)

Versions of packages dh-make-perl depends on:
ii  debhelper                   5.0.42       helper programs for debian/rules
ii  dpkg-dev                    1.13.25      package building tools for Debian
ii  fakeroot                    1.5.10       Gives a fake root environment
ii  libemail-date-format-perl   1.002-1      Module to generate RFC-2822-valid 
ii  libmodule-depends-perl      0.10-1       identify the dependencies of a dis
ii  libwww-mechanize-perl       1.18-1       Automate interaction with websites
ii  libyaml-perl                0.62-1       YAML Ain't Markup Language (tm)
ii  make                        3.81-2       The GNU version of the "make" util
ii  perl                        5.8.8-7etch3 Larry Wall's Practical Extraction 
ii  perl-modules [libpod-parser 5.8.8-7etch3 Core Perl modules

Versions of packages dh-make-perl recommends:
pn  apt-file                      <none>     (no description available)
ii  libmodule-build-perl          0.26-1     Subclassable and make-independant 

-- no debconf information