Comments regarding libio-pager-perl_0.06-1_amd64.changes

Frank Lichtenheld ftpmaster at debian.org
Thu Dec 25 23:26:39 UTC 2008


I'm really considering rejecting this module just for being
crappy:

* the documentation doesn't really describe the behaviour,
  since it claims that it will fall back to the defaults if ENV{PAGER}
  is unusable, which is simply not true, it will only fall back if
  ENV{PAGER} is undefined.
* Doing the whole PAGER detection in BEGIN is also not the smartest idea
  ever...
* Same goes for saving it in ENV instead of the actual objects...
* "#Some platforms don't do -x so we use -e" What crappy platforms are those and
   why not just find them out via $^O or something?
* Ignores /usr/bin/pager
* "eval "require $class"; $class->new($_[0], $class);" -- uh, sure, that's surely
  not gonna die in the second statement if the eval failed...
* The package should recommend "less" since that is not Essential
* "do{ warn -x $ENV{PAGER} ?" sure, lets us ignore all that stuff we did with split
  and not using -x...

Is it really better to include this module in Debian than just rewriting it?





More information about the pkg-perl-maintainers mailing list