r14761 - in /trunk/libterm-readline-gnu-perl: ./ Gnu/ debian/ debian/patches/

[Martín Ferrari]

Hi Niko,

On Feb 12, 2008 4:46 AM, Niko Tyni <ntyni at debian.org> wrote:
> On Mon, Feb 11, 2008 at 01:38:07PM -0000, tincho-guest at users.alioth.debian.org wrote:

> > * debian/rules:
> >   - removed shebang corrections (moved to patch)
> -       find $(DOCDIR)/examples -type f -print0 | xargs --null --no-run-if-empty \
> -         $(PERL) -i -pe '$$_ = "#!/usr/bin/perl$$1\n" if m|^#!.*/perl(.*)$$|;'

> I'm a bit curious as to the rationale of this. It seems to me that fixing
> the perl path at build time in all the example files is more robust wrt.
> upstream changes (file additions / removals) than patching each of them
> separately with quilt.
>
> In fact, I'd probably have made the opposite change if I had to
> touch fix_shebang.patch when upgrading the upstream version...

While you're right that build time fixing is more robust, it felt to
me like a non-very-nice hack; and it is not like there are many
non-example scripts in the distribution (zero). I kept the change on
Gnu.pm, but it is a no-op, since the pm is not meant for direct
execution.

Also, it wasn't checking that the changed line was the first on the
script, so some day it could break something (low probability, I
know). I wouldn't have done that change alone, but as the whole rules
was somewhat "hand-made", complicated, and had many make errors wrt
dependencies, I wanted to make it dead simple.

If you feel that my change is wrong, I don't mind reverting it...

-- 
Martín Ferrari