Bug#465342: libmime-lite-perl: Unusable without mail-transport-agent

Dominic Hargreaves dom at earth.li
Tue Feb 12 17:40:18 UTC 2008

On Tue, Feb 12, 2008 at 04:57:49PM +0100, gregor herrmann wrote:

> After reading the code again I agree; there's also an upstream bug
> report:
> http://rt.cpan.org/Public/Bug/Display.html?id=31245

> Ack, by this change the package (and its rdepends) are rather broken
> :/
> Actually I'd prefer a patch; the one at CPAN is not really elegant,
> maybe we can come up with something more "elegant"?
> First attempt:
> Index: lib/MIME/Lite.pm
> ===================================================================
> --- lib/MIME/Lite.pm	(revision 14794)
> +++ lib/MIME/Lite.pm	(working copy)
> @@ -401,7 +401,7 @@
>          }
>      }
>      unless (-x $SENDMAIL) {
> -        Carp::croak "can't find an executable sendmail"
> +        Carp::carp "can't find an executable sendmail, you won't be able to use send_by_sendmail()"
>      }
>  }

I don't really think that's appropriate either. I haven't checked the
behaviour of MIME::Lite with this conditional section removed (ie as per
the patch on rt.cpan.org) but really it should behave gracefully itself.
carp()ing isn't really appropriate here either. The error only needs to
appear if send_by_sendmail is used, and send should select sendmail if
available, and not otherwise.

BTW, I'm happy in principle to help out with team-maintained perl
packages, if that'd be useful - my alioth username is 'dom'.

Let me know if you will carry this forward or you would like me to
propose a patch for the behaviour described above.



Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)

More information about the pkg-perl-maintainers mailing list