Bug#493058: Looks for copyright information in working directory

Matt Kraai kraai at ftbfs.org
Wed Jul 30 18:22:56 UTC 2008


Package: dh-make-perl
Version: 0.47
Tags: patch

dh-make-perl looks in the working directory for files containing
copyright information.  If a different source directory is specified
on the command line, it doesn't find the copyright information in that
directory.  For example,

 $ wget -q http://search.cpan.org/CPAN/authors/id/P/PJ/PJF/IPC-System-Simple-0.15.tar.gz
 $ tar xzf IPC-System-Simple-0.15.tar.gz
 $ dh-make-perl IPC-System-Simple-0.15
 Found: IPC-System-Simple 0.15 (libipc-system-simple-perl arch=all)
 
 Using maintainer: Matt Kraai <kraai at ftbfs.org>
 Found changelog: Changes
 Found docs: README
 Found examples: examples/*
 Using rules: /usr/share/dh-make-perl/rules.MakeMaker.noxs
 **********
 Copyright information incomplete!
 
 Upstream copyright information could not be automatically determined.
 
 If you are building this package for your personal use, you might disregard
 this information; however, if you intend to upload this package to Debian
 (or in general, if you plan on distributing it), you must look into the
 complete copyright information.
 
 The causes for this warning are:
 No licensing information
 Done
 $ cd IPC-System-Simple-0.15
 $ rm -fr debian
 $ dh-make-perl
 Found: IPC-System-Simple 0.15 (libipc-system-simple-perl arch=all)
 
 Using maintainer: Matt Kraai <kraai at ftbfs.org>
 Found changelog: Changes
 Found docs: README
 Found examples: examples/*
 Using rules: /usr/share/dh-make-perl/rules.MakeMaker.noxs
 Done

The attached patch fixes this problem by looking for the copyright
information in files relative to the source directory (i.e.,
$maindir).  I've verified that it works in both of the above cases.

-- 
Matt                                                 http://ftbfs.org/
-------------- next part --------------
diff -ru dh-make-perl-0.47~/dh-make-perl dh-make-perl-0.47/dh-make-perl
--- dh-make-perl-0.47~/dh-make-perl	2008-07-30 10:55:02.000000000 -0700
+++ dh-make-perl-0.47/dh-make-perl	2008-07-30 11:08:40.000000000 -0700
@@ -446,8 +446,8 @@
 
 sub extract_basic_copyright {
 	for my $f (qw(LICENSE LICENCE COPYING)) {
-		if (-f $f) {
-			return `cat $f`;
+		if (-f "$maindir/$f") {
+			return `cat $maindir/$f`;
 		}
 	}
 	return undef;


More information about the pkg-perl-maintainers mailing list