Bug#501688: [PATCH] improved get_stdmodules

[Paul Fenwick]

G'day everyone,

I've started to do clean-up dh-make-perl that have nothing to do with
build_requires, META.yml, or the like.  I'm not sure of the debian bug
procedure, but I'd like to suggest opening another ticket, or dropping me on
a mailing list, or doing something that means this bug won't get filled with
patches that aren't directly relevant to it.  I'm not sure of the correct
procedure here from your end, so if you can enlighten me, I'd appreciate it.

As a little bit of recreational clean-up, I've written a basic test for
get_stdmodules, as well as altering it so that instead of it rooting around
in perl's @INC, and firing off `dpkg -L`, it instead just asks
Module::CoreList, which has already been Debianised for etch, and which
contains a list of all the core modules for each version of Perl.

It significantly reduces the complexity, size, and execution time of the
code.  We're also no longer expecting external processes to run (eg, dpkg)
and relying upon them to both exist and succeed.

Patches are attached, again generated from git.  The patches are generated
from the 'module-corelist' branch of my git repo.  A basic test is also
included, and assumes the existence of a t/ directory for tests (my previous
patches add this).

If you want me to jump through whatever hoops are needed so I can push
changes into svn after they've been appropriately reviewed, do let me know.

Cheerio,

	Paul

-- 
Paul Fenwick <pjf at perltraining.com.au> | http://perltraining.com.au/
Director of Training                   | Ph:  +61 3 9354 6001
Perl Training Australia                | Fax: +61 3 9354 2681
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Simple-tests-to-ensure-that-get_stdmodules-works.patch
Type: text/x-patch
Size: 0 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20081126/45ffd12e/attachment.bin