[PATCH] Fix test failures when the build directory contains regexp metacharacters.

Niko Tyni ntyni at debian.org
Wed Apr 28 18:23:07 UTC 2010


The build directory name may contain regexp metacharacters like '+'
that need escaping or they break the substitution.
---
 lib/Devel/Cover.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/Devel/Cover.pm b/lib/Devel/Cover.pm
index d9f2b4b..ae8e140 100644
--- a/lib/Devel/Cover.pm
+++ b/lib/Devel/Cover.pm
@@ -441,7 +441,7 @@ sub normalised_file
         # print STDERR "finally <$file> <$Dir>\n";
     }
     $file =~ s|\\|/|g if $^O eq "MSWin32";
-    $file =~ s|^$Dir/||;
+    $file =~ s|^\Q$Dir\E/||;
 
     # print STDERR "File: $f => $file\n";
 
-- 
1.7.0.4


--T4sUOijqQbZv57TR--



------------=_1272494523-5157-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at 579577-close) by bugs.debian.org; 28 Apr 2010 22:39:07 +0000
X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02
	(2008-06-10) on busoni.debian.org
X-Spam-Level: 
X-Spam-Bayes: score:0.0000 Tokens: new, 91; hammy, 150; neutral, 103; spammy,
	1. spammytokens:0.998-1--yqe hammytokens:0.000-+--HX-Debian:DAK,
	0.000-+--H*RU:128.148.34.103, 0.000-+--H*rp:D*ftp-master.debian.org,
	0.000-+--HX-DAK:process-upload, 0.000-+--HX-DAK:dak
X-Spam-Status: No, score=-13.1 required=4.0 tests=AWL,BAYES_00,FROMDEVELOPER,
	FVGT_m_MULTI_ODD,HAS_BUG_NUMBER,IMPRONONCABLE_2,MURPHY_DRUGS_REL8,
	MURPHY_WRONG_WORD1,MURPHY_WRONG_WORD2,PGPSIGNATURE autolearn=ham
	version=3.2.5-bugs.debian.org_2005_01_02
Return-path: <envelope at ftp-master.debian.org>
Received: from ries.debian.org ([128.148.34.103])
	from C=NA,ST=NA,L=Ankh Morpork,O=Debian SMTP,OU=Debian SMTP CA,CN=ries.debian.org,EMAIL=hostmaster at ries.debian.org (verified)
	by busoni.debian.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.69)
	(envelope-from <envelope at ftp-master.debian.org>)
	id 1O7FuN-0000yD-86
	for 579577-close at bugs.debian.org; Wed, 28 Apr 2010 22:39:07 +0000
Received: from dak by ries.debian.org with local (Exim 4.69)
	(envelope-from <envelope at ftp-master.debian.org>)
	id 1O7FuK-00038q-TN; Wed, 28 Apr 2010 22:39:04 +0000
From: gregor herrmann <gregoa at debian.org>
To: 579577-close at bugs.debian.org
X-DAK: dak process-upload
X-Debian: DAK
X-Debian-Package: libdevel-cover-perl
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Subject: Bug#579577: fixed in libdevel-cover-perl 0.66-2
Message-Id: <E1O7FuK-00038q-TN at ries.debian.org>
Sender: Archive Administrator <dak at ries.debian.org>
Date: Wed, 28 Apr 2010 22:39:04 +0000

Source: libdevel-cover-perl
Source-Version: 0.66-2

We believe that the bug you reported is fixed in the latest version of
libdevel-cover-perl, which is due to be installed in the Debian FTP archive:

libdevel-cover-perl_0.66-2.debian.tar.gz
  to main/libd/libdevel-cover-perl/libdevel-cover-perl_0.66-2.debian.tar.gz
libdevel-cover-perl_0.66-2.dsc
  to main/libd/libdevel-cover-perl/libdevel-cover-perl_0.66-2.dsc
libdevel-cover-perl_0.66-2_i386.deb
  to main/libd/libdevel-cover-perl/libdevel-cover-perl_0.66-2_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 579577 at bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
gregor herrmann <gregoa at debian.org> (supplier of updated libdevel-cover-perl package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster at debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 28 Apr 2010 23:52:50 +0200
Source: libdevel-cover-perl
Binary: libdevel-cover-perl
Architecture: source i386
Version: 0.66-2
Distribution: unstable
Urgency: low
Maintainer: Debian Perl Group <pkg-perl-maintainers at lists.alioth.debian.org>
Changed-By: gregor herrmann <gregoa at debian.org>
Description: 
 libdevel-cover-perl - Perl tool for determining code coverage metrics
Closes: 579577
Changes: 
 libdevel-cover-perl (0.66-2) unstable; urgency=low
 .
   * Add new patch to fix build issues when the build path contains regexp
     metacharacters; thanks to Niko Tyni for bug report and patch
     (closes: #579577).
Checksums-Sha1: 
 c66bf3d329273948ed0cf28e68f2cf20cb9af8d3 2097 libdevel-cover-perl_0.66-2.dsc
 b40450d5075f2de4923afb4ff14946a51e2c47bf 5008 libdevel-cover-perl_0.66-2.debian.tar.gz
 201ea4b403bab3307627ff6295e2ed6900e4489f 174056 libdevel-cover-perl_0.66-2_i386.deb
Checksums-Sha256: 
 b7c8c1d4d92e280da523aaa4e309c0339fd064b093d16b2d0ecdf125816e6a96 2097 libdevel-cover-perl_0.66-2.dsc
 ed6a34fd43c8849384afb3f0e85eeaa73f62019a406f5a7d618cfe67bed6a3c5 5008 libdevel-cover-perl_0.66-2.debian.tar.gz
 28152088fb088039bb3d7ce6e3dbea98b58e7176e22c84b2757773a05ae89b34 174056 libdevel-cover-perl_0.66-2_i386.deb
Files: 
 7e5eebab56f5837067e73b0275f48b15 2097 perl optional libdevel-cover-perl_0.66-2.dsc
 522f44f269a233f2f1bb03704db9599b 5008 perl optional libdevel-cover-perl_0.66-2.debian.tar.gz
 bbccc6db21af9bd9ee9deb8983a22a5e 174056 perl optional libdevel-cover-perl_0.66-2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJL2K7kAAoJELs6aAGGSaoGkPsQAL7VoCmAqRpsNw+h42YMx2G3
NsDgABeFuuez9YeWF/5DvYa3Ss8DENcpFXNRPcXVFCAnwEbuhKxfT0VhDR23l+lC
1SLx/aqmHqLOJvZV1XMiyltxI/JjRv2bb5cw1yDgomwqeipylFMOenndcCzG+YQE
K0dTGpOpFiRqm9ywgPTttGMPfKHtLL1OuD6SyjVa77lGLlJczTZG90lwXe2xAFuD
UhsDhfWZiS/kT5zAh+AfxfuiMaFtVNEFnR7PQrBZAqe0hNNwgy5qFnLCE+bGyT5a
j/1HNYEXtb/UuWcIIsN1pSoXZAK+pRrYcWiD4MmI/XCN7BxHyFhFqOBg+4pyv0Lx
YxT4IDQ72sUpU5vwzWDav+zbgPQhLnil0s1/MiH8mXn69jF/mN1B4kL2qB3LW4Fa
a48JUkJ8zOQxpaEHYN/ltRPNtuYO63CTSvwbSgBugYrcWxDnUKIAnfXmluD1R2Lv
QW8jrjXH4m7TARnXOE4CRcHbQXU4k1Xy5/mM8QuWFWNxjYR3P6UIb5d3SQgjo4Fc
3rXDXLF1P0dK0PoGnJ20dQbLyffITuoWFHDIzqSX3vnQq2IzZzhyYlI0Y5gBhyFJ
p9XfHMinS+R8FiLoyoawrwKCVxHU6HI+Orlam9Nd6gMaNiFkxCs0M4Pn3GRup6r7
F3c6SB1bBK1q71AeSbmd
=HLY1
-----END PGP SIGNATURE-----



------------=_1272494523-5157-0--



More information about the pkg-perl-maintainers mailing list