Bug#611036: clive: YouTube formats are outdated, and config validation prevents using new names

[Sven Hoexter]

On Mon, Jan 24, 2011 at 06:58:22PM -0500, Adrian Irving-Beer wrote:

> I would think we should be consulting the provider modules to
> determine the list of usable formats.  At the very least, the
> Config.pm validation badly needs updating, and the docs need updating
> either way because the "fmt??" formats are all invalid now.

Looking at the recent clive releases there are a bunch of compatiblity
lists in Config.pm though Youtube.pm will then still only fetch the default
format.

I think the best one could do now (for Squeeze) is to update the compatiblity
list in Youtube.pm with the old formats to be at least more consistent with
the manpage.

The interdiff would be rather small 

diff -u b/lib/clive/Host/Youtube.pm b/lib/clive/Host/Youtube.pm
--- b/lib/clive/Host/Youtube.pm
+++ b/lib/clive/Host/Youtube.pm
@@ -118,6 +118,11 @@
         mp4   => "18",
         hq    => "35",
         hd    => "22",
+       fmt22 => "22",
+       fmt35 => "35",
+       fmt18 => "18",
+       fmt34 => "34",
+       fmt17 => "17",
     );
 
     foreach (keys %h)

maybe this can be added in a Squeeze point release in case it's too late now.
At least my guess would be that the release team currently has better things
to do ...

Updated fix-606540-youtube.patch attached.

Sven
-- 
And I don't know much, but I do know this:
With a golden heart comes a rebel fist.
     [ Streetlight Manifesto - Here's To Life ]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-606540-youtube.patch
Type: text/x-diff
Size: 4460 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20110125/c4df17a2/attachment.patch>