Bug#629302: libnet-pcap-perl: produces empty package when built on experimental with perl 5.14

[Niko Tyni]

clone 629302 -1
tags 629302 patch
retitle -1 produces empty package when libpcap detection fails
severity -1 normal
user debian-perl at lists.debian.org
usertags -1 - perl-5.14-transition
thanks

On Sun, Jun 05, 2011 at 01:35:59PM +0100, Dominic Hargreaves wrote:
> Source: libnet-pcap-perl
> Version: 0.16-2
> Severity: important
> User: debian-perl at lists.debian.org
> Usertags: perl-5.14-transition
> 
> Rebuilding this package on experimental with 5.14 produces an empty
> package:

> looking for -lpcap... no

> drwxr-xr-x root/root         0 2011-06-05 13:20 ./
> drwxr-xr-x root/root         0 2011-06-05 13:20 ./usr/
> drwxr-xr-x root/root         0 2011-06-05 13:20 ./usr/share/
> drwxr-xr-x root/root         0 2011-06-05 13:20 ./usr/share/doc/
> drwxr-xr-x root/root         0 2011-06-05 13:20 ./usr/share/doc/libnet-pcap-perl/
> -rw-r--r-- root/root      3558 2008-01-01 04:02 ./usr/share/doc/libnet-pcap-perl/changelog.gz
> drwxr-xr-x root/root         0 2011-06-05 13:20 ./usr/share/doc/libnet-pcap-perl/examples/
> -rw-r--r-- root/root      2330 2008-01-01 09:12 ./usr/share/doc/libnet-pcap-perl/examples/pcapdump.gz
> -rw-r--r-- root/root      1093 2008-01-01 09:12 ./usr/share/doc/libnet-pcap-perl/examples/pktdump.pl
> -rw-r--r-- root/root      1777 2011-06-05 13:20 ./usr/share/doc/libnet-pcap-perl/copyright
> -rw-r--r-- root/root      1622 2011-06-05 13:20 ./usr/share/doc/libnet-pcap-perl/changelog.Debian.gz

This only happens on i386, and it's an instance of #628522:
modules setting CCFLAGS in Makefile.PL have always been overriding
$Config{ccflags}, dropping things like -D_FILE_OFFSET_BITS=64, but with
Perl 5.14 on i386 this actually happens to break them.

In the Net::Pcap case this breakage gets hidden quite well: Makefile.PL
is creating a test distribution in .testlink/ to test libpcap linkage,
and its test suite is failing due to the CCFLAGS issue.

We haven't had upstream opinion on #628522 yet, but I suspect the outcome
is that modules setting CCFLAGS should append them to $Config{ccflags}
themselves.

I'm attaching a patch but cloning another bug for the fact that the
Debian build creates an empty package instead of failing to build if
libpcap isn't detected.

(Please note that this is currently hard to test with perl_5.14.0-1 from
 experimental because it suffers from #630399: /usr/lib/<triplet> is missing
 from its $Config{libpth} and it can't find the multiarchified libpcap.
 I've tested the patch with a self built perl until we can get a fixed one
 in experimental.)
-- 
Niko Tyni   ntyni at debian.org