Bug#654899: libarchive-zip-perl: jh_manifest from javahelper creates corrupt archives (jars)

[gregor herrmann]

On Tue, 21 Feb 2012 19:43:06 +0200, Niko Tyni wrote:

> > #   Failed test 'output zip isn't corrupted'
> > #   at t/17_bug_73797.t line 26.
> > #          got: '-1'
> > #     expected: '0'
> > # Looks like you failed 1 test of 4.
> > t/17_bug_73797.t .............. 
> > Dubious, test returned 1 (wstat 256, 0x100)
> 
> > Aha, seems like tests (not only in this file) are skipped if there is
> > no unzip program around.
> Hm, the new test should have been skipped too.

Hm, yes, but :)
 
> > Next step: now testZip() tries to run `unzip -t testin.zip' (instead
> > of testout.zip). Plain test output:
> > 
> > warning: unzip -t  doesn't seem to work, may skip some tests at t/common.pl line 200.
> > Label not found for "last SKIP" at /usr/share/perl/5.14/Test/More.pm line 1256.
> > # Looks like your test exited with 9 just after 4.
> > t/17_bug_73797.t .............. 
> 
> It looks like it needs the 'zip' package. 

Nice catch!

> No idea why exactly though.

Ah, the constant ZIP is used in the pre-ultimate BEGIN block in
t/common.pl. I could have seen this myself before when I threw
debug statements into the file ...
Is this run before HAVEZIP is defined? Somehow these multiple BEGIN
blocks confuse me. Or is it that it messes with something else?


Ok, building with unzip + zip packages ... and all tests (are run
and) pass!

I'm pushing the change (adding zip) now but wait with an upload until
tomorrow, in case someone wants to take a look at this weird test
suite.


Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Status Quo: Break The Rules
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20120221/74366f54/attachment.pgp>