Bug#654899: libarchive-zip-perl: jh_manifest from javahelper creates corrupt archives (jars)

[Niko Tyni]

On Tue, Feb 21, 2012 at 11:17:28PM +0100, gregor herrmann wrote:

> > > warning: unzip -t  doesn't seem to work, may skip some tests at t/common.pl line 200.
> > > Label not found for "last SKIP" at /usr/share/perl/5.14/Test/More.pm line 1256.
> > > # Looks like your test exited with 9 just after 4.
> > > t/17_bug_73797.t .............. 

> Ah, the constant ZIP is used in the pre-ultimate BEGIN block in
> t/common.pl. I could have seen this myself before when I threw
> debug statements into the file ...
> Is this run before HAVEZIP is defined? Somehow these multiple BEGIN
> blocks confuse me. Or is it that it messes with something else?

I see it now: the problem is that INPUTZIP is not created at all if
/usr/bin/zip is not present, so the testZip() invocation from the last
BEGIN {} block of t/common.pl fails.

As for the "last SKIP" thing, t/17_bug_73797.t is missing a SKIP: {}
block around the last test. My fault, sorry.

> Ok, building with unzip + zip packages ... and all tests (are run
> and) pass!

I suppose that's enough. As long as the test suite is working for
us with the right build dependencies, we don't really have to iron out
every last wrinkle. I probably won't in any case...
-- 
Niko