Bug#661549: libyaml-syck-perl: FTBFS with hardening flags enabled: -Werror=format-security
dom at earth.li
Mon Feb 27 21:45:28 UTC 2012
User: debian-qa at lists.debian.org
Usertags: hardening-format-security hardening
With hardening flags enabled, this package FTBFS:
perl_common.h: In function 'perl_syck_error_handler':
perl_common.h:79:9: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'int' [-Wformat]
perl_common.h:79:9: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: some warnings being treated as errors
(this is the first error of this type seen: it's possible that there
could be others once this is fixed).
A likely fix is to change croak(var) to croak("%s", var), or similar.
Note that I haven't verified whether an externally-controlled string is
used; if so, it would be appropriate to upgrade this bug RC severity
with the security tag.
This was found during testing of perl 5.14.2-8 in experimental; however,
since that version was prepared, it has been decided not to export
those build flags in Config_heay.pl. Nevertheless, it is likely that at
some point, either in debhelper 9 or 10, the hardening flags will be
enabled for all perl modules.
Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)
More information about the pkg-perl-maintainers