Bug#633414: produces empty package when libpcap detection fails

[gregor herrmann]

Control: tag -1 + patch
# in git


On Sun, 19 May 2013 19:32:32 +0100, Dominic Hargreaves wrote:

> > I'm unable to reproduce this problem now (experimental + Perl-5.18 or
> > unstable + Perl-5.14)
> > Can you test another time ?
> The issue isn't reproducible at things stand because the immediate
> cause has been fixed. The attached patch reveals the problem, though.
> Note that I've changed the subject line of this email to the current
> title of the bug, to keep things clear.

Ack, that's still Not Nice.

I've committed a patch that does s/warn/die/g in Makefile.PL if
libpcap isn't found.

I vaguely remember that there are reasons on the CPAN side not to do
this but I doesn't seem too wrong for us.


Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Bob Dylan: Standing In The Doorway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20130521/6f61298e/attachment.pgp>