Bug#768748: Bug#768767: libchart-clicker-perl: FTBFS in jessie: Tests failures

[gregor herrmann]

# liblayout-manager-perl fails because of libgraphics-primitive-perl
Control: reassign 768748 libgraphics-primitive-perl 0.65-1
Control: affects 768748 liblayout-manager-perl

# libgraphics-primitive-driver-cairo-perl fails because of libgraphics-primitive-perl
Control: reassign 768713 libgraphics-primitive-perl 0.65-1
Control: affects 768713 libgraphics-primitive-driver-cairo-perl

# libchart-clicker-perl fails because of libgraphics-primitive-perl
Control: reassign 768767 libgraphics-primitive-perl 0.65-1
Control: affects 768767 libchart-clicker-perl

# merge the original libgraphics-primitive-perl bug and the 3 others
Control: merge 768683 768748 768713 768767



On Sun, 09 Nov 2014 11:03:43 +0100, Salvatore Bonaccorso wrote:

> On Sun, Nov 09, 2014 at 10:44:05AM +0100, Salvatore Bonaccorso wrote:
> > Just one data-point for now: Looking at the build log this looks to me
> > (at first glance) as a dependency problem in libmoosex-storage-perl. In
> > 0.48 upstream MooseX::Storage switched from JSON::Any to JSON::MaybeXS.
> Actually it looks all of #768767, #768735, #768713, #768683 and
> #768748 seem to have the same underlying cause from MooseX::Storage.

Thanks for the analysis.

What's interesting is that JSON::* was always in Recommends since
it's only needed in MooseX::Storage::Format::JSON ...

Interestingly,
http://codesearch.debian.net/search?q=MooseX%3A%3AStorage%3A%3AFormat
doesn't have any hits outside of libmoosex-storage-perl.

Looking at the five failing builds, we see in all:

#     Error:  Can't locate JSON/MaybeXS.pm in @INC (you may need to install the JSON::MaybeXS module) (@INC contains: /«PKGBUILDDIR»/blib/lib /«PKGBUILDDIR»/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.1 /usr/local/share/perl/5.20.1 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) at /usr/share/perl5/MooseX/Storage/Format/JSON.pm line 5.
# BEGIN failed--compilation aborted at /usr/share/perl5/MooseX/Storage/Format/JSON.pm line 5.
# Compilation failed in require at /usr/share/perl5/Module/Runtime.pm line 317.

So it seems that Module::Runtime now needs it, and this might be the
place to fix the problem?

OTOH, Module::Runtime has nothing about MooseX::Storage.


Ok, so back to the original failing packages:
libgraphics-primitive-perl and libgeometry-primitive-perl use
MooseX::Storage; the other three failures follow from there.

And both build-depend on libjson-any-perl; which doesn't help now
anymore ...


Since both don't request a specific MooseX::Storage::Format::*, it
seems that MooseX::Storage decides to use JSON ... which would
suggest that JSON::MaybeXS should be in Depends there. I still don't
see where this default (?) comes from though.


Ok, here we are:

lib/Graphics/Primitive/Canvas.pm:with Storage (format => 'JSON', io => 'File');
etc.

lib/Geometry/Primitive/Circle.pm:use MooseX::Storage;
t/010-serialize.t:my $arc2 = Geometry::Primitive::Arc->thaw($arc->freeze({ format => 'JSON' }), { format => 'JSON' });


So, my current summary is that we should fix
libgraphics-primitive-perl and libgeometry-primitive-perl.


Cheers,
gregor


-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Bob Dylan: Mr.Tambourine Man
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: Digital Signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20141112/6d120616/attachment-0008.sig>