Bug#742409: [Sereal] 2.06 fails to build on some architectures: (#47)

[demerphq]

On 26 September 2014 12:33, Niko Tyni <ntyni at debian.org> wrote:

> tag 742409 patch
> thanks
>
>
You are definitely my favourite person of the week. Thank you SO MUCH. I
stared at that source for hours looking for this, and I missed it every
time.


> On Wed, Sep 17, 2014 at 03:57:24PM +0200, demerphq wrote:
> > On 17 September 2014 07:52, Niko Tyni <ntyni at debian.org> wrote:
>
> > > So I suspect it's a general 64-bit big-endian problem.
>
> > I was under the impression that Jarkko got Sereal to work on big-endian
> 64
> > bit HPUX. But maybe I am wrong. Jarkko can you speak to that?
>
> Finally found it. Can't see how it could have worked on big endian
> 64 bit HPUX either as csnappy_internal_userspace.h seems to define
> __LITTLE_ENDIAN there too. But never mind.
>

Jarkko wasn't certain if we had made a 64 bit or 32 bit hpux big-endian
work, so I bet I was just wrong there.

But, does this mean there is something else we need to fix?


>
> Patch attached. This passes for me on both x86_64 and s390x.  I can test
> run it on the Debian buildds if you like but it seems straightforward?
>

Let me roll a new release and we can celebrate together a debian clean
build list.

This is really really awesome. Thank you again. I can't tell you how
pleased I am that this works on everything.

Yves


-- 
perl -Mre=debug -e "/just|another|perl|hacker/"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20140926/9b8ff1ff/attachment-0001.html>