Bug#834213: perlcritic: some code causes a perltidy.ERR file to be created or overwritten

[Salvatore Bonaccorso]

Hi

Just some comments:

I think perlcritic/perltidy is behaving here as documented. perlcritic
can use a specifified perlcriticrc file, which may have
check-all-the-things specific settings. In particular for the
Perl::Critic::Policy::CodeLayout::RequireTidyCode it might overwite
then as well the settings for perltidy.

If no configuration is specified for
Perl::Critic::Policy::CodeLayout::RequireTidyCode, then it uses the
default. By default for perltidy the following is true, cf.

       -se,    --standard-error-output
           If perltidy detects an error when processing file
           somefile.pl, its default behavior is to write error messages
           to file somefile.pl.ERR. Use -se to cause all error messages
           to be sent to the standard error output stream instead. This
           directive may be negated with -nse. Thus, you may place -se
           in a .perltidyrc and override it when desired with -nse on
           the command line.

One can argue that the default value is not a safe one, and rather
pertidy should by default should use -se, and only if overwritten to
write to a somefile.pl.ERR.

But if so, this would need to be changed upstream, and not diverged in
the Debian packaging.

Regards,
Salvatore