Bug#835447: libmodule-build-withxspp-perl: please make the output reproducible

[gregor herrmann]

On Thu, 25 Aug 2016 20:10:48 +0100, Chris Lamb wrote:

> Whilst working on the Reproducible Builds effort [0], I noticed that
> libmodule-build-withxspp-perl was causing packages to not build
> reproducibly (eg. libboost-geometry-utils-perl).
> 
> Patch attached.

The patch lacks headers or a commit message :)
For forwarding it upstream it would be good to have a description of
the problem and the solution.
 
> @@ -228,11 +229,11 @@ MODULE = $module_name	PACKAGE = $module_name
>  HERE
>  
>    my $typemap_args = '';
> -  $typemap_args .= '-t "' . _naive_shell_escape(Cwd::abs_path($_)) . '" ' foreach keys %$xspt_files;
> +  $typemap_args .= '-t "' . _naive_shell_escape(File::Spec->abs2rel($_, $this->build_dir)) . '" ' foreach keys %$xspt_files;
>  
>    foreach my $xsp_file (keys %$xsp_files) {
> -    my $full_path_file = _naive_shell_escape( Cwd::abs_path($xsp_file) );
> -    my $cmd = qq{INCLUDE_COMMAND: \$^X -MExtUtils::XSpp::Cmd -e xspp -- $typemap_args "$full_path_file"\n\n};
> +    my $relative_path_file = _naive_shell_escape( File::Spec->abs2rel($xsp_file, $this->build_dir) );
> +    my $cmd = qq{INCLUDE_COMMAND: \$^X -MExtUtils::XSpp::Cmd -e xspp -- $typemap_args "$relative_path_file"\n\n};
>      $xs_code .= $cmd;
>    }

I assume the problem that the full (and thereby arbitrary/random)
path is includeded/used somewhere and your patch changes this to a
path relative to the build directory. Is this correct?  


Cheers,
gregor

-- 
 .''`.  Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Aimee Mann: Red Vines
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 931 bytes
Desc: Digital Signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20160825/73732e26/attachment-0001.sig>