Bug#814479: libbusiness-creditcard-perl: New upstream version 0.35 (including new MasterCard ranges)

Ivan Kohler ivan-debian at 420.am
Tue Jun 7 23:09:21 UTC 2016


On Tue, Jun 07, 2016 at 10:18:08PM +0200, gregor herrmann wrote:
> On Tue, 07 Jun 2016 12:12:42 -0700, Ivan Kohler wrote:
> 
> I absolutely agree that every functional change needs to be included;
> but not the noise from build tools and unrelated changes in the
> documentation.
> 
> [...]
> 
>  
> And to speed this all up a bit :) I've pushed a jessie branch to our
> git repo:
> https://anonscm.debian.org/cgit/pkg-perl/packages/libbusiness-creditcard-perl.git/log/?h=jessie
> where I left out the non-functional changes and split the rest into
> three logical patches.
> 
> What do you think? If this looks okay to you I'm happy to proceed.

Well, only since you asked, it seems to me if you're going to include 
completely every single functional / code change in 0.35, it *is* 0.35 
and you should honestly declare $VERSION to be 0.35.  Stripping out some 
docs and unused metadata doesn't seem to me to make it 0.33 + 
selectively backported fixes.  This is really just a (very slightly 
riskier) repackaging of 0.35.

Outside of going through these contortious for our release management, a 
dependency or person that wants to check the verison wants to know what 
verison the *code* came from, not whether or not the copyright year or a 
bouncing email address are in the docs are from 0.33...

But the most important thing by far is just getting it fixed so 
transactions don't fail, so if making it a fake 0.33 is what works, then 
yeah, that's a whole lot better than not doing it.

-- 
_ivan



More information about the pkg-perl-maintainers mailing list