Bug#823708: dh-make-perl: parse failure if d/control contains comments

Sean Whitton spwhitton at spwhitton.name
Sat May 7 23:34:54 UTC 2016


Hello,

On Sun, May 08, 2016 at 01:29:25AM +0200, gregor herrmann wrote:
> then this test fails, because the written control "file" differs from
> the read one; unsurprisingly, since the comment is missing.
> 
> One can argue that being able to read d/control with comments is an
> improvement even if writing (on refresh e.g.) them swallows them [...]

Yes, that's the argument I had in mind.  To extend it: most packages are
now in git so if the dh-make-perl swallows some comments the user wanted
to retain, they would be likely to see it before committing.

The control file parsing already fails to record the order of the fields
in the control file.  This kind of parsing doesn't capture information
like comments.  That's how it should be, so there's no ideal solution
here.  I think this patch is the best we are going to get.

-- 
Sean Whitton
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20160507/d90c3c79/attachment-0001.sig>


More information about the pkg-perl-maintainers mailing list