Bug#838089: libconfig-crontab-perl: check for crontab(1) seems broken and unnecessary

Niko Tyni ntyni at debian.org
Sat Sep 17 10:25:36 UTC 2016


Package: libconfig-crontab-perl
Version: 1.41-1
Severity: minor
Tags: upstream

The test suite gets totally skipped for me with the message
"no crontab available".

It looks like this refers to the crontab(1) command rather than a user
crontab file. From t/setup.pl:

  sub have_crontab {
      eval 'system("crontab -l 2>/dev/null")';
      return ($? >> 8 == 1);
  }

The documentation for crontab(1) doesn't specify the exit code, but it
looks like it returns 0 if the user has a crontab file and 1 if not.
So the test suite gets skipped for users with a crontab file, which
doesn't seem to be the intention.

Background for the check seems to be testing for Windows:
  https://rt.cpan.org/Public/Bug/Display.html?id=59578

Furthermore, the crontab(1) command is apparently not used by the actual
tests, only for the check, so the check seems doubly useless for us. I
intend to patch it away for now.
-- 
Niko Tyni   ntyni at debian.org



More information about the pkg-perl-maintainers mailing list