[Pkg-phototools-devel] Bug#526183: FTBFS with GCC 4.4: missing #include

[Martin Michlmayr]

Package: hugin
Version: 0.7.0-2
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-4.4
Tags: patch

Your package fails to build with GCC 4.4, which has cleaned up some more
C++ headers.  You always have to #include headers directly and cannot
rely for things to be included indirectly.

You can reproduce this problem with gcc-snapshot from unstable or
gcc-4.4 from experimental.

> Automatic build of hugin_0.7.0-2 on em64t by sbuild/amd64 0.53
...
> [ 35%] Building CXX object src/hugin_base/CMakeFiles/huginbase.dir/appbase/ProgressDisplay.o
> [ 35%] Building CXX object src/hugin_base/CMakeFiles/huginbase.dir/appbase/ProgressDisplayOld.o
> /build/tbm/hugin-0.7.0/src/hugin_base/appbase/ProgressDisplayOld.cpp: In member function 'virtual void AppBase::StreamMultiProgressDisplay::updateProgressDisplay()':
> /build/tbm/hugin-0.7.0/src/hugin_base/appbase/ProgressDisplayOld.cpp:214: error: 'snprintf' was not declared in this scope
> /build/tbm/hugin-0.7.0/src/hugin_base/appbase/ProgressDisplayOld.cpp:220: error: 'snprintf' was not declared in this scope
> /build/tbm/hugin-0.7.0/src/hugin_base/appbase/ProgressDisplayOld.cpp:224: error: 'snprintf' was not declared in this scope
> make[3]: *** [src/hugin_base/CMakeFiles/huginbase.dir/appbase/ProgressDisplayOld.o] Error 1
> make[3]: Leaving directory `/build/tbm/hugin-0.7.0/build-dir'

--- src/hugin_base/appbase/ProgressDisplayOld.cpp~	2009-04-29 17:31:55.000000000 +0000
+++ src/hugin_base/appbase/ProgressDisplayOld.cpp	2009-04-29 17:32:03.000000000 +0000
@@ -27,6 +27,8 @@
 #define snprintf _snprintf
 #endif
 
+#include <cstdio>
+
 namespace AppBase {
     
     
--- src/hugin_base/panodata/PTScriptParsing.cpp~	2009-04-29 17:48:15.000000000 +0000
+++ src/hugin_base/panodata/PTScriptParsing.cpp	2009-04-29 17:48:21.000000000 +0000
@@ -26,6 +26,8 @@
 
 #include <hugin_utils/utils.h>
 
+#include <cstdio>
+
 
 namespace HuginBase {
 namespace PTScriptParsing {
--- src/hugin_base/hugin_utils/utils.cpp~	2009-04-29 17:34:03.000000000 +0000
+++ src/hugin_base/hugin_utils/utils.cpp	2009-04-29 17:34:13.000000000 +0000
@@ -30,7 +30,7 @@
     #include <sys/time.h>
 #endif
 #include <time.h>
-#include <stdio.h>
+#include <cstdio>
 
 
 namespace hugin_utils {

-- 
Martin Michlmayr
http://www.cyrius.com/