[Pkg-phototools-devel] Bug#857175: Please do NOT enable SSE on i386

[Laurent Bigonville]

Source: pngquant
Version: 2.3.0-1
Severity: serious
Tags: patch

Hi,

SSE support is only allowed on the amd64 architecture.

The debian/rules file is checking that the build machine is supporting
SSE or not, this is wrong.

Please see attached patch built against 2.5.0-1. Note that 2.3.0-1
(current stable is impacted as well).

Regards,

Laurent Bigonville

-- System Information:
Debian Release: 9.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
diff -Nru pngquant-2.5.0/debian/rules pngquant-2.5.0/debian/rules
--- pngquant-2.5.0/debian/rules	2015-07-27 09:54:49.000000000 +0200
+++ pngquant-2.5.0/debian/rules	2017-03-08 16:06:54.000000000 +0100
@@ -1,6 +1,11 @@
 #!/usr/bin/make -f
 
-SSEFLAG=$(shell if grep -q "^flags.*sse" /proc/cpuinfo ; then echo "--enable-sse" ; else echo "--disable-sse" ; fi)
+# disable sse2 except on amd64
+ifneq ($(DEB_HOST_ARCH_CPU),amd64)
+SSEFLAG := --disable-sse
+else
+SSEFLAG := --enable-sse
+endif
 
 %:
 	dh $@