[Pkg-phototools-devel] Bug#889172: entangle: Please link libentangle_backend against libgstbase

[Steve Langasek]

Package: entangle
Version: 0.7.2-1
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu bionic ubuntu-patch

Dear maintainers,

The latest entangle package is failing to build in Ubuntu, because
libentangle_backend uses functions from libgstbase-1.0 but does not link
against it explicitly.  The build succeeds in Debian, but fails in Ubuntu
where we use more strict linker defaults, as described at
<https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wl.2C--no-copy-dt-needed-entries>.

The attached patch has been applied to the package in Ubuntu and should be
upstreamable.  Please consider applying this patch in Debian as well.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru entangle-0.7.2/debian/patches/fix-gst-underlinking.patch entangle-0.7.2/debian/patches/fix-gst-underlinking.patch
--- entangle-0.7.2/debian/patches/fix-gst-underlinking.patch	1969-12-31 16:00:00.000000000 -0800
+++ entangle-0.7.2/debian/patches/fix-gst-underlinking.patch	2018-02-02 14:03:27.000000000 -0800
@@ -0,0 +1,40 @@
+Description: fix build failure with --no-add-needed
+ entangle 0.7.2 fails to build in Ubuntu because entangle_backend uses
+ libgstbase but does not directly link to it.
+Author: Steve Langasek <steve.langasek at ubuntu.com>
+
+Index: entangle-0.7.2/configure.ac
+===================================================================
+--- entangle-0.7.2.orig/configure.ac
++++ entangle-0.7.2/configure.ac
+@@ -85,6 +85,10 @@
+ AC_SUBST(GTK_CFLAGS)
+ AC_SUBST(GTK_LIBS)
+ 
++PKG_CHECK_MODULES([GST_BASE], [gstreamer-base-1.0 >= $GST_REQUIRED])
++AC_SUBST(GST_BASE_CFLAGS)
++AC_SUBST(GST_BASE_LIBS)
++
+ PKG_CHECK_MODULES([GST], [gstreamer-1.0 >= $GST_REQUIRED])
+ AC_SUBST(GST_CFLAGS)
+ AC_SUBST(GST_LIBS)
+Index: entangle-0.7.2/src/Makefile.am
+===================================================================
+--- entangle-0.7.2.orig/src/Makefile.am
++++ entangle-0.7.2/src/Makefile.am
+@@ -154,6 +154,7 @@
+ 	$(GTHREAD_LIBS) \
+ 	$(GDK_PIXBUF_LIBS) \
+ 	$(GST_LIBS) \
++	$(GST_BASE_LIBS) \
+ 	$(GST_PLUGINS_BASE_LIBS) \
+ 	$(GPHOTO2_LIBS) \
+ 	$(LCMS2_LIBS) \
+@@ -171,6 +172,7 @@
+ 	$(GTHREAD_CFLAGS) \
+ 	$(GDK_PIXBUF_CFLAGS) \
+ 	$(GST_CFLAGS) \
++	$(GST_BASE_CFLAGS) \
+ 	$(GST_PLUGINS_BASE_CFLAGS) \
+ 	$(GPHOTO2_CFLAGS) \
+ 	$(LCMS2_CFLAGS) \
diff -Nru entangle-0.7.2/debian/patches/series entangle-0.7.2/debian/patches/series
--- entangle-0.7.2/debian/patches/series	1969-12-31 16:00:00.000000000 -0800
+++ entangle-0.7.2/debian/patches/series	2018-02-02 13:59:40.000000000 -0800
@@ -0,0 +1 @@
+fix-gst-underlinking.patch