[php-maint] [Pkg-php-pear] RFS: php-net-smtp (updated package)

[Guillaume Delacour]

Le vendredi 26 novembre 2010 à 16:10 +0000, Adam D. Barratt a écrit :
> On Sat, 2010-11-27 at 00:04 +0800, Thomas Goirand wrote:
> > On 11/26/2010 10:48 PM, Guillaume Delacour wrote:
> > > I have modified the package to include Pre-Depends as discussed on
> > > debian-release and add little improvments (but not much, don't want to
> > > introduce something else), please find attached my proposal as a debdiff
> > > attached (commit in the svn will be done when the package will be
> > > uploaded in the archive). The package is also on mentors.
> > 
> > I had a look, and I could see in your debian/changelogs:
> > 
> >     + Bump debhelper compatibility to version 7 (+ debian/compat)
> >   * debian/rules: switch "dh_clean -k" to dh_prep
> > 
> > The RT has explicitly said that now isn't the time to do this kind of
> > change. Please revert and reupload to mentors.
> 
> Indeed; thanks.  Apologies if it already was, and I simply missed it,
> but new Pre-Depends are also supposed to be raised on
> debian-devel at lists.d.o ; I'd imagine this case wouldn't be particularly
> controversial, but it would be good to check. :)

Rollbacked and reuploaded on mentors (and debdiff from 1.4.2-2 to
1.4.2-3 attached).

> 
> > Also, Adam talked about some things needed in a postinst to deal with
> > the doc folder if it's not there yet. Do you know what this is about? I
> > didn't have a look at the debian-release list, but I can't see any
> > postinst script in your package.
> 
> It was the preinst, and as an altervative to the Pre-Depends.  If you're
> using the Pre-Depends then everything should just work[tm].
> 
> Regards,
> 
> Adam
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: php-net-smtp.diff
Type: text/x-patch
Size: 1295 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-maint/attachments/20101126/18da731f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Ceci est une partie de message num?riquement sign?e
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-maint/attachments/20101126/18da731f/attachment.pgp>