[php-maint] Alioth group membership / git access

[Thomas Goirand]

On 10/18/2010 08:52 AM, John Morrissey wrote:
> On Sun, Oct 17, 2010 at 11:24:08PM +0800, Thomas Goirand wrote:
>> I just wanted to let you know that I WILL review the above.
> 
> No worries, thanks for the update.
> 
> I went to my first DebConf recently (New York) and was looking for more ways
> to be involved with Debian, so it's not like these packages are urgent. :-)
> 
> john

I've finished upgrading, it wasn't smooth at all in my case, as I had so
many broken dependencies due to home-made backports, etc. But at the
end, I'm VERY happy with Squeeze! :)

Let's start the review.

Generally speaking, I like debian/copyright using the machine parsable
format. It's still a draft, but I think it's nice:

http://wiki.debian.org/Proposals/CopyrightFormat/Archive

That's not an obligation though (debian/copyright are traditionally a
mess / using a free format (take your pick)). I just want to point it to
you for future enhancements. If you can use that format for future
uploads, that'd be great.

A/ php-crypt-blowfish:
----------------------
1/ litian checks

When running lintian -I php-crypt-blowfish_1.1.0rc2-1_amd64.changes:
E: php-crypt-blowfish source: unknown-source-format 1
W: php-crypt-blowfish source: debhelper-but-no-misc-depends
php-crypt-blowfish
W: php-crypt-blowfish source: dh-clean-k-is-deprecated

Please fix the above. Run lintian with -Ii if you want full
explanations: lintian explains most of the time better than me. :)

2/ debian/watch

You souldn't incude "RC" in it, as the upstream author might release a
new version with these letters in it.

3/ debian/copyright

It'd be nice to explicitly state that it's using the BSD license.

4/ debian/control

Even if you don't use it yet, you can add the following:

Vcs-Browser: http://git.debian.org/?p=pkg-php/php-crypt-blowfish.git
Vcs-Git: http://git.debian.org/git/pkg-php/php-crypt-blowfish.git

as it will be there {at the,after} the upload.

Please use section "PHP" and not web, and add a ${misc:Depends}.

5/ debian/rules

* You don't need a configure target, please remove it if it isn't needed.
* Put the get-orig-source on top, and add it to the .PHONY list.
* You are using dh_installdirs, but not dh_links. I think it lacks
consistency, IMHO (that's not important, it's just a quick remark).

B/ php-net-dns
First, this sounds like a cool PHP module! :)

1/ lintian

Same. You got some lintian errors.

2/ debian/watch

Same remark.

3/ debian/copyright

There's not even an email address of the author... Yet, in
Net_DNS-1.0.5/Net/* I found some. Please list them all, each author
attached to it's author file. Some of the copyright holder are NOT the
PHP group, which isn't what is said in your debian/copyright. Plus I
could read:

* The majority of this is _NOT_ my code.  I simply ported it from the
* PERL Net::DNS module.
*
* The author of the Net::DNS module is Michael Fuhr <mike at fuhr.org>
* http://www.fuhr.org/~mfuhr/perldns/

this should be stated, and you should research under what license that
Net::DNS perl module was, and talk about it.

4/ debian/rules

Same, you don't need a configure target, get-orig-source: target should
be in .PHONY, etc.

5/ debian/control

Same, section is wrong, misc_depends is missing.

C/ php-services-weather

This is a CDBS package, I don't review / sponsor them, sorry (I don't
have enough knowledge to understand all the "magic" behind CDBS, and my
point of view with CDBS is that nobody does except the author of CDBS).

But having a quick look, your package has the same issues as the other
ones above (misc_depends, etc), plus it depends on debhelper 5 which is
surprising.

Let me know when you have corrected *all* the above, and when I can
review the packages again.

Thomas Goirand (zigo)