[php-maint] Alioth group membership / git access

[John Morrissey]

On Mon, Oct 18, 2010 at 11:07:51AM -0400, John Morrissey wrote:
> On Mon, Oct 18, 2010 at 05:31:04PM +0800, Thomas Goirand wrote:
> > Generally speaking, I like debian/copyright using the machine parsable
> > format. It's still a draft, but I think it's nice:
> >
> > http://wiki.debian.org/Proposals/CopyrightFormat/Archive
[snip]
> > 3/ debian/copyright
> >
> > There's not even an email address of the author... Yet, in
> > Net_DNS-1.0.5/Net/* I found some. Please list them all, each author
> > attached to it's author file.
>
> Also, the only copyright notice in Net_DNS is for Eric Kilfoil
> <eric at ypass.net>. Those who have worked on the PEAR module are listed as
> "maintainers." Should I keep the single 'Upstream Authors' section in
> debian/copyright and list all of them, or make some distinction between
> those listed as "maintainers" and those who have an explicit copyright
> notice?

I've rewritten my packages' debian/copyright using this format, and find I
quite like it, too. It also does a good job handling my question re:
listing copyright holders vs. upstream authors.

> * You are using dh_installdirs, but not dh_links. I think it lacks
> consistency, IMHO (that's not important, it's just a quick remark).

dh_link only creates symlinks for files; it explicitly fails on directories.

I double-checked, and think I've addressed everything you've brought up in
this review. Let me know if there's anything else you notice, or anything
I've missed. Thanks.

http://horde.net/~jwm/debian/php-crypt-blowfish_1.1.0rc2-1.dsc
http://horde.net/~jwm/debian/php-net-dns_1.0.5-1.dsc
http://horde.net/~jwm/debian/php-services-weather_1.4.5-1.dsc

john
-- 
John Morrissey          _o            /\         ----  __o
jwm at horde.net        _-< \_          /  \       ----  <  \,
www.horde.net/    __(_)/_(_)________/    \_______(_) /_(_)__