[php-maint] Bug#652599: Bug#652599: Bug#652599: php5: use_embedded_timezonedb.patch causes ext/date/lib/parse_tz.c to fail to compile

Dominic Scheirlinck dominics at gmail.com
Wed Feb 1 03:01:49 UTC 2012


Two files attached (this time):

 * fix_use_embedded_timezonedb.patch is a patch that fixes the issue.
It acts directly on the .c file, and should be applied after
use_embedded_timezonedb.patch in the quilt series.
 * use_embedded_timezonedb.patch.patch is a patch for
use_embedded_timezonedb.patch. It acts on the original patch and fixes
it that way.

Dom

On Wed, Feb 1, 2012 at 1:36 PM, Ondřej Surý <ondrej at debian.org> wrote:
> severity 652599 wishlist
> thank you
>
> Ah, didn't catch that you are using modified build. In that case you
> are on your own,
> we only support our configure options and our build environment.
>
> But if you provide a clean patch to fix the issue, I'll apply it in
> the git and it will be part
> of some next release.
>
> O.
>
>
> On Tue, Jan 31, 2012 at 23:46, Dominic Scheirlinck <dominics at gmail.com> wrote:
>>> It compiles correctly for me
>>
>> Are you certain you had both the quilt patch applied and HAVE_SYSTEM_TZDATA undefined? What did you pass in for '--with-system-tzdata' to configure? Or did you unset HAVE_SYSTEM_TZDATA in some other way?
>>
>> I double-checked the state of the patched ext/date/lib/parse_tz.c in 5.3.9-5, and it appeared the same as in my original pastebin: the preprocessor directives are still in the same place. So, I don't understand how it could possibly work for you: it seems to produce invalid C from the preprocessor stage.
>>
>> To show that, here's another pastebin, this time the result of running gcc -E ext/date/lib/parse_tz.c, which should just do the preprocessing: http://paste.debian.net/154235/ - note the hanging else clause.
>>
>>> What is your build environment?
>>
>> # uname -a
>> Linux dominic-vm-lucid 2.6.32-36-server #79-Ubuntu SMP Tue Nov 8 22:44:38 UTC 2011 x86_64 GNU/Linux
>> # gcc -v
>> Target: x86_64-linux-gnu
>> […]
>> gcc version 4.4.3 (Ubuntu 4.4.3-4ubuntu5)
>>
>> What else would you like to know? I'm pretty sure this is unrelated to my environment. To be clear: I'm not saying it happens with a normal build (because most people building the package will want to use system TZ data), but it's still a bug that affects the few people (I assume) who don't.
>>
>> Dom
>>
>>
>> _______________________________________________
>> pkg-php-maint mailing list
>> pkg-php-maint at lists.alioth.debian.org
>> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-php-maint
>
>
>
> --
> Ondřej Surý <ondrej at sury.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: use_embedded_timezonedb.patch.patch
Type: application/octet-stream
Size: 377 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-maint/attachments/20120201/d9ec738c/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_use_embedded_timezonedb.patch
Type: application/octet-stream
Size: 473 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-maint/attachments/20120201/d9ec738c/attachment-0003.obj>


More information about the pkg-php-maint mailing list