[php-maint] 5.4.0~rc6-2 (in experimental) testers needed (packaging, not php5 yet)

Ondřej Surý ondrej at sury.org
Thu Feb 2 07:40:38 UTC 2012


Hi Sean,

On Thu, Feb 2, 2012 at 08:23, sean finney <seanius at debian.org> wrote:
> Heya,
>
> On Wed, Feb 01, 2012 at 09:54:14PM +0100, Ondřej Surý wrote:
>> I made a huge change in packaging the extensions by merging work by
>> Clint Byrum.  We talked about possibility of cooperation over new
>> extension manager some time ago and he came up with php5{en,dis}mod
>> script which I took (and bended).  So in the end the version in
>> experimental moves all conf.d files to /etc/php5/mods-available/ and
>> then enables them again.
>
> To be clear, this isn't raphael's work but instead an alternate
> implementation?  From reading the script it doesn't look like it
> covers the same feature set (per-sapi enabling, basically), though
> if we're going to ditch that idea then so be it...

We're not, but this approach is much simpler and doesn't break the existing
non-pkg-php packages (they can still use conf.d).

I.e.: We close the most annoying bugs: #447826, #582320, #627145, but
the #505743 is still open, and not break anything.

When I have asked Raphael about his extension manager last time
the answer was:

> > Code-wise, not really. It only has a few, hackish, shell scripts, and the
> > whole thing ought to be rewritten.

And I didn't have time to properly investigate at that time and I have probably
fixated on 'to be rewritten' at that time.

Now when I found the last email, I also found the code from Raphael, I
will think
about how to integrate it. I think we need to keep support for legacy packages
which install stuff into /etc/php5/conf.d/ directly.

> though probably would have been worth a quick discussion/ping imo...

Yes, it would, you're right here. My excuse is that I was in packaging
rage yesterday :)

But frankly when was the last time you or Raphael has touched the repo
last time? I have given up the hope :(.

> Also, debian/copyright should probably be updated, since canonical has
> claimed copyright on the script :)

Yeah, I need to speak with Clint about that yet.

>> There's one minor glitch - if you are upgrading it leaves
>> $extension.dpkg-new files in new directory, which is kind of
>> inconvenient, but I was unable to find (for now) why. We will need to
>> solve this before wheezy is out, so the users don't freak out (they
>> usually start bugfilling duplicate bugs if they freak out :)).
>
> It looks to me like we're still shipping the conffiles in their
> original location (/etc/php5/conf.d), instead of the new location,
> so this is actually pretty broken (good thing it's still in experimental :D )

No, we are not:

$ dpkg -c php5-mysqlnd_5.4.0~rc6-2_amd64.deb
[...]
-rw-r--r-- root/root        60 2012-02-01 18:52
./etc/php5/mods-available/pdo_mysql.ini
-rw-r--r-- root/root        57 2012-02-01 18:52
./etc/php5/mods-available/mysqli.ini
-rw-r--r-- root/root        56 2012-02-01 18:52
./etc/php5/mods-available/mysql.ini
-rw-r--r-- root/root        58 2012-02-01 18:52
./etc/php5/mods-available/mysqlnd.ini
[...]

> AIUI, you should ship the conffile in the new location when using the dpkg
> maintscript helper, which is only for migrating from the old location and
> not updating the dpkg package/conffile metadata.

Well, I think that Lior's hint about using ucf was good one. It just
seemed to me
that it would be too much, when I first though about that. But I'll
throw some magic
ucf dust over php5-module.*

O.
-- 
Ondřej Surý <ondrej at sury.org>



More information about the pkg-php-maint mailing list