<div dir="ltr"><div>Hi Ondrej.<br><br></div>It looks good. Thanks!<br><br></div><br><div class="gmail_quote"><div dir="ltr">El mié., 16 sept. 2015 a las 15:21, Ondřej Surý (<<a href="mailto:ondrej@sury.org">ondrej@sury.org</a>>) escribió:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Bernat,<br>
<br>
could you please review the patch? I have minified the changes, so it<br>
would be nice to have doublecheck if I haven't omitted anything.<br>
<br>
<a href="https://anonscm.debian.org/cgit/pkg-php/php.git/commit/?id=43e561ddda036a80ba3d566f00b3fb9741ca7c48" rel="noreferrer" target="_blank">https://anonscm.debian.org/cgit/pkg-php/php.git/commit/?id=43e561ddda036a80ba3d566f00b3fb9741ca7c48</a><br>
<br>
Cheers,<br>
Ondrej<br>
<br>
On Wed, Sep 16, 2015, at 13:11, Bernat wrote:<br>
> Package: php5-common<br>
> Version: 5.6.13+dfsg-0+deb8u1<br>
> Severity: normal<br>
> Tags: patch<br>
><br>
> Dear Maintainer,<br>
><br>
> I've observed that sessions have a short living no matter what the<br>
> session.gc_maxlifetime setting is.<br>
><br>
> I've debugged the sessionclean script and found that it never touches<br>
> the session files so they will be removed even when they're still in use<br>
> for the specified time.<br>
><br>
> The variable proc_names is set inside the while loop that is in a<br>
> pipelined command, thus the variable isn't updated outside the loop.<br>
><br>
> I've modified the script so everything up to the touch loop runs inside<br>
> the same subshell. Patch provided.<br>
><br>
> Best regards,<br>
> Bernat Arlandis<br>
><br>
> -- Package-specific info:<br>
> ==== Additional PHP 5 information ====<br>
><br>
> ++++ PHP 5 SAPI (php5query -S): ++++<br>
> cli<br>
> apache2<br>
><br>
> ++++ PHP 5 Extensions (php5query -M -v): ++++<br>
> xcache (Enabled for cli by maintainer script)<br>
> xcache (Enabled for apache2 by maintainer script)<br>
> mysql (Enabled for cli by maintainer script)<br>
> mysql (Enabled for apache2 by maintainer script)<br>
> curl (Enabled for cli by maintainer script)<br>
> curl (Enabled for apache2 by maintainer script)<br>
> opcache (Enabled for cli by maintainer script)<br>
> opcache (Enabled for apache2 by maintainer script)<br>
> readline (Enabled for cli by maintainer script)<br>
> readline (Enabled for apache2 by maintainer script)<br>
> pdo_sqlite (Enabled for cli by maintainer script)<br>
> pdo_sqlite (Enabled for apache2 by maintainer script)<br>
> mysqli (Enabled for cli by maintainer script)<br>
> mysqli (Enabled for apache2 by maintainer script)<br>
> intl (Enabled for cli by maintainer script)<br>
> intl (Enabled for apache2 by maintainer script)<br>
> gd (Enabled for cli by maintainer script)<br>
> gd (Enabled for apache2 by maintainer script)<br>
> json (Enabled for cli by maintainer script)<br>
> json (Enabled for apache2 by maintainer script)<br>
> pdo (Enabled for cli by maintainer script)<br>
> pdo (Enabled for apache2 by maintainer script)<br>
> pdo_mysql (Enabled for cli by maintainer script)<br>
> pdo_mysql (Enabled for apache2 by maintainer script)<br>
> mcrypt (Enabled for cli by maintainer script)<br>
> mcrypt (Enabled for apache2 by maintainer script)<br>
> sqlite3 (Enabled for cli by maintainer script)<br>
> sqlite3 (Enabled for apache2 by maintainer script)<br>
> xdebug (Enabled for cli by maintainer script)<br>
> xdebug (Enabled for apache2 by maintainer script)<br>
><br>
> ++++ Configuration files: ++++<br>
> **** /etc/php5/mods-available/pdo.ini ****<br>
> extension=pdo.so<br>
><br>
> **** /etc/php5/mods-available/opcache.ini ****<br>
> zend_extension=opcache.so<br>
><br>
><br>
> -- System Information:<br>
> Debian Release: 8.2<br>
> APT prefers stable-updates<br>
> APT policy: (500, 'stable-updates'), (500, 'stable')<br>
> Architecture: amd64 (x86_64)<br>
> Foreign Architectures: i386<br>
><br>
> Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)<br>
> Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8)<br>
> Shell: /bin/sh linked to /bin/dash<br>
> Init: systemd (via /run/systemd/system)<br>
><br>
> Versions of packages php5-common depends on:<br>
> ii libc6 2.19-18+deb8u1<br>
> ii lsof 4.86+dfsg-1<br>
> ii psmisc 22.21-2<br>
> ii sed 4.2.2-4+b1<br>
> ii ucf 3.0030<br>
><br>
> php5-common recommends no packages.<br>
><br>
> Versions of packages php5-common suggests:<br>
> ii php5-xcache [php5-user-cache] 3.2.0-1<br>
><br>
> Versions of packages php5-cli depends on:<br>
> ii libbz2-1.0 1.0.6-7+b3<br>
> ii libc6 2.19-18+deb8u1<br>
> ii libcomerr2 1.42.12-1.1<br>
> ii libdb5.3 5.3.28-9<br>
> ii libedit2 3.1-20140620-2<br>
> ii libgssapi-krb5-2 1.12.1+dfsg-19<br>
> ii libk5crypto3 1.12.1+dfsg-19<br>
> ii libkrb5-3 1.12.1+dfsg-19<br>
> ii libmagic1 1:5.22+15-2<br>
> ii libonig2 5.9.5-3.2<br>
> ii libpcre3 2:8.35-3.3<br>
> ii libqdbm14 1.8.78-5+b1<br>
> ii libssl1.0.0 1.0.1k-3+deb8u1<br>
> ii libxml2 2.9.1+dfsg1-5<br>
> ii mime-support 3.58<br>
> ii php5-json 1.3.6-1<br>
> ii tzdata 2015f-0+deb8u1<br>
> ii ucf 3.0030<br>
> ii zlib1g 1:1.2.8.dfsg-2+b1<br>
><br>
> Versions of packages php5-cli recommends:<br>
> ii php5-readline 5.6.13+dfsg-0+deb8u1<br>
><br>
> Versions of packages php5-cli suggests:<br>
> ii php-pear 5.6.13+dfsg-0+deb8u1<br>
><br>
> Versions of packages libapache2-mod-php5 depends on:<br>
> ii apache2 2.4.10-10+deb8u3<br>
> ii apache2-bin [apache2-api-20120211] 2.4.10-10+deb8u3<br>
> ii libbz2-1.0 1.0.6-7+b3<br>
> ii libc6 2.19-18+deb8u1<br>
> ii libcomerr2 1.42.12-1.1<br>
> ii libdb5.3 5.3.28-9<br>
> ii libgssapi-krb5-2 1.12.1+dfsg-19<br>
> ii libk5crypto3 1.12.1+dfsg-19<br>
> ii libkrb5-3 1.12.1+dfsg-19<br>
> ii libmagic1 1:5.22+15-2<br>
> ii libonig2 5.9.5-3.2<br>
> ii libpcre3 2:8.35-3.3<br>
> ii libqdbm14 1.8.78-5+b1<br>
> ii libssl1.0.0 1.0.1k-3+deb8u1<br>
> ii libstdc++6 4.9.2-10<br>
> ii libxml2 2.9.1+dfsg1-5<br>
> ii mime-support 3.58<br>
> ii php5-cli 5.6.13+dfsg-0+deb8u1<br>
> ii php5-json 1.3.6-1<br>
> ii tzdata 2015f-0+deb8u1<br>
> ii ucf 3.0030<br>
> ii zlib1g 1:1.2.8.dfsg-2+b1<br>
><br>
> Versions of packages libapache2-mod-php5 suggests:<br>
> ii php-pear 5.6.13+dfsg-0+deb8u1<br>
><br>
> -- no debconf information<br>
> _______________________________________________<br>
> pkg-php-maint mailing list<br>
> <a href="mailto:pkg-php-maint@lists.alioth.debian.org" target="_blank">pkg-php-maint@lists.alioth.debian.org</a><br>
> <a href="http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-php-maint" rel="noreferrer" target="_blank">http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-php-maint</a><br>
> Email had 1 attachment:<br>
> + sessionclean.patch<br>
> 3k (text/x-diff)<br>
<br>
<br>
--<br>
Ondřej Surý <<a href="mailto:ondrej@sury.org" target="_blank">ondrej@sury.org</a>><br>
Knot DNS (<a href="https://www.knot-dns.cz/" rel="noreferrer" target="_blank">https://www.knot-dns.cz/</a>) – a high-performance DNS server<br>
<br>
</blockquote></div>