[pkg-php-pear] Packaging Net:NNTP

[Thomas Goirand]

On 08/13/2011 01:36 PM, Jan-Pascal van Best wrote:
> Bonjour Thomas,
> 
> Yes, I'm a DM.
> 
> The new source location is
> http://www.vanbest.org/debian/unstable/php-net-nntp_1.4.0.dfsg-1~pre4.dsc
> 
> I had to remove a small file in the docs becaus it says explicitly 'all 
> rights reserved'. I've asked upstream to fix that,
> 
> I'll try not to update the next couple  of days so the url stays the
> same. In the next release, I'll update the maintainer address.
> 
> Kind regards
> 
> Jan-Pascal

Hi Jan-Pascal,

Here's a quick (maybe partial) review.

- It seems this package doesn't seem to be in Debian yet. Because of
that, your debian/changelog should have only a single entry:

* Initial Release (Closes: #390456).

- Since it has never been in Debian, you can use the "compat" level 8
for debhelper. Please update debian/compat and debian/control for that.

- Your debian/copyright only specifies upstream. It's common habits to
also list yourself, with something like:

Files: debian/*
Copyright: (c) 2011, Jan-Pascal van Best <janpascal at vanbest.org>
License: <choose one>

Since the author is using the W3C license, it would make sense to put
your packaging work with the same license as well.

- There's few lintian warning as well. One which is important is about
your version number. You called it 1.4.0.dfsg-1~pre4, lintian (and
myself) would suggest that rather, you call it: 1.4.0+dfsg-1~pre4.

- There's also 3 empty directories:
usr/share/doc/php-net-nntp/docs/examples/demo/
usr/share/php/.registry/.channel.doc.php.net/
usr/share/php/Net/NNTP/Protocol/

you got to fix that.

- Apart from these issues, the package seems clean, but since it is
using CDBS, I wouldn't sponsor it (I don't know enough about CDBS to
feel comfortable sponsoring). Note that if you were using a normal
debhelper system you could use dh_phppear from pkg-php-tools 0.5 which
is in unstable. With it, you can do a very nice control file like this:

Package: php-foo
Architecture: all
Depends: ${misc:Depends}, ${phppear:Debian-Depends}
Recommends: ${phppear:Debian-Recommends}
Breaks: ${phppear:Debian-Breaks}
Description: ${phppear:summary}
 ${phppear:description}

and dh_phppear does the necessary substitutions, which is very nice.

Thomas