[pkg-php-pear] Net:NNTP, new version for review

[Thomas Goirand]

On 08/17/2011 03:46 AM, Jan-Pascal van Best wrote:
> On 08/16/2011 01:00 PM, Jan-Pascal van Best wrote:
>> Hi all,
>>
>> Please have a look at the following package. It is based on the 1.5.0 RC
>> of Net:NNTP, which contains the requested change to the footer.inc.php
>> file.
>>
>> http://www.vanbest.org/debian/unstable/php-net-nntp_1.5.0~rc1-1.dsc
>>
>> Just one other change:
>> - Fix watch file to handle alpha (1.5.0a1), beta (1.5.0b2) and release
>> candidates (1.5.0RC1)
>>
>>   
> For the record, the package is now in Git on Alioth (pkg-php/php-net-nntp).
> 
> Jan-Pascal

Usually, we don't have a branch called "master", because it doesn't
express anything. Usually, what I do is having branches naming like this:

- upstream-sid
- debian-sid
- upstream-squeeze
- debian-squeeze

Of course, I would only create upstream-squeeze/debian-squeeze if the
SID version becomes different from the Squeeze one.

Can you modify your branch names and upload that to git.d.o?

Also, doing a traceroute to 2001:980:1d54:1::13 shows that
www.vanbest.org ipv6 connectivity is broken. It stops at
10gigabitethernet1-1.core1.ams1.he.net for me. The only way I could
download was editing my /etc/hosts file and add the ipv4 IP of your site
to it. I would suggest that you remove the IPv6 from your DNS if you
can't fix the connectivity.

As for the package itself, it looks ok. Just a small detail though, most
of the time, in the copyright, we'd write:

Copyright: (c) 2011, Jan-Pascal van Best <janpascal at vanbest.org>

instead of:

Copyright: Copyright 2011 Jan-Pascal van Best <janpascal at vanbest.org>

Please change that at least in your Git.

When I run: uscan --verbose --report

I can see:
Newest version on remote site is 1.5.0a1, local version is 1.5.0~rc1

so obviously, either your watch file is wrong, either there's a new
upstream version to package.

If there wasn't that last one, I would have probably sponsored the
package already. So please let me know.

Cheers, and thanks for the packaging effort, we're close to it now.

Thomas