[pkg-php-pear] Bug#656960: [RFR] - Multiple (4) PEAR packages needed by PHPUnit - Was: [RFR] - PHP_Timer (Needed by phpunit)

[Thomas Goirand]

On 04/09/2012 11:35 PM, Luis Uribe wrote:
> Hi,
> 
> On Fri, Mar 30, 2012 at 01:18:17AM +0800, Thomas Goirand wrote:
>> I had a look to that one. Your Git repository contains the branches:
> 
>> I (and I believe, others in the PEAR team) usually use:
>> - debian-sid
>> - upstream-sid
>> - debian-wheezy
>> - upstream-wheezy
>> - debian-squeeze
>> - upstream-squeeze
> 
> So debian-sid will be the branch with the debian package schema and
> upstream-sid the branch with the upstream code, right?

Right.

> You upload
> master-sid, that is the same debian-sid?

No, I have no master-sid branch at all. Just debian-sid / upstream-sid.

> I just try to build php-timer on a squeeze pbuilder but it fails: Needs
> the pkg-php-tools package that is not on stable but on backports, i will
> check it again later. Also i didn't create *squeeze branches yet.

You don't need squeeze branches at all, the package isn't in there (and
it will never be there...). Just debian-sid / upstream-sid for now. When
it migrates to wheezy, you can create 2 branches for it.

>> Many of your files (for example, debian/control, debian/copyright,
>> debian/rules, but their might be others) are missing a \n (eg: new line)
>> at the end of file. It'd be great if you could fix it, it's really
>> annoying when I do "cat debian/control" and then I have my shell prompt
>> displayed in an ugly way.
> 
> Corrected (for this package)

Cool.

>> I've seen that your debian/rules, after override_dh_install, is removing
>> files manually. Shouldn't the pkg-php-tools do that work instead of you
>> manually? Is this really needed? If so, then maybe we should consider
>> changing pkg-php-tools so that it can handle channels in a better way
>> (it seems to be a trivial change to me). Note that I'm writing here in a
>> very open mind way, with the will to make things better and easier (and
>> as a team).
> 
> There is also a [1]bug regarding that, but i couldn't check
> pkg-php-tools code yet. And i think my perl-foo is not enought to make
> that change easily. That's why i shipped the package with some overrides 
> 
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=656960
> 
> Cheers

I'm not good with perl either. I think it's gona be fine with your
overrides then.

Should I try any of the packages again now? Should I pull from Alioth?

Thomas