[pkg-php-pear] Ask for permission -- your PEAR packages

Thomas Goirand zigo at debian.org
Thu May 30 02:25:56 UTC 2013


Hi Prach!

Thanks for your work on these packages.

On 05/30/2013 02:21 AM, Prach Pongpanich wrote:
> On Sun, May 26, 2013 at 8:38 PM, Thomas Goirand <zigo at debian.org> wrote:
>> On 05/26/2013 07:39 PM, Prach Pongpanich wrote:
>>> Hi Thomas,
>>>
>>> I see lots of new upstream version in your PEAR packages, I would like
>>> to help you packaging a new upstream version and fix the bug.
>>> Can I do that and add myself as uploader?
>>>
>>> Regrads,
>>
>> Hi,
>>
>> Please go ahead!
>>
> Hi Thomas,
> 
> Ready for uploads:
> 
> http://anonscm.debian.org/gitweb/?p=pkg-php/php-mail-mime.git

This one produces some errors in the unit testings:

1) headers_with_mbstring.phpt
--- Expected
+++ Actual
@@ @@
 [28] From: "John Doe" <test at domain.com>
-[29] Mail-Reply-To: "adresse at adresse.de" <addresse at adresse>
-[29] Mail-Reply-To: "adresse at adresse.de" <addresse at adresse>
-[30] Mail-Reply-To: =?UTF-8?B?w7bDpMO8?= <adresse at adresse.de>
-[30] Mail-Reply-To: =?UTF-8?Q?=C3=B6=C3=A4=C3=BC?= <adresse at adresse.de>
+[29] Mail-Reply-To: adresse at adresse.de <addresse at adresse>
+[29] Mail-Reply-To: adresse at adresse.de <addresse at adresse>
+[30] Mail-Reply-To: =?UTF-8?B?IsO2w6TDvCIgPGFkcmVzc2VAYWRyZXNzZS5kZT4=?=
+[30] Mail-Reply-To:
=?UTF-8?Q?=22=C3=B6=C3=A4=C3=BC=22_=3Cadresse=40adresse=2E?=
+ =?UTF-8?Q?de=3E?=

> http://anonscm.debian.org/gitweb/?p=pkg-php/php-mdb2.git

This one is uploaded.

> http://anonscm.debian.org/gitweb/?p=pkg-php/phpunit.git

Why did you just drop all patches? At least the patch which removes the
LICENSE file from package.xml is needed.

Then, why did you drop debian/patches/Removes-YUI-repport?

I believe that you removed debian/patches/01_channel.patch, since there
is a specific channel package for it, right? If so, that's fine.

Another problem: phpunit declares a dependency on PHPUnit_MockObject
(version >= 1.2.0, version <= 1.2.99), though we have only 1.1.1-2 in
Debian. Same with php-symfony-yaml (version >= 2.0.0, version <=
2.99.99) and we have only 1.0.6-1 in Debian. The above dependencies
should be solved first, before uploading a new version of php-unit.

Also, how did you test the new phpunit package? Did you try to rebuild
(at least) some of the PEAR packages which depend on phpunit, for example?

Also, your package doesn't produce a phpunit.reg, but it produces a
channel.xml file in /usr/share/.registry/.channel.pear.phpunit.de.

All the above shows that you are not paying enough attention. Please do,
otherwise it's hell to fix things afterward (especially the file
conflict you've created with the .registry thing). Also, phpunit is a
build dependency of many PEAR packages (since I did that work on the
previous Debian release cycle), so we got to be very careful with it.

> You do much work on the openstack-devel.

Yeah! If you didn't noticed, I uploaded python-heatclient (it's
currently in the NEW queue).

> I continue to do this and I'll reply you later. :)

Ok.

Please next time, write to the list, and not to me. Things in Debian are
better in public, as others can learn from it. Especially with phpunit,
you should put Luis Uribe <acme at eviled.org> in the loop. He worked a lot
last year on PHPUnit together with me. If things happened, and we have
phpunit in Wheezy, it's thanks to him as well.

Thomas



More information about the pkg-php-pear mailing list