[pkg-php-pear] symfony copyright review (Was: Let's reconsider the way Symfony2 Components are packaged for Debian)

[Daniel Beyer]

Hi David,

On Thu, 2014-09-11 at 23:16 +0200, Daniel Beyer wrote:
> On Wed, 2014-09-10 at 00:42 +0200, Daniel Beyer wrote:
> > Hi David,
> > 
> > On Mon, 2014-09-08 at 15:21 -0400, David Prévot wrote:
> > > Hi Daniel,
> > > 
> > > (...)
> > > 
> > > Great job with the copyright! After a first quick pass, the only issue
> > > that is still to address (besides possible cosmetic factorizing) IMHO
> > > seems about documenting some images/icons copyrights:
> > > 
>  (...)
> >
> > licensing of the icons you mentioned above is still open. I'll take care
> > about that hopefully last license related thing tomorrow morning.
> >
> 
> It turned out to be quite complex and much more time consuming, than I
> ever could have imagined. I'm still on it, but have hope to get it done
> by tomorrow.
> 

Looks like I'm very bad with my estimates, but I finally managed to deal
with the licensing of any image found in the symfony src.
The changes to d/copyright itself weren't that huge (expect for adding
the text of CC-BY-3.0-US). You can base a diff on that file on 5409e21.

In dir d/licensing/ I added two interesting new things:
* image-checksums.dcf
It contains information related to licensing for each image, which I
painstakingly manually collected from upstreams git log. I choose
licenses in the following way:
 - From glyphish.com's free icon set: CC-BY-3.0-US 
 - Added by SensioLabs and an icon: CC-BY-SA-3.0
 - Contribution from the community: Expat

* bin/check_image_licenses
A script I wrote to deal with the licensing of images in Symfony (it has
a --help option, that should explain how to use it). 
It is run with option '--check' in d/rules, which matches d/copyright
and d/licensing/image-checksums.dcf and lets the build of the package
fail in case new images gets added or existing one are changed or
removed.

If you up for a review of the licensing of the images, I suggest to run:
# ./debian/licensing/bin/check_image_licenses \
     --generate-html-image-index
This will render a html containing useful information at:
./debian/tmp/icon_license_check/index.html

Once symfony components are on its way into Debian, I intend to get in
touch with upstream about the licenses used in symfony at a whole and
the licensing of the images in particular. Maybe they are willing to
provide and maintain this matter by themself in future.
Btw: In case they simplify licensing of the icons in their own interest,
I'll drop the whole d/licensing folder immediately.


Greetings
Daniel

PS: I now care about having tests run during build of the package +
DEP-8. I'm on it with all speed, but no more estimates - I'm to bad with
that at the moment...


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20140916/9c57216d/attachment.sig>