[Pkg-puppet-devel] [SCM] Puppet packaging for Debian branch, upstream, updated. 2.6.5rc1-120-g2247c80

Daniel Pittman daniel at rimspace.net
Mon Feb 7 06:41:50 UTC 2011


The following commit has been merged in the upstream branch:
commit eb97aa5f7cbf3800a22849f29fad555b0ca042d9
Author: Daniel Pittman <daniel at rimspace.net>
Date:   Mon Jan 31 10:50:00 2011 -0800

    Bug #6091 -- test leading double-slash in filenames are allowed.
    
    They presently are not; this ensures that we verify that before merging a
    change that fixes bugs in the area.

diff --git a/spec/unit/type/file_spec.rb b/spec/unit/type/file_spec.rb
index 51c27c0..db0fa9f 100755
--- a/spec/unit/type/file_spec.rb
+++ b/spec/unit/type/file_spec.rb
@@ -194,6 +194,23 @@ describe Puppet::Type.type(:file) do
         file = Puppet::Type::File.new(:path => "/")
         file[:path].should == "/"
       end
+
+      it "should accept a double-slash at the start of the path" do
+        expect {
+          file = Puppet::Type::File.new(:path => "//tmp/xxx")
+          # REVISIT: This should be wrong, later.  See the next test.
+          # --daniel 2011-01-31
+          file[:path].should == '/tmp/xxx'
+        }.should_not raise_error
+      end
+
+      # REVISIT: This is pending, because I don't want to try and audit the
+      # entire codebase to make sure we get this right.  POSIX treats two (and
+      # exactly two) '/' characters at the start of the path specially.
+      #
+      # See sections 3.2 and 4.11, which allow DomainOS to be all special like
+      # and still have the POSIX branding and all. --daniel 2011-01-31
+      it "should preserve the double-slash at the start of the path"
     end
 
     describe "on Microsoft Windows systems" do

-- 
Puppet packaging for Debian



More information about the Pkg-puppet-devel mailing list