[Pkg-puppet-devel] [SCM] Packaging of Facter for debian branch, experimental_upstream, updated. 1.5.9-54-g5a4eeed

Jacob Helwig jacob at puppetlabs.com
Wed Jun 22 08:51:43 UTC 2011

The following commit has been merged in the experimental_upstream branch:
commit 1063753df8938d4ea350199a4dcedd6c08c2d092
Author: Jacob Helwig <jacob at puppetlabs.com>
Date:   Mon Mar 28 11:08:29 2011 -0700

    (#6862) Add a default subject for the mail_patches rake task
    This will prevent committers to forget to write cover letter subject
    when rake mail_patches needs to send multiple e-mails.
    It defaults to the "type" and "branch name" of the patch-set.
    This is taken from Brice's patch against Puppet
    Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>

diff --git a/tasks/rake/mail_patches.rake b/tasks/rake/mail_patches.rake
index be8dda1..1346faa 100644
--- a/tasks/rake/mail_patches.rake
+++ b/tasks/rake/mail_patches.rake
@@ -34,12 +34,14 @@ task :mail_patches do
     # If we've got more than one patch, add --compose
     if files.length > 1
         compose = "--compose"
+        subject = %Q{--subject "#{type} #{name} against #{parent}"}
         compose = ""
+        subject = ""
     # Now send the mail.
-    sh "git send-email #{compose} --no-signed-off-by-cc --suppress-from --to puppet-dev at googlegroups.com 00*.patch"
+    sh "git send-email #{compose} #{subject} --no-signed-off-by-cc --suppress-from --to puppet-dev at googlegroups.com 00*.patch"
     # Finally, clean up the patches
     sh "rm 00*.patch"

Packaging of Facter for debian

More information about the Pkg-puppet-devel mailing list